* [PATCH 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
@ 2025-07-10 17:46 ` Laurent Pinchart
2025-07-10 23:10 ` Rob Herring (Arm)
2025-07-10 17:46 ` [PATCH 02/72] dt-bindings: media: et8ek8: Deprecate clock-frequency property Laurent Pinchart
` (14 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:46 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Dongchun Zhu, Lad Prabhakar,
Todor Tomov, devicetree
Usage of the clock-frequency property for camera sensors is discouraged
in favour of using assigned-clock-rates (and assigned-clock-parents
where needed). Mark the property as deprecated.
Update the examples accordingly. In DT examples where the sensor input
clock appears to come from a programmable clock generator, replace
clock-frequency by the assigned-clocks and assigned-clock-rates
properties. Otherwise, just drop clock-frequency.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++--
.../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +--
.../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++-
.../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++-
.../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +--
.../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++-
.../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++-
.../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++--
8 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
index bc664a016396..217b08c8cbbd 100644
--- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
@@ -55,6 +55,7 @@ properties:
clock-frequency:
description: Frequency of the external clock to the sensor in Hz.
+ deprecated: true
reset-gpios:
description: Reset GPIO. Also commonly called XSHUTDOWN in hardware
@@ -93,7 +94,6 @@ properties:
required:
- compatible
- reg
- - clock-frequency
- clocks
additionalProperties: false
@@ -114,8 +114,11 @@ examples:
reg = <0x10>;
reset-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
vana-supply = <&vaux3>;
+
clocks = <&omap3_isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&omap3_isp 0>;
+ assigned-clock-rates = <9600000>;
+
port {
ccs_ep: endpoint {
data-lanes = <1 2>;
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
index 67c1c291327b..0e1d9c390180 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
@@ -39,6 +39,7 @@ properties:
clock-frequency:
description:
Frequency of the eclk clock in Hz.
+ deprecated: true
dovdd-supply:
description:
@@ -100,7 +101,6 @@ required:
- reg
- clocks
- clock-names
- - clock-frequency
- dovdd-supply
- avdd-supply
- dvdd-supply
@@ -127,7 +127,6 @@ examples:
clocks = <&ov02a10_clk>;
clock-names = "eclk";
- clock-frequency = <24000000>;
rotation = <180>;
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml
index bc9b27afe3ea..a583714b1ac7 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml
@@ -21,6 +21,7 @@ properties:
clock-frequency:
description: Frequency of the xclk clock in Hz.
+ deprecated: true
vdda-supply:
description: Analog voltage supply, 2.8 volts
@@ -83,8 +84,11 @@ examples:
camera@3c {
compatible = "ovti,ov5645";
reg = <0x3c>;
+
clocks = <&clks 1>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks 1>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <&ov5645_vdddo_1v8>;
vdda-supply = <&ov5645_vdda_2v8>;
vddd-supply = <&ov5645_vddd_1v5>;
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
index 2e5187acbbb8..922996da59b2 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
@@ -29,6 +29,7 @@ properties:
clock-frequency:
description: Frequency of the xclk clock in Hz.
+ deprecated: true
vdda-supply:
description: Analog voltage supply, 2.8 volts
@@ -89,8 +90,11 @@ examples:
camera@3c {
compatible = "ovti,ov7251";
reg = <0x3c>;
+
clocks = <&clks 1>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks 1>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <&ov7251_vdddo_1v8>;
vdda-supply = <&ov7251_vdda_2v8>;
vddd-supply = <&ov7251_vddd_1v5>;
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
index 3f6f72c35485..fa71f24823f2 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
@@ -37,6 +37,7 @@ properties:
clock-frequency:
description:
Frequency of the xvclk clock in Hertz.
+ deprecated: true
dovdd-supply:
description:
@@ -87,7 +88,6 @@ required:
- reg
- clocks
- clock-names
- - clock-frequency
- dovdd-supply
- avdd-supply
- dvdd-supply
@@ -114,7 +114,6 @@ examples:
clocks = <&cam_osc>;
clock-names = "xvclk";
- clock-frequency = <19200000>;
avdd-supply = <&mt6358_vcama2_reg>;
dvdd-supply = <&mt6358_vcamd_reg>;
diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml
index c8f2955e0825..ebd95a8d9b2f 100644
--- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml
@@ -26,6 +26,7 @@ properties:
clock-frequency:
default: 24000000
description: mclk clock frequency
+ deprecated: true
rstn-gpios:
maxItems: 1
@@ -82,9 +83,12 @@ examples:
sensor@2d {
compatible = "samsung,s5k5baf";
reg = <0x2d>;
+
clocks = <&camera 0>;
+ assigned-clocks = <&camera 0>;
+ assigned-clock-rates = <24000000>;
+
clock-names = "mclk";
- clock-frequency = <24000000>;
rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>;
stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>;
vdda-supply = <&cam_io_en_reg>;
diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml
index 7e83a94124b5..e563e35920c4 100644
--- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml
@@ -30,6 +30,7 @@ properties:
clock-frequency:
default: 24000000
description: extclk clock frequency
+ deprecated: true
gpios:
maxItems: 1
@@ -80,8 +81,11 @@ examples:
sensor@10 {
compatible = "samsung,s5k6a3";
reg = <0x10>;
- clock-frequency = <24000000>;
+
clocks = <&camera 1>;
+ assigned-clocks = <&camera 1>;
+ assigned-clock-rates = <24000000>;
+
clock-names = "extclk";
gpios = <&gpm1 6 GPIO_ACTIVE_LOW>;
afvdd-supply = <&ldo19_reg>;
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
index 990acf89af8f..484039671cd1 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
@@ -51,6 +51,7 @@ properties:
clock-frequency:
description: Frequency of the xclk clock in Hz
+ deprecated: true
vdda-supply:
description: Analog power supply (2.9V)
@@ -100,7 +101,6 @@ required:
- reg
- clocks
- clock-names
- - clock-frequency
- vdda-supply
- vddd-supply
- vdddo-supply
@@ -125,7 +125,8 @@ examples:
clocks = <&gcc 90>;
clock-names = "xclk";
- clock-frequency = <37125000>;
+ assigned-clocks = <&clks 1>;
+ assigned-clock-rates = <37125000>;
vdddo-supply = <&camera_vdddo_1v8>;
vdda-supply = <&camera_vdda_2v8>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors
2025-07-10 17:46 ` [PATCH 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart
@ 2025-07-10 23:10 ` Rob Herring (Arm)
0 siblings, 0 replies; 51+ messages in thread
From: Rob Herring (Arm) @ 2025-07-10 23:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Conor Dooley, Lad Prabhakar, Sakari Ailus, devicetree,
Dongchun Zhu, Mehdi Djait, linux-media, Manivannan Sadhasivam,
Todor Tomov, Krzysztof Kozlowski
On Thu, 10 Jul 2025 20:46:57 +0300, Laurent Pinchart wrote:
> Usage of the clock-frequency property for camera sensors is discouraged
> in favour of using assigned-clock-rates (and assigned-clock-parents
> where needed). Mark the property as deprecated.
>
> Update the examples accordingly. In DT examples where the sensor input
> clock appears to come from a programmable clock generator, replace
> clock-frequency by the assigned-clocks and assigned-clock-rates
> properties. Otherwise, just drop clock-frequency.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++--
> .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +--
> .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +--
> .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++--
> 8 files changed, 30 insertions(+), 12 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 02/72] dt-bindings: media: et8ek8: Deprecate clock-frequency property
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
2025-07-10 17:46 ` [PATCH 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart
@ 2025-07-10 17:46 ` Laurent Pinchart
2025-07-10 23:11 ` Rob Herring (Arm)
2025-07-10 17:46 ` [PATCH 03/72] dt-bindings: media: imx258: Make clocks property required Laurent Pinchart
` (13 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:46 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree
Usage of the clock-frequency property for camera sensors is discouraged
in favour of using assigned-clock-rates (and assigned-clock-parents
where needed). Drop the property, and update the example accordingly.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
.../devicetree/bindings/media/i2c/toshiba,et8ek8.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
index e80d5891b7ed..8d8e40c56872 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
@@ -13,9 +13,6 @@ Mandatory properties
- reg: I2C address (0x3e, or an alternative address)
- vana-supply: Analogue voltage supply (VANA), 2.8 volts
- clocks: External clock to the sensor
-- clock-frequency: Frequency of the external clock to the sensor. Camera
- driver will set this frequency on the external clock. The clock frequency is
- a pre-determined frequency known to be suitable to the board.
- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
is in hardware standby mode when the signal is in the low state.
@@ -43,8 +40,11 @@ Example
compatible = "toshiba,et8ek8";
reg = <0x3e>;
vana-supply = <&vaux4>;
+
clocks = <&isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+
reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
port {
csi_cam1: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 02/72] dt-bindings: media: et8ek8: Deprecate clock-frequency property
2025-07-10 17:46 ` [PATCH 02/72] dt-bindings: media: et8ek8: Deprecate clock-frequency property Laurent Pinchart
@ 2025-07-10 23:11 ` Rob Herring (Arm)
0 siblings, 0 replies; 51+ messages in thread
From: Rob Herring (Arm) @ 2025-07-10 23:11 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Krzysztof Kozlowski, Conor Dooley, Mehdi Djait,
devicetree, Sakari Ailus
On Thu, 10 Jul 2025 20:46:58 +0300, Laurent Pinchart wrote:
> Usage of the clock-frequency property for camera sensors is discouraged
> in favour of using assigned-clock-rates (and assigned-clock-parents
> where needed). Drop the property, and update the example accordingly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 03/72] dt-bindings: media: imx258: Make clocks property required
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
2025-07-10 17:46 ` [PATCH 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart
2025-07-10 17:46 ` [PATCH 02/72] dt-bindings: media: et8ek8: Deprecate clock-frequency property Laurent Pinchart
@ 2025-07-10 17:46 ` Laurent Pinchart
2025-07-10 23:11 ` Rob Herring (Arm)
2025-07-10 17:47 ` [PATCH 04/72] dt-bindings: media: imx274: " Laurent Pinchart
` (12 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:46 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree
The sensor requires an external clock, and drivers need to access the
clock to retrieve its frequency in order to configure the sensor. This
makes usage of the clocks property mandatory for a system to work
properly. Mark the property as required.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
index 421b935b52bc..d105bd357dbb 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
@@ -81,6 +81,7 @@ properties:
required:
- compatible
- reg
+ - clocks
- port
unevaluatedProperties: false
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 03/72] dt-bindings: media: imx258: Make clocks property required
2025-07-10 17:46 ` [PATCH 03/72] dt-bindings: media: imx258: Make clocks property required Laurent Pinchart
@ 2025-07-10 23:11 ` Rob Herring (Arm)
0 siblings, 0 replies; 51+ messages in thread
From: Rob Herring (Arm) @ 2025-07-10 23:11 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mehdi Djait, Conor Dooley, Krzysztof Kozlowski, devicetree,
linux-media, Sakari Ailus
On Thu, 10 Jul 2025 20:46:59 +0300, Laurent Pinchart wrote:
> The sensor requires an external clock, and drivers need to access the
> clock to retrieve its frequency in order to configure the sensor. This
> makes usage of the clocks property mandatory for a system to work
> properly. Mark the property as required.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 04/72] dt-bindings: media: imx274: Make clocks property required
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (2 preceding siblings ...)
2025-07-10 17:46 ` [PATCH 03/72] dt-bindings: media: imx258: Make clocks property required Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 19:37 ` Rob Herring (Arm)
2025-07-10 17:47 ` [PATCH 05/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node Laurent Pinchart
` (11 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Leon Luo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree
The sensor requires an external clock, and drivers need to access the
clock to retrieve its frequency in order to configure the sensor. This
makes usage of the clocks property mandatory for a system to work
properly. Mark the clocks and clock-names properties as required, and
update the example accordingly.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
index b397a730ee94..b06a6e75ba97 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
@@ -46,6 +46,8 @@ properties:
required:
- compatible
- reg
+ - clocks
+ - clock-names
- port
additionalProperties: false
@@ -59,6 +61,8 @@ examples:
imx274: camera-sensor@1a {
compatible = "sony,imx274";
reg = <0x1a>;
+ clocks = <&imx274_clk>;
+ clock-names = "inck";
reset-gpios = <&gpio_sensor 0 0>;
port {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 04/72] dt-bindings: media: imx274: Make clocks property required
2025-07-10 17:47 ` [PATCH 04/72] dt-bindings: media: imx274: " Laurent Pinchart
@ 2025-07-10 19:37 ` Rob Herring (Arm)
2025-07-10 20:33 ` Laurent Pinchart
0 siblings, 1 reply; 51+ messages in thread
From: Rob Herring (Arm) @ 2025-07-10 19:37 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, linux-media, Conor Dooley, Krzysztof Kozlowski,
Mehdi Djait, devicetree, Leon Luo
On Thu, 10 Jul 2025 20:47:00 +0300, Laurent Pinchart wrote:
> The sensor requires an external clock, and drivers need to access the
> clock to retrieve its frequency in order to configure the sensor. This
> makes usage of the clocks property mandatory for a system to work
> properly. Mark the clocks and clock-names properties as required, and
> update the example accordingly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.example.dtb: sensor@1a (sony,imx274): 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.example.dtb: sensor@1a (sony,imx274): 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250710174808.5361-5-laurent.pinchart@ideasonboard.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 04/72] dt-bindings: media: imx274: Make clocks property required
2025-07-10 19:37 ` Rob Herring (Arm)
@ 2025-07-10 20:33 ` Laurent Pinchart
0 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 20:33 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Sakari Ailus, linux-media, Conor Dooley, Krzysztof Kozlowski,
Mehdi Djait, devicetree, Leon Luo
On Thu, Jul 10, 2025 at 02:37:15PM -0500, Rob Herring (Arm) wrote:
> On Thu, 10 Jul 2025 20:47:00 +0300, Laurent Pinchart wrote:
> > The sensor requires an external clock, and drivers need to access the
> > clock to retrieve its frequency in order to configure the sensor. This
> > makes usage of the clocks property mandatory for a system to work
> > properly. Mark the clocks and clock-names properties as required, and
> > update the example accordingly.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.example.dtb: sensor@1a (sony,imx274): 'clocks' is a required property
> from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.example.dtb: sensor@1a (sony,imx274): 'clock-names' is a required property
> from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
I noticed that after sending the patches. I checked the bindings I was
modifying, but forgot that some other bindings could reference them.
Sorry about that, I've already fixed the problem in my tree.
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250710174808.5361-5-laurent.pinchart@ideasonboard.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 05/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (3 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 04/72] dt-bindings: media: imx274: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 20:19 ` Frank Li
2025-07-10 17:47 ` [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
` (10 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
index c39a9ebdaba1..7821404687f4 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
@@ -232,8 +232,11 @@ camera@3c {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ov5645>;
reg = <0x3c>;
+
clocks = <&clks IMX6QDL_CLK_CKO2>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <®_1p8v>;
vdda-supply = <®_2p8v>;
vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 05/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2025-07-10 17:47 ` [PATCH 05/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node Laurent Pinchart
@ 2025-07-10 20:19 ` Frank Li
0 siblings, 0 replies; 51+ messages in thread
From: Frank Li @ 2025-07-10 20:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel
On Thu, Jul 10, 2025 at 08:47:01PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> index c39a9ebdaba1..7821404687f4 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> @@ -232,8 +232,11 @@ camera@3c {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ov5645>;
> reg = <0x3c>;
> +
unnecessary empty line here
Frank
> clocks = <&clks IMX6QDL_CLK_CKO2>;
> - clock-frequency = <24000000>;
> + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> + assigned-clock-rates = <24000000>;
> +
> vdddo-supply = <®_1p8v>;
> vdda-supply = <®_2p8v>;
> vddd-supply = <®_1p5v>;
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (4 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 05/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 20:18 ` Frank Li
2025-07-10 17:47 ` [PATCH 07/72] ARM: dts: samsung: exynos4210-i9100: " Laurent Pinchart
` (9 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
index 26489eccd5fb..e5ac78ffb31c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
@@ -136,8 +136,11 @@ camera@3c {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ov5645>;
reg = <0x3c>;
+
clocks = <&clks IMX6QDL_CLK_CKO2>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <®_1p8v>;
vdda-supply = <®_2p8v>;
vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node
2025-07-10 17:47 ` [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
@ 2025-07-10 20:18 ` Frank Li
2025-07-10 20:34 ` Laurent Pinchart
0 siblings, 1 reply; 51+ messages in thread
From: Frank Li @ 2025-07-10 20:18 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel
On Thu, Jul 10, 2025 at 08:47:02PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> index 26489eccd5fb..e5ac78ffb31c 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> @@ -136,8 +136,11 @@ camera@3c {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ov5645>;
> reg = <0x3c>;
> +
unnecessary empty line here
Frank Li
> clocks = <&clks IMX6QDL_CLK_CKO2>;
> - clock-frequency = <24000000>;
> + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> + assigned-clock-rates = <24000000>;
> +
> vdddo-supply = <®_1p8v>;
> vdda-supply = <®_2p8v>;
> vddd-supply = <®_1p5v>;
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node
2025-07-10 20:18 ` Frank Li
@ 2025-07-10 20:34 ` Laurent Pinchart
2025-07-11 5:17 ` Frank Li
0 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 20:34 UTC (permalink / raw)
To: Frank Li
Cc: linux-media, Sakari Ailus, Mehdi Djait, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel
Hi Frank,
On Thu, Jul 10, 2025 at 04:18:39PM -0400, Frank Li wrote:
> On Thu, Jul 10, 2025 at 08:47:02PM +0300, Laurent Pinchart wrote:
> > The clock-frequency for camera sensors has been deprecated in favour of
> > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > the device tree.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > index 26489eccd5fb..e5ac78ffb31c 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > @@ -136,8 +136,11 @@ camera@3c {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_ov5645>;
> > reg = <0x3c>;
> > +
>
> unnecessary empty line here
There's often a blank line after the reg property. I don't mind dropping
it here if that's preferred. Same for the other patch you reviewed.
> > clocks = <&clks IMX6QDL_CLK_CKO2>;
> > - clock-frequency = <24000000>;
> > + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > + assigned-clock-rates = <24000000>;
> > +
> > vdddo-supply = <®_1p8v>;
> > vdda-supply = <®_2p8v>;
> > vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node
2025-07-10 20:34 ` Laurent Pinchart
@ 2025-07-11 5:17 ` Frank Li
0 siblings, 0 replies; 51+ messages in thread
From: Frank Li @ 2025-07-11 5:17 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel
On Thu, Jul 10, 2025 at 11:34:21PM +0300, Laurent Pinchart wrote:
> Hi Frank,
>
> On Thu, Jul 10, 2025 at 04:18:39PM -0400, Frank Li wrote:
> > On Thu, Jul 10, 2025 at 08:47:02PM +0300, Laurent Pinchart wrote:
> > > The clock-frequency for camera sensors has been deprecated in favour of
> > > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > > the device tree.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > index 26489eccd5fb..e5ac78ffb31c 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > @@ -136,8 +136,11 @@ camera@3c {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_ov5645>;
> > > reg = <0x3c>;
> > > +
> >
> > unnecessary empty line here
>
> There's often a blank line after the reg property. I don't mind dropping
> it here if that's preferred. Same for the other patch you reviewed.
This patch just drop clock-frequency. empty line is not related this at
all. So I perfer drop it.
Frank
>
> > > clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > - clock-frequency = <24000000>;
> > > + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > + assigned-clock-rates = <24000000>;
> > > +
> > > vdddo-supply = <®_1p8v>;
> > > vdda-supply = <®_2p8v>;
> > > vddd-supply = <®_1p5v>;
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 07/72] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (5 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 17:47 ` [PATCH 08/72] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart
` (8 subsequent siblings)
15 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
index 0d8495792a70..cdc768a87757 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
@@ -169,11 +169,14 @@ image-sensor@2d {
vdda-supply = <&cam_io_en_reg>;
vddreg-supply = <&vt_core_15v_reg>;
vddio-supply = <&vtcam_reg>;
+
clocks = <&camera 0>;
clock-names = "mclk";
+ assigned-clocks = <&camera 0>;
+ assigned-clock-rates = <24000000>;
+
stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>;
rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>;
- clock-frequency = <24000000>;
port {
s5k5bafx_ep: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* [PATCH 08/72] ARM: dts: samsung: exynos4412-midas: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (6 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 07/72] ARM: dts: samsung: exynos4210-i9100: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 17:47 ` [PATCH 09/72] ARM: dts: ti: omap3-n900: " Laurent Pinchart
` (7 subsequent siblings)
15 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
index 3d5aace668dc..06eaf351fa3a 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
@@ -638,10 +638,13 @@ image-sensor@10 {
svdda-supply = <&cam_io_reg>;
svddio-supply = <&ldo19_reg>;
afvdd-supply = <&ldo19_reg>;
- clock-frequency = <24000000>;
+
/* CAM_B_CLKOUT */
clocks = <&camera 1>;
clock-names = "extclk";
+ assigned-clocks = <&camera 1>;
+ assigned-clock-rates = <24000000>;
+
gpios = <&gpm1 6 GPIO_ACTIVE_LOW>;
port {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* [PATCH 09/72] ARM: dts: ti: omap3-n900: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (7 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 08/72] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 17:47 ` [PATCH 10/72] ARM: dts: ti: omap3-n950: " Laurent Pinchart
` (6 subsequent siblings)
15 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Tony Lindgren, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-omap, devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n900.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n900.dts b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
index c50ca572d1b9..0d4ceaf96f66 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n900.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
@@ -792,7 +792,8 @@ cam1: camera@3e {
clocks = <&isp 0>;
clock-names = "extclk";
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* [PATCH 10/72] ARM: dts: ti: omap3-n950: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (8 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 09/72] ARM: dts: ti: omap3-n900: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 17:47 ` [PATCH 11/72] ARM: dts: ti: omap3-n9: " Laurent Pinchart
` (5 subsequent siblings)
15 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Tony Lindgren, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-omap, devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n950.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n950.dts b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
index b99f97880204..2864ed8dd6c3 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n950.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
@@ -74,8 +74,11 @@ smia_1: camera@10 {
reg = <0x10>;
/* No reset gpio */
vana-supply = <&vaux3>;
+
clocks = <&isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+
flash-leds = <&as3645a_flash &as3645a_indicator>;
port {
smia_1_1: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* [PATCH 11/72] ARM: dts: ti: omap3-n9: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (9 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 10/72] ARM: dts: ti: omap3-n950: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-10 17:47 ` [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: " Laurent Pinchart
` (4 subsequent siblings)
15 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Tony Lindgren, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-omap, devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n9.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n9.dts b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
index a3cf3f443785..2edc1933449b 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n9.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
@@ -21,8 +21,11 @@ smia_1: camera@10 {
reg = <0x10>;
/* No reset gpio */
vana-supply = <&vaux3>;
+
clocks = <&isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+
flash-leds = <&as3645a_flash &as3645a_indicator>;
port {
smia_1_1: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (10 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 11/72] ARM: dts: ti: omap3-n9: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-11 12:25 ` Konrad Dybcio
2025-07-10 17:47 ` [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from " Laurent Pinchart
` (3 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
.../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
index 51f1a4883ab8..dbe1911d8e47 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
@@ -44,7 +44,8 @@ camera@10 {
clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
clock-names = "xvclk";
- clock-frequency = <19200000>;
+ assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
+ assigned-clock-rates = <19200000>;
/*
* The &vreg_s4a_1p8 trace is powered on as a,
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
2025-07-10 17:47 ` [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: " Laurent Pinchart
@ 2025-07-11 12:25 ` Konrad Dybcio
2025-07-11 12:45 ` Laurent Pinchart
0 siblings, 1 reply; 51+ messages in thread
From: Konrad Dybcio @ 2025-07-11 12:25 UTC (permalink / raw)
To: Laurent Pinchart, linux-media
Cc: Sakari Ailus, Mehdi Djait, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree
On 7/10/25 7:47 PM, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> index 51f1a4883ab8..dbe1911d8e47 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> @@ -44,7 +44,8 @@ camera@10 {
>
> clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> clock-names = "xvclk";
> - clock-frequency = <19200000>;
> + assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> + assigned-clock-rates = <19200000>;
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
(although your patches still seem to leave clk_set_rate in
ov8856.c anyway?)
Konrad
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
2025-07-11 12:25 ` Konrad Dybcio
@ 2025-07-11 12:45 ` Laurent Pinchart
2025-07-11 12:47 ` Konrad Dybcio
0 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-11 12:45 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-media, Sakari Ailus, Mehdi Djait, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree
Hi Konrad,
On Fri, Jul 11, 2025 at 02:25:14PM +0200, Konrad Dybcio wrote:
> On 7/10/25 7:47 PM, Laurent Pinchart wrote:
> > The clock-frequency for camera sensors has been deprecated in favour of
> > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > the device tree.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > .../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > index 51f1a4883ab8..dbe1911d8e47 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > @@ -44,7 +44,8 @@ camera@10 {
> >
> > clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> > clock-names = "xvclk";
> > - clock-frequency = <19200000>;
> > + assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> > + assigned-clock-rates = <19200000>;
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> (although your patches still seem to leave clk_set_rate in
> ov8856.c anyway?)
The call gets removed in patch 69/72 ([1]). It gets replaced by
devm_v4l2_sensor_clk_get_legacy(), which internally calls
clk_set_rate(), so the behaviour is preserved to avoid breaking backward
compatibility with old DTs.
[1] https://lore.kernel.org/linux-media/20250710174808.5361-70-laurent.pinchart@ideasonboard.com
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
2025-07-11 12:45 ` Laurent Pinchart
@ 2025-07-11 12:47 ` Konrad Dybcio
0 siblings, 0 replies; 51+ messages in thread
From: Konrad Dybcio @ 2025-07-11 12:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree
On 7/11/25 2:45 PM, Laurent Pinchart wrote:
> Hi Konrad,
>
> On Fri, Jul 11, 2025 at 02:25:14PM +0200, Konrad Dybcio wrote:
>> On 7/10/25 7:47 PM, Laurent Pinchart wrote:
>>> The clock-frequency for camera sensors has been deprecated in favour of
>>> the assigned-clocks and assigned-clock-rates properties. Replace it in
>>> the device tree.
>>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>> .../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
>>> index 51f1a4883ab8..dbe1911d8e47 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
>>> @@ -44,7 +44,8 @@ camera@10 {
>>>
>>> clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
>>> clock-names = "xvclk";
>>> - clock-frequency = <19200000>;
>>> + assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
>>> + assigned-clock-rates = <19200000>;
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> (although your patches still seem to leave clk_set_rate in
>> ov8856.c anyway?)
>
> The call gets removed in patch 69/72 ([1]). It gets replaced by
> devm_v4l2_sensor_clk_get_legacy(), which internally calls
> clk_set_rate(), so the behaviour is preserved to avoid breaking backward
> compatibility with old DTs.
>
> [1] https://lore.kernel.org/linux-media/20250710174808.5361-70-laurent.pinchart@ideasonboard.com
Overlooked that, thanks
Konrad
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (11 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-28 14:19 ` Geert Uytterhoeven
2025-07-10 17:47 ` [PATCH 14/72] arm64: dts: renesas: rzg2l-smarc: " Laurent Pinchart
` (2 subsequent siblings)
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Geert Uytterhoeven, Magnus Damm,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-renesas-soc,
devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. As the clock
source for the sensor is a fixed-frequency oscillator, simply drop the
clock-frequency.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
index 7cb5c958aece..529388f6bf2b 100644
--- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
+++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
@@ -66,7 +66,6 @@ ov5645: ov5645@3c {
compatible = "ovti,ov5645";
reg = <0x3c>;
clocks = <&osc25250_clk>;
- clock-frequency = <24000000>;
vdddo-supply = <&ov5645_vdddo_1v8>;
vdda-supply = <&ov5645_vdda_2v8>;
vddd-supply = <&ov5645_vddd_1v5>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from camera sensor node
2025-07-10 17:47 ` [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from " Laurent Pinchart
@ 2025-07-28 14:19 ` Geert Uytterhoeven
2025-07-28 15:08 ` Laurent Pinchart
0 siblings, 1 reply; 51+ messages in thread
From: Geert Uytterhoeven @ 2025-07-28 14:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Geert Uytterhoeven,
Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-renesas-soc, devicetree
Hi Laurent,
On Thu, 10 Jul 2025 at 19:49, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. As the clock
> source for the sensor is a fixed-frequency oscillator, simply drop the
> clock-frequency.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Doesn't this patch have a hard dependency on "[PATCH 66/72] media:
i2c: ov5645: Use V4L2 legacy sensor clock helper", and thus shouldn't
this patch be moved after the latter in this series?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from camera sensor node
2025-07-28 14:19 ` Geert Uytterhoeven
@ 2025-07-28 15:08 ` Laurent Pinchart
0 siblings, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-28 15:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-media, Sakari Ailus, Mehdi Djait, Geert Uytterhoeven,
Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-renesas-soc, devicetree
On Mon, Jul 28, 2025 at 04:19:49PM +0200, Geert Uytterhoeven wrote:
> On Thu, 10 Jul 2025 at 19:49, Laurent Pinchart wrote:
> > The clock-frequency for camera sensors has been deprecated in favour of
> > the assigned-clocks and assigned-clock-rates properties. As the clock
> > source for the sensor is a fixed-frequency oscillator, simply drop the
> > clock-frequency.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Doesn't this patch have a hard dependency on "[PATCH 66/72] media:
> i2c: ov5645: Use V4L2 legacy sensor clock helper", and thus shouldn't
> this patch be moved after the latter in this series?
Apparently it does. I'll move the DT changes to the end of the series.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 14/72] arm64: dts: renesas: rzg2l-smarc: Drop clock-frequency from camera sensor node
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (12 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 13/72] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-frequency from " Laurent Pinchart
@ 2025-07-10 17:47 ` Laurent Pinchart
2025-07-28 14:20 ` Geert Uytterhoeven
2025-07-24 11:42 ` [PATCH 00/72] media: i2c: Reduce cargo-cult Tarang Raval
2025-08-11 23:27 ` (subset) " Bjorn Andersson
15 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-10 17:47 UTC (permalink / raw)
To: linux-media
Cc: Sakari Ailus, Mehdi Djait, Geert Uytterhoeven, Magnus Damm,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-renesas-soc,
devicetree
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. As the clock
source for the sensor is a fixed-frequency oscillator, simply drop the
clock-frequency.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi b/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
index c5bb63c63b47..4d2b0655859a 100644
--- a/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
+++ b/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
@@ -64,7 +64,6 @@ ov5645: camera@3c {
compatible = "ovti,ov5645";
reg = <0x3c>;
clocks = <&ov5645_fixed_clk>;
- clock-frequency = <24000000>;
vdddo-supply = <&ov5645_vdddo_1v8>;
vdda-supply = <&ov5645_vdda_2v8>;
vddd-supply = <&ov5645_vddd_1v5>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 51+ messages in thread* Re: [PATCH 14/72] arm64: dts: renesas: rzg2l-smarc: Drop clock-frequency from camera sensor node
2025-07-10 17:47 ` [PATCH 14/72] arm64: dts: renesas: rzg2l-smarc: " Laurent Pinchart
@ 2025-07-28 14:20 ` Geert Uytterhoeven
0 siblings, 0 replies; 51+ messages in thread
From: Geert Uytterhoeven @ 2025-07-28 14:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Sakari Ailus, Mehdi Djait, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-renesas-soc, devicetree
Hi Laurent,
On Thu, 10 Jul 2025 at 19:49, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. As the clock
> source for the sensor is a fixed-frequency oscillator, simply drop the
> clock-frequency.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Doesn't this patch have a hard dependency on "[PATCH 66/72] media:
i2c: ov5645: Use V4L2 legacy sensor clock helper", and thus shouldn't
this patch be moved after the latter in this series?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (13 preceding siblings ...)
2025-07-10 17:47 ` [PATCH 14/72] arm64: dts: renesas: rzg2l-smarc: " Laurent Pinchart
@ 2025-07-24 11:42 ` Tarang Raval
2025-07-24 11:52 ` Laurent Pinchart
2025-08-11 23:27 ` (subset) " Bjorn Andersson
15 siblings, 1 reply; 51+ messages in thread
From: Tarang Raval @ 2025-07-24 11:42 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media@vger.kernel.org, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bjorn Andersson,
Bryan O'Donoghue, Bryan O'Donoghue, Conor Dooley,
Daniel Scally, Dongcheng Yan, Dongchun Zhu, Fabio Estevam,
Geert Uytterhoeven, Hans de Goede, Hans Verkuil, Hao Yao,
Heimir Thor Sverrisson, Jacopo Mondi, Jason Chen, Jimmy Su,
Jingjing Xiong, Jonas Karlman, Konrad Dybcio, Krzysztof Kozlowski,
Lad Prabhakar, Leon Luo, Liam Girdwood, Magnus Damm,
Manivannan Sadhasivam, Mark Brown, Matthew Majewski,
Matthias Fend, Mikhail Rudenko, Nicolas Dufresne,
Niklas Söderlund, Pavel Machek, Pengutronix Kernel Team,
Ricardo Ribalda, Rob Herring, Sascha Hauer, Shawn Guo,
Shunqian Zheng, Sylvain Petinot, Sylwester Nawrocki, Tianshu Qiu,
Todor Tomov, Tomi Valkeinen, Tony Lindgren, Zhi Mao,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Hi Laurent,
> This patch series build on top of Mehdi's introduction of the
> devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
> cargo-cult in camera sensor drivers.
>
> A large number of camera sensor drivers directly use the
> "clock-frequency" property to retrieve the effective or desired external
> clock rate. This is standard behaviour on ACPI platforms that don't
> implement MIPI DisCo for Imaging, but usage of the property has leaked
> to OF-based platforms, due to a combination of historical reasons (using
> "clock-frequency" was initially considered right until before the
> introduction of "assigned-clock-rates") and plain cargo-cult.
>
> A large number of camera sensor drivers also set the rate of the
> external clock with clk_set_rate(). This behaviour is also fine on ACPI
> platforms, and has also leaked to OF-based platforms for the same
> reasons.
>
> Mehdi's "[PATCH v2 00/48] media: Add a helper for obtaining the clock
> producer" series improves the situation by centralizing clock handling
> for camera sensor in one helper function that implements the correct
> behaviour for all types of platforms (and should later allow support of
> MIPI DisCo for Imaging transparently for camera sensor drivers). It
> doesn't however address direct access of the "clock-frequency" property
> or direct calls to clk_set_rate() in drivers.
>
> This series builds on top of the new helper to replace manual handling
> of the clock frequency in camera sensor drivers. It starts by addressing
> the DT bindings and reprecating the clock-frequency property for camera
> sensor drivers in all YAML bindings (01/72) and in the et8ek8 text
> bindings (02/72). After that, patches 03/72 and 04/72 make the clocks
> property mandatory in the two camera sensor DT bindings that specified
> it as optional. Finally for the DT side, patches 05/72 to 14/72 replace
> clock-frequency with assigned-clock-rates, or drops the property
> altogether when the source clock has a fixed rate. This aligns the DT
> bindings and device tree sources to the current recommended practice.
>
> After that, the next 5 patches are assorted drive-by changes. Patch
> 15/72 drops an unused header the belonged to a long gone driver, and
> patch 17/72 drops unusued support for platform data in the mt9v032
> driver. Patch 18/72 is the first that addresses clock rate handling by
> dropping unneeded clock rate setting in the mt9v111 driver. Patch 19/72
> takes a harsher approach for the ov6650 by dropping the driver
> completely as the driver hasn't been used since v5.9.
>
> The next part of the series replaces manual clock rate handling with
> usage of the devm_v4l2_sensor_clk_get() helper in a large number of
> camera sensor drivers that implement clock rate handling in a standard
> way. This is done in patches 20/72 to 54/72. This interleaves the clock
> rate handling changes with drive-by refactoring (in separate patches) to
> make the code easier to deal with.
>
> The final part of the series addresses the remaining drivers that
> implement non-standard behaviours. It starts in 55/72 by adding a new
> devm_v4l2_sensor_clk_get_legacy() helper function for those drivers,
> similar to devm_v4l2_sensor_clk_get() but with a few more quirks. This
> function should not be used in any new driver. The remaining patches,
> from 53/72 to 72/72, use the new helper in drivers, interleaved with
> drive-by refactoring similarly to the previous part.
>
> Before this series, with Mehdi's series applied, 29 drivers read the
> "clock-frequency" property and 18 drivers set the external clock rate.
> With these series we go down to 1 and 3 respectively, namely the ccs,
> mt9p031 and mt9v032 drivers. Clock handling in the CCS driver is a bit
> more convoluted so I will leave to Sakari the honour of dropping the
> last direct user of "clock-frequency" :-) As for the mt9p031 and mt9v032
> driver, addressing the issue there is more difficult and likely not
> worth it.
>
> [1] https://lore.kernel.org/linux-media/cover.1750942967.git.mehdi.djait@linux.intel.com
>
> Laurent Pinchart (72):
> dt-bindings: media: Deprecate clock-frequency property for camera
> sensors
> dt-bindings: media: et8ek8: Deprecate clock-frequency property
> dt-bindings: media: imx258: Make clocks property required
> dt-bindings: media: imx274: Make clocks property required
> ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor
> node
> ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera
> sensor node
> ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera
> sensor node
> ARM: dts: samsung: exynos4412-midas: Replace clock-frequency in camera
> sensor node
> ARM: dts: ti: omap3-n900: Replace clock-frequency in camera sensor
> node
> ARM: dts: ti: omap3-n950: Replace clock-frequency in camera sensor
> node
> ARM: dts: ti: omap3-n9: Replace clock-frequency in camera sensor node
> arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace
> clock-frequency in camera sensor node
> arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop
> clock-frequency from camera sensor node
> arm64: dts: renesas: rzg2l-smarc: Drop clock-frequency from camera
> sensor node
> media: i2c: mt9v022: Drop unused mt9v022.h header
> media: i2c: mt9v032: Replace client->dev usage
> media: i2c: mt9v032: Drop support for platform data
> media: i2c: mt9v111: Do not set clock rate manually
> media: i2c: ov6650: Drop unused driver
> media: i2c: hi556: Replace client->dev usage
> media: i2c: hi556: Use V4L2 sensor clock helper
> media: i2c: hi847: Replace client->dev usage
> media: i2c: hi847: Use V4L2 sensor clock helper
> media: i2c: imx208: Replace client->dev usage
> media: i2c: imx208: Use V4L2 sensor clock helper
> media: i2c: imx319: Replace client->dev usage
> media: i2c: imx319: Use V4L2 sensor clock helper
> media: i2c: imx355: Replace client->dev usage
> media: i2c: imx335: Use V4L2 sensor clock helper
> media: i2c: og01a1b: Replace client->dev usage
> media: i2c: og01a1b: Use V4L2 sensor clock helper
> media: i2c: ov02c10: Replace client->dev usage
> media: i2c: ov02c10: Use V4L2 sensor clock helper
> media: i2c: ov02e10: Replace client->dev usage
> media: i2c: ov02e10: Use V4L2 sensor clock helper
> media: i2c: ov08d10: Replace client->dev usage
> media: i2c: ov08d10: Use V4L2 sensor clock helper
> media: i2c: ov08x40: Replace client->dev usage
> media: i2c: ov08x40: Use V4L2 sensor clock helper
> media: i2c: ov13858: Replace client->dev usage
> media: i2c: ov13858: Use V4L2 sensor clock helper
> media: i2c: ov13b10: Replace client->dev usage
> media: i2c: ov13b10: Use V4L2 sensor clock helper
> media: i2c: ov2740: Replace client->dev usage
> media: i2c: ov2740: Use V4L2 sensor clock helper
> media: i2c: ov4689: Use V4L2 sensor clock helper
> media: i2c: ov5670: Replace client->dev usage
> media: i2c: ov5670: Use V4L2 sensor clock helper
> media: i2c: ov5675: Replace client->dev usage
> media: i2c: ov5675: Use V4L2 sensor clock helper
> media: i2c: ov5693: Use V4L2 sensor clock helper
> media: i2c: ov7251: Use V4L2 sensor clock helper
> media: i2c: ov9734: Replace client->dev usage
> media: i2c: ov9734: Use V4L2 sensor clock helper
> media: v4l2-common: Add legacy camera sensor clock helper
> media: i2c: et8ek8: Drop support for per-mode external clock frequency
> media: i2c: et8ek8: Use V4L2 legacy sensor clock helper
> media: i2c: gc05a2: Use V4L2 legacy sensor clock helper
> media: i2c: gc08a3: Use V4L2 legacy sensor clock helper
> media: i2c: imx258: Replace client->dev usage
> media: i2c: imx258: Use V4L2 legacy sensor clock helper
> media: i2c: imx290: Use V4L2 legacy sensor clock helper
> media: i2c: ov02a10: Replace client->dev usage
> media: i2c: ov02a10: Use V4L2 legacy sensor clock helper
> media: i2c: ov2685: Use V4L2 legacy sensor clock helper
> media: i2c: ov5645: Use V4L2 legacy sensor clock helper
> media: i2c: ov5695: Use V4L2 legacy sensor clock helper
> media: i2c: ov8856: Replace client->dev usage
> media: i2c: ov8856: Use V4L2 legacy sensor clock helper
> media: i2c: s5c73m3: Use V4L2 legacy sensor clock helper
> media: i2c: s5k5baf: Use V4L2 legacy sensor clock helper
> media: i2c: s5k6a3: Use V4L2 legacy sensor clock helper
If you are planning a v2 version of this patch series, please consider
incorporating the following improvements:
1. In the imx219 driver, you can also replace direct client->dev usage.
2. In the regulator code, you can reduce boilerplate by using
devm_regulator_bulk_get_enable().
Otherwise, I will submit a separate patch series on top of yours to
address these points.
Best Regards,
Tarang
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-07-24 11:42 ` [PATCH 00/72] media: i2c: Reduce cargo-cult Tarang Raval
@ 2025-07-24 11:52 ` Laurent Pinchart
[not found] ` <PN3P287MB1829C9E8C78ADD70259A68F08B5EA@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
0 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-07-24 11:52 UTC (permalink / raw)
To: Tarang Raval
Cc: linux-media@vger.kernel.org, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bjorn Andersson,
Bryan O'Donoghue, Bryan O'Donoghue, Conor Dooley,
Daniel Scally, Dongcheng Yan, Dongchun Zhu, Fabio Estevam,
Geert Uytterhoeven, Hans de Goede, Hans Verkuil, Hao Yao,
Heimir Thor Sverrisson, Jacopo Mondi, Jason Chen, Jimmy Su,
Jingjing Xiong, Jonas Karlman, Konrad Dybcio, Krzysztof Kozlowski,
Lad Prabhakar, Leon Luo, Liam Girdwood, Magnus Damm,
Manivannan Sadhasivam, Mark Brown, Matthew Majewski,
Matthias Fend, Mikhail Rudenko, Nicolas Dufresne,
Niklas Söderlund, Pavel Machek, Pengutronix Kernel Team,
Ricardo Ribalda, Rob Herring, Sascha Hauer, Shawn Guo,
Shunqian Zheng, Sylvain Petinot, Sylwester Nawrocki, Tianshu Qiu,
Todor Tomov, Tomi Valkeinen, Tony Lindgren, Zhi Mao,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
On Thu, Jul 24, 2025 at 11:42:55AM +0000, Tarang Raval wrote:
> Hi Laurent,
>
> > This patch series build on top of Mehdi's introduction of the
> > devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
> > cargo-cult in camera sensor drivers.
> >
> > A large number of camera sensor drivers directly use the
> > "clock-frequency" property to retrieve the effective or desired external
> > clock rate. This is standard behaviour on ACPI platforms that don't
> > implement MIPI DisCo for Imaging, but usage of the property has leaked
> > to OF-based platforms, due to a combination of historical reasons (using
> > "clock-frequency" was initially considered right until before the
> > introduction of "assigned-clock-rates") and plain cargo-cult.
> >
> > A large number of camera sensor drivers also set the rate of the
> > external clock with clk_set_rate(). This behaviour is also fine on ACPI
> > platforms, and has also leaked to OF-based platforms for the same
> > reasons.
> >
> > Mehdi's "[PATCH v2 00/48] media: Add a helper for obtaining the clock
> > producer" series improves the situation by centralizing clock handling
> > for camera sensor in one helper function that implements the correct
> > behaviour for all types of platforms (and should later allow support of
> > MIPI DisCo for Imaging transparently for camera sensor drivers). It
> > doesn't however address direct access of the "clock-frequency" property
> > or direct calls to clk_set_rate() in drivers.
> >
> > This series builds on top of the new helper to replace manual handling
> > of the clock frequency in camera sensor drivers. It starts by addressing
> > the DT bindings and reprecating the clock-frequency property for camera
> > sensor drivers in all YAML bindings (01/72) and in the et8ek8 text
> > bindings (02/72). After that, patches 03/72 and 04/72 make the clocks
> > property mandatory in the two camera sensor DT bindings that specified
> > it as optional. Finally for the DT side, patches 05/72 to 14/72 replace
> > clock-frequency with assigned-clock-rates, or drops the property
> > altogether when the source clock has a fixed rate. This aligns the DT
> > bindings and device tree sources to the current recommended practice.
> >
> > After that, the next 5 patches are assorted drive-by changes. Patch
> > 15/72 drops an unused header the belonged to a long gone driver, and
> > patch 17/72 drops unusued support for platform data in the mt9v032
> > driver. Patch 18/72 is the first that addresses clock rate handling by
> > dropping unneeded clock rate setting in the mt9v111 driver. Patch 19/72
> > takes a harsher approach for the ov6650 by dropping the driver
> > completely as the driver hasn't been used since v5.9.
> >
> > The next part of the series replaces manual clock rate handling with
> > usage of the devm_v4l2_sensor_clk_get() helper in a large number of
> > camera sensor drivers that implement clock rate handling in a standard
> > way. This is done in patches 20/72 to 54/72. This interleaves the clock
> > rate handling changes with drive-by refactoring (in separate patches) to
> > make the code easier to deal with.
> >
> > The final part of the series addresses the remaining drivers that
> > implement non-standard behaviours. It starts in 55/72 by adding a new
> > devm_v4l2_sensor_clk_get_legacy() helper function for those drivers,
> > similar to devm_v4l2_sensor_clk_get() but with a few more quirks. This
> > function should not be used in any new driver. The remaining patches,
> > from 53/72 to 72/72, use the new helper in drivers, interleaved with
> > drive-by refactoring similarly to the previous part.
> >
> > Before this series, with Mehdi's series applied, 29 drivers read the
> > "clock-frequency" property and 18 drivers set the external clock rate.
> > With these series we go down to 1 and 3 respectively, namely the ccs,
> > mt9p031 and mt9v032 drivers. Clock handling in the CCS driver is a bit
> > more convoluted so I will leave to Sakari the honour of dropping the
> > last direct user of "clock-frequency" :-) As for the mt9p031 and mt9v032
> > driver, addressing the issue there is more difficult and likely not
> > worth it.
> >
> > [1] https://lore.kernel.org/linux-media/cover.1750942967.git.mehdi.djait@linux.intel.com
> >
> > Laurent Pinchart (72):
> > dt-bindings: media: Deprecate clock-frequency property for camera
> > sensors
> > dt-bindings: media: et8ek8: Deprecate clock-frequency property
> > dt-bindings: media: imx258: Make clocks property required
> > dt-bindings: media: imx274: Make clocks property required
> > ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor
> > node
> > ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera
> > sensor node
> > ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera
> > sensor node
> > ARM: dts: samsung: exynos4412-midas: Replace clock-frequency in camera
> > sensor node
> > ARM: dts: ti: omap3-n900: Replace clock-frequency in camera sensor
> > node
> > ARM: dts: ti: omap3-n950: Replace clock-frequency in camera sensor
> > node
> > ARM: dts: ti: omap3-n9: Replace clock-frequency in camera sensor node
> > arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace
> > clock-frequency in camera sensor node
> > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop
> > clock-frequency from camera sensor node
> > arm64: dts: renesas: rzg2l-smarc: Drop clock-frequency from camera
> > sensor node
> > media: i2c: mt9v022: Drop unused mt9v022.h header
> > media: i2c: mt9v032: Replace client->dev usage
> > media: i2c: mt9v032: Drop support for platform data
> > media: i2c: mt9v111: Do not set clock rate manually
> > media: i2c: ov6650: Drop unused driver
> > media: i2c: hi556: Replace client->dev usage
> > media: i2c: hi556: Use V4L2 sensor clock helper
> > media: i2c: hi847: Replace client->dev usage
> > media: i2c: hi847: Use V4L2 sensor clock helper
> > media: i2c: imx208: Replace client->dev usage
> > media: i2c: imx208: Use V4L2 sensor clock helper
> > media: i2c: imx319: Replace client->dev usage
> > media: i2c: imx319: Use V4L2 sensor clock helper
> > media: i2c: imx355: Replace client->dev usage
> > media: i2c: imx335: Use V4L2 sensor clock helper
> > media: i2c: og01a1b: Replace client->dev usage
> > media: i2c: og01a1b: Use V4L2 sensor clock helper
> > media: i2c: ov02c10: Replace client->dev usage
> > media: i2c: ov02c10: Use V4L2 sensor clock helper
> > media: i2c: ov02e10: Replace client->dev usage
> > media: i2c: ov02e10: Use V4L2 sensor clock helper
> > media: i2c: ov08d10: Replace client->dev usage
> > media: i2c: ov08d10: Use V4L2 sensor clock helper
> > media: i2c: ov08x40: Replace client->dev usage
> > media: i2c: ov08x40: Use V4L2 sensor clock helper
> > media: i2c: ov13858: Replace client->dev usage
> > media: i2c: ov13858: Use V4L2 sensor clock helper
> > media: i2c: ov13b10: Replace client->dev usage
> > media: i2c: ov13b10: Use V4L2 sensor clock helper
> > media: i2c: ov2740: Replace client->dev usage
> > media: i2c: ov2740: Use V4L2 sensor clock helper
> > media: i2c: ov4689: Use V4L2 sensor clock helper
> > media: i2c: ov5670: Replace client->dev usage
> > media: i2c: ov5670: Use V4L2 sensor clock helper
> > media: i2c: ov5675: Replace client->dev usage
> > media: i2c: ov5675: Use V4L2 sensor clock helper
> > media: i2c: ov5693: Use V4L2 sensor clock helper
> > media: i2c: ov7251: Use V4L2 sensor clock helper
> > media: i2c: ov9734: Replace client->dev usage
> > media: i2c: ov9734: Use V4L2 sensor clock helper
> > media: v4l2-common: Add legacy camera sensor clock helper
> > media: i2c: et8ek8: Drop support for per-mode external clock frequency
> > media: i2c: et8ek8: Use V4L2 legacy sensor clock helper
> > media: i2c: gc05a2: Use V4L2 legacy sensor clock helper
> > media: i2c: gc08a3: Use V4L2 legacy sensor clock helper
> > media: i2c: imx258: Replace client->dev usage
> > media: i2c: imx258: Use V4L2 legacy sensor clock helper
> > media: i2c: imx290: Use V4L2 legacy sensor clock helper
> > media: i2c: ov02a10: Replace client->dev usage
> > media: i2c: ov02a10: Use V4L2 legacy sensor clock helper
> > media: i2c: ov2685: Use V4L2 legacy sensor clock helper
> > media: i2c: ov5645: Use V4L2 legacy sensor clock helper
> > media: i2c: ov5695: Use V4L2 legacy sensor clock helper
> > media: i2c: ov8856: Replace client->dev usage
> > media: i2c: ov8856: Use V4L2 legacy sensor clock helper
> > media: i2c: s5c73m3: Use V4L2 legacy sensor clock helper
> > media: i2c: s5k5baf: Use V4L2 legacy sensor clock helper
> > media: i2c: s5k6a3: Use V4L2 legacy sensor clock helper
>
> If you are planning a v2 version of this patch series, please consider
> incorporating the following improvements:
>
> 1. In the imx219 driver, you can also replace direct client->dev usage.
The series doesn't touch the imx219 driver. The patches that replace
client->dev usage were meant to simplify the other changes. Additional
client->dev removal should be done on top (and likely through all camera
sensor drivers in one go).
> 2. In the regulator code, you can reduce boilerplate by using
> devm_regulator_bulk_get_enable().
devm_regulator_bulk_get_enable() doesn't seem to be a good idea. You
generally don't want to enable power everywhere unconditionally, and
sensors very often need a guaranteed power up sequence.
> Otherwise, I will submit a separate patch series on top of yours to
> address these points.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-07-10 17:46 [PATCH 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
` (14 preceding siblings ...)
2025-07-24 11:42 ` [PATCH 00/72] media: i2c: Reduce cargo-cult Tarang Raval
@ 2025-08-11 23:27 ` Bjorn Andersson
2025-08-12 8:51 ` Laurent Pinchart
15 siblings, 1 reply; 51+ messages in thread
From: Bjorn Andersson @ 2025-08-11 23:27 UTC (permalink / raw)
To: linux-media, Laurent Pinchart
Cc: Sakari Ailus, Mehdi Djait, Alim Akhtar, André Apitzsch,
Andrzej Hajda, Arec Kao, Benjamin Mugnier, Bingbu Cao,
Bryan O'Donoghue, Bryan O'Donoghue, Conor Dooley,
Daniel Scally, Dongcheng Yan, Dongchun Zhu, Fabio Estevam,
Geert Uytterhoeven, Hans de Goede, Hans Verkuil, Hao Yao,
Heimir Thor Sverrisson, Jacopo Mondi, Jason Chen, Jimmy Su,
Jingjing Xiong, Jonas Karlman, Konrad Dybcio, Krzysztof Kozlowski,
Lad Prabhakar, Leon Luo, Liam Girdwood, Magnus Damm,
Manivannan Sadhasivam, Mark Brown, Matthew Majewski,
Matthias Fend, Mikhail Rudenko, Nicolas Dufresne,
Niklas Söderlund, Pavel Machek, Pengutronix Kernel Team,
Ricardo Ribalda, Rob Herring, Sascha Hauer, Shawn Guo,
Shunqian Zheng, Sylvain Petinot, Sylwester Nawrocki, Tarang Raval,
Tianshu Qiu, Todor Tomov, Tomi Valkeinen, Tony Lindgren, Zhi Mao,
devicetree, imx, linux-arm-kernel, linux-arm-msm, linux-omap,
linux-renesas-soc, linux-samsung-soc
On Thu, 10 Jul 2025 20:46:56 +0300, Laurent Pinchart wrote:
> This patch series build on top of Mehdi's introduction of the
> devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
> cargo-cult in camera sensor drivers.
>
> A large number of camera sensor drivers directly use the
> "clock-frequency" property to retrieve the effective or desired external
> clock rate. This is standard behaviour on ACPI platforms that don't
> implement MIPI DisCo for Imaging, but usage of the property has leaked
> to OF-based platforms, due to a combination of historical reasons (using
> "clock-frequency" was initially considered right until before the
> introduction of "assigned-clock-rates") and plain cargo-cult.
>
> [...]
Applied, thanks!
[12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
commit: 5433560caa5e7e677a8d4310bbec08312be765b4
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-11 23:27 ` (subset) " Bjorn Andersson
@ 2025-08-12 8:51 ` Laurent Pinchart
2025-08-12 8:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-08-12 8:51 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-media, Sakari Ailus, Mehdi Djait, Alim Akhtar,
André Apitzsch, Andrzej Hajda, Arec Kao, Benjamin Mugnier,
Bingbu Cao, Bryan O'Donoghue, Bryan O'Donoghue,
Conor Dooley, Daniel Scally, Dongcheng Yan, Dongchun Zhu,
Fabio Estevam, Geert Uytterhoeven, Hans de Goede, Hans Verkuil,
Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi, Jason Chen,
Jimmy Su, Jingjing Xiong, Jonas Karlman, Konrad Dybcio,
Krzysztof Kozlowski, Lad Prabhakar, Leon Luo, Liam Girdwood,
Magnus Damm, Manivannan Sadhasivam, Mark Brown, Matthew Majewski,
Matthias Fend, Mikhail Rudenko, Nicolas Dufresne,
Niklas Söderlund, Pavel Machek, Pengutronix Kernel Team,
Ricardo Ribalda, Rob Herring, Sascha Hauer, Shawn Guo,
Shunqian Zheng, Sylvain Petinot, Sylwester Nawrocki, Tarang Raval,
Tianshu Qiu, Todor Tomov, Tomi Valkeinen, Tony Lindgren, Zhi Mao,
devicetree, imx, linux-arm-kernel, linux-arm-msm, linux-omap,
linux-renesas-soc, linux-samsung-soc
Hi Bjorn,
On Mon, Aug 11, 2025 at 06:27:01PM -0500, Bjorn Andersson wrote:
> On Thu, 10 Jul 2025 20:46:56 +0300, Laurent Pinchart wrote:
> > This patch series build on top of Mehdi's introduction of the
> > devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
> > cargo-cult in camera sensor drivers.
> >
> > A large number of camera sensor drivers directly use the
> > "clock-frequency" property to retrieve the effective or desired external
> > clock rate. This is standard behaviour on ACPI platforms that don't
> > implement MIPI DisCo for Imaging, but usage of the property has leaked
> > to OF-based platforms, due to a combination of historical reasons (using
> > "clock-frequency" was initially considered right until before the
> > introduction of "assigned-clock-rates") and plain cargo-cult.
> >
> > [...]
>
> Applied, thanks!
>
> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
I'm afraid that's too soon. This will introduce a breakage without a
corresponding change to the camera sensor driver.
I will post a v2 with the patches reordered. We could merge the V4L2
side in a rc1-based stable branch and merge than in the arm-soc tree as
well, but I think we can also delay the .dts changes to the next kernel
version. Do you have a preference ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-12 8:51 ` Laurent Pinchart
@ 2025-08-12 8:58 ` Krzysztof Kozlowski
2025-08-12 9:39 ` Laurent Pinchart
0 siblings, 1 reply; 51+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-12 8:58 UTC (permalink / raw)
To: Laurent Pinchart, Bjorn Andersson
Cc: linux-media, Sakari Ailus, Mehdi Djait, Alim Akhtar,
André Apitzsch, Andrzej Hajda, Arec Kao, Benjamin Mugnier,
Bingbu Cao, Bryan O'Donoghue, Bryan O'Donoghue,
Conor Dooley, Daniel Scally, Dongcheng Yan, Dongchun Zhu,
Fabio Estevam, Geert Uytterhoeven, Hans de Goede, Hans Verkuil,
Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi, Jason Chen,
Jimmy Su, Jingjing Xiong, Jonas Karlman, Konrad Dybcio,
Krzysztof Kozlowski, Lad Prabhakar, Leon Luo, Liam Girdwood,
Magnus Damm, Manivannan Sadhasivam, Mark Brown, Matthew Majewski,
Matthias Fend, Mikhail Rudenko, Nicolas Dufresne,
Niklas Söderlund, Pavel Machek, Pengutronix Kernel Team,
Ricardo Ribalda, Rob Herring, Sascha Hauer, Shawn Guo,
Shunqian Zheng, Sylvain Petinot, Sylwester Nawrocki, Tarang Raval,
Tianshu Qiu, Todor Tomov, Tomi Valkeinen, Tony Lindgren, Zhi Mao,
devicetree, imx, linux-arm-kernel, linux-arm-msm, linux-omap,
linux-renesas-soc, linux-samsung-soc
On 12/08/2025 10:51, Laurent Pinchart wrote:
> Hi Bjorn,
>
> On Mon, Aug 11, 2025 at 06:27:01PM -0500, Bjorn Andersson wrote:
>> On Thu, 10 Jul 2025 20:46:56 +0300, Laurent Pinchart wrote:
>>> This patch series build on top of Mehdi's introduction of the
>>> devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
>>> cargo-cult in camera sensor drivers.
>>>
>>> A large number of camera sensor drivers directly use the
>>> "clock-frequency" property to retrieve the effective or desired external
>>> clock rate. This is standard behaviour on ACPI platforms that don't
>>> implement MIPI DisCo for Imaging, but usage of the property has leaked
>>> to OF-based platforms, due to a combination of historical reasons (using
>>> "clock-frequency" was initially considered right until before the
>>> introduction of "assigned-clock-rates") and plain cargo-cult.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
>> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
>
> I'm afraid that's too soon. This will introduce a breakage without a
> corresponding change to the camera sensor driver.
>
> I will post a v2 with the patches reordered. We could merge the V4L2
> side in a rc1-based stable branch and merge than in the arm-soc tree as
You cannot ("cannot" as not following the process) merge drivers into
DTS branch.
> well, but I think we can also delay the .dts changes to the next kernel
All users of DTS will be anyway affected and commit msg should address that.
> version. Do you have a preference ?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-12 8:58 ` Krzysztof Kozlowski
@ 2025-08-12 9:39 ` Laurent Pinchart
2025-08-12 10:28 ` Krzysztof Kozlowski
0 siblings, 1 reply; 51+ messages in thread
From: Laurent Pinchart @ 2025-08-12 9:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-media, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bryan O'Donoghue,
Bryan O'Donoghue, Conor Dooley, Daniel Scally, Dongcheng Yan,
Dongchun Zhu, Fabio Estevam, Geert Uytterhoeven, Hans de Goede,
Hans Verkuil, Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi,
Jason Chen, Jimmy Su, Jingjing Xiong, Jonas Karlman,
Konrad Dybcio, Krzysztof Kozlowski, Lad Prabhakar, Leon Luo,
Liam Girdwood, Magnus Damm, Manivannan Sadhasivam, Mark Brown,
Matthew Majewski, Matthias Fend, Mikhail Rudenko,
Nicolas Dufresne, Niklas Söderlund, Pavel Machek,
Pengutronix Kernel Team, Ricardo Ribalda, Rob Herring,
Sascha Hauer, Shawn Guo, Shunqian Zheng, Sylvain Petinot,
Sylwester Nawrocki, Tarang Raval, Tianshu Qiu, Todor Tomov,
Tomi Valkeinen, Tony Lindgren, Zhi Mao, devicetree, imx,
linux-arm-kernel, linux-arm-msm, linux-omap, linux-renesas-soc,
linux-samsung-soc
On Tue, Aug 12, 2025 at 10:58:30AM +0200, Krzysztof Kozlowski wrote:
> On 12/08/2025 10:51, Laurent Pinchart wrote:
> > On Mon, Aug 11, 2025 at 06:27:01PM -0500, Bjorn Andersson wrote:
> >> On Thu, 10 Jul 2025 20:46:56 +0300, Laurent Pinchart wrote:
> >>> This patch series build on top of Mehdi's introduction of the
> >>> devm_v4l2_sensor_clk_get() helper (see [1]) to drastically reduce
> >>> cargo-cult in camera sensor drivers.
> >>>
> >>> A large number of camera sensor drivers directly use the
> >>> "clock-frequency" property to retrieve the effective or desired external
> >>> clock rate. This is standard behaviour on ACPI platforms that don't
> >>> implement MIPI DisCo for Imaging, but usage of the property has leaked
> >>> to OF-based platforms, due to a combination of historical reasons (using
> >>> "clock-frequency" was initially considered right until before the
> >>> introduction of "assigned-clock-rates") and plain cargo-cult.
> >>>
> >>> [...]
> >>
> >> Applied, thanks!
> >>
> >> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
> >> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
> >
> > I'm afraid that's too soon. This will introduce a breakage without a
> > corresponding change to the camera sensor driver.
> >
> > I will post a v2 with the patches reordered. We could merge the V4L2
> > side in a rc1-based stable branch and merge than in the arm-soc tree as
>
> You cannot ("cannot" as not following the process) merge drivers into
> DTS branch.
Ah, I wasn't aware of that. DTS trees don't allow merging stable
branches shared with other subsystems ? Does it mean that a DTS change
that depends on a driver change always need to be delayed by one kernel
version ?
> > well, but I think we can also delay the .dts changes to the next kernel
>
> All users of DTS will be anyway affected and commit msg should address that.
Which commit message, the one for the driver changes or the one for the
DTS changes ? I plan in the next version to indicate that the DT changes
depend on the driver changes.
> > version. Do you have a preference ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-12 9:39 ` Laurent Pinchart
@ 2025-08-12 10:28 ` Krzysztof Kozlowski
2025-08-12 10:34 ` Laurent Pinchart
2025-08-12 20:10 ` Laurent Pinchart
0 siblings, 2 replies; 51+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-12 10:28 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Bjorn Andersson, linux-media, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bryan O'Donoghue,
Bryan O'Donoghue, Conor Dooley, Daniel Scally, Dongcheng Yan,
Dongchun Zhu, Fabio Estevam, Geert Uytterhoeven, Hans de Goede,
Hans Verkuil, Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi,
Jason Chen, Jimmy Su, Jingjing Xiong, Jonas Karlman,
Konrad Dybcio, Krzysztof Kozlowski, Lad Prabhakar, Leon Luo,
Liam Girdwood, Magnus Damm, Manivannan Sadhasivam, Mark Brown,
Matthew Majewski, Matthias Fend, Mikhail Rudenko,
Nicolas Dufresne, Niklas Söderlund, Pavel Machek,
Pengutronix Kernel Team, Ricardo Ribalda, Rob Herring,
Sascha Hauer, Shawn Guo, Shunqian Zheng, Sylvain Petinot,
Sylwester Nawrocki, Tarang Raval, Tianshu Qiu, Todor Tomov,
Tomi Valkeinen, Tony Lindgren, Zhi Mao, devicetree, imx,
linux-arm-kernel, linux-arm-msm, linux-omap, linux-renesas-soc,
linux-samsung-soc
On 12/08/2025 11:39, Laurent Pinchart wrote:
>>>>
>>>> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
>>>> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
>>>
>>> I'm afraid that's too soon. This will introduce a breakage without a
>>> corresponding change to the camera sensor driver.
>>>
>>> I will post a v2 with the patches reordered. We could merge the V4L2
>>> side in a rc1-based stable branch and merge than in the arm-soc tree as
>>
>> You cannot ("cannot" as not following the process) merge drivers into
>> DTS branch.
>
> Ah, I wasn't aware of that. DTS trees don't allow merging stable
> branches shared with other subsystems ? Does it mean that a DTS change
Not with driver subsystems. Why? Because it breaks encapsulation of
hardware description being entirely independent of given Linux driver
implementation.
BTW, it is already documented in maintainer-soc in ABI stability (I will
fix "devicetree" ambiguity to DTS) and driver branch dependencies.
> that depends on a driver change always need to be delayed by one kernel
> version ?
This is one solution, although as I mentioned later it still affects all
other users of DTS, so it has its own drawbacks.
Other solution is to keep both properties for more than one cycle.
>
>>> well, but I think we can also delay the .dts changes to the next kernel
>>
>> All users of DTS will be anyway affected and commit msg should address that.
>
> Which commit message, the one for the driver changes or the one for the
> DTS changes ? I plan in the next version to indicate that the DT changes
> depend on the driver changes.
DTS changes, so the soc maintainers can judge whether they care about
other DTS users or they do not.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-12 10:28 ` Krzysztof Kozlowski
@ 2025-08-12 10:34 ` Laurent Pinchart
2025-08-12 20:10 ` Laurent Pinchart
1 sibling, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-08-12 10:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-media, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bryan O'Donoghue,
Bryan O'Donoghue, Conor Dooley, Daniel Scally, Dongcheng Yan,
Dongchun Zhu, Fabio Estevam, Geert Uytterhoeven, Hans de Goede,
Hans Verkuil, Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi,
Jason Chen, Jimmy Su, Jingjing Xiong, Jonas Karlman,
Konrad Dybcio, Krzysztof Kozlowski, Lad Prabhakar, Leon Luo,
Liam Girdwood, Magnus Damm, Manivannan Sadhasivam, Mark Brown,
Matthew Majewski, Matthias Fend, Mikhail Rudenko,
Nicolas Dufresne, Niklas Söderlund, Pavel Machek,
Pengutronix Kernel Team, Ricardo Ribalda, Rob Herring,
Sascha Hauer, Shawn Guo, Shunqian Zheng, Sylvain Petinot,
Sylwester Nawrocki, Tarang Raval, Tianshu Qiu, Todor Tomov,
Tomi Valkeinen, Tony Lindgren, Zhi Mao, devicetree, imx,
linux-arm-kernel, linux-arm-msm, linux-omap, linux-renesas-soc,
linux-samsung-soc
On Tue, Aug 12, 2025 at 12:28:28PM +0200, Krzysztof Kozlowski wrote:
> On 12/08/2025 11:39, Laurent Pinchart wrote:
> >>>>
> >>>> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
> >>>> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
> >>>
> >>> I'm afraid that's too soon. This will introduce a breakage without a
> >>> corresponding change to the camera sensor driver.
> >>>
> >>> I will post a v2 with the patches reordered. We could merge the V4L2
> >>> side in a rc1-based stable branch and merge than in the arm-soc tree as
> >>
> >> You cannot ("cannot" as not following the process) merge drivers into
> >> DTS branch.
> >
> > Ah, I wasn't aware of that. DTS trees don't allow merging stable
> > branches shared with other subsystems ? Does it mean that a DTS change
>
> Not with driver subsystems. Why? Because it breaks encapsulation of
> hardware description being entirely independent of given Linux driver
> implementation.
>
> BTW, it is already documented in maintainer-soc in ABI stability (I will
> fix "devicetree" ambiguity to DTS) and driver branch dependencies.
>
> > that depends on a driver change always need to be delayed by one kernel
> > version ?
>
> This is one solution, although as I mentioned later it still affects all
> other users of DTS, so it has its own drawbacks.
>
> Other solution is to keep both properties for more than one cycle.
OK.
There's no urgency to merge the .dts changes, so I think delaying them
by one kernel release is the simplest option.
> >>> well, but I think we can also delay the .dts changes to the next kernel
> >>
> >> All users of DTS will be anyway affected and commit msg should address that.
> >
> > Which commit message, the one for the driver changes or the one for the
> > DTS changes ? I plan in the next version to indicate that the DT changes
> > depend on the driver changes.
>
> DTS changes, so the soc maintainers can judge whether they care about
> other DTS users or they do not.
Thank you for the clarification. I will do that.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread* Re: (subset) [PATCH 00/72] media: i2c: Reduce cargo-cult
2025-08-12 10:28 ` Krzysztof Kozlowski
2025-08-12 10:34 ` Laurent Pinchart
@ 2025-08-12 20:10 ` Laurent Pinchart
1 sibling, 0 replies; 51+ messages in thread
From: Laurent Pinchart @ 2025-08-12 20:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-media, Sakari Ailus, Mehdi Djait,
Alim Akhtar, André Apitzsch, Andrzej Hajda, Arec Kao,
Benjamin Mugnier, Bingbu Cao, Bryan O'Donoghue,
Bryan O'Donoghue, Conor Dooley, Daniel Scally, Dongcheng Yan,
Dongchun Zhu, Fabio Estevam, Geert Uytterhoeven, Hans de Goede,
Hans Verkuil, Hao Yao, Heimir Thor Sverrisson, Jacopo Mondi,
Jason Chen, Jimmy Su, Jingjing Xiong, Jonas Karlman,
Konrad Dybcio, Krzysztof Kozlowski, Lad Prabhakar, Leon Luo,
Liam Girdwood, Magnus Damm, Manivannan Sadhasivam, Mark Brown,
Matthew Majewski, Matthias Fend, Mikhail Rudenko,
Nicolas Dufresne, Niklas Söderlund, Pavel Machek,
Pengutronix Kernel Team, Ricardo Ribalda, Rob Herring,
Sascha Hauer, Shawn Guo, Shunqian Zheng, Sylvain Petinot,
Sylwester Nawrocki, Tarang Raval, Tianshu Qiu, Todor Tomov,
Tomi Valkeinen, Tony Lindgren, Zhi Mao, devicetree, imx,
linux-arm-kernel, linux-arm-msm, linux-omap, linux-renesas-soc,
linux-samsung-soc
On Tue, Aug 12, 2025 at 12:28:28PM +0200, Krzysztof Kozlowski wrote:
> On 12/08/2025 11:39, Laurent Pinchart wrote:
> >>>>
> >>>> [12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node
> >>>> commit: 5433560caa5e7e677a8d4310bbec08312be765b4
> >>>
> >>> I'm afraid that's too soon. This will introduce a breakage without a
> >>> corresponding change to the camera sensor driver.
> >>>
> >>> I will post a v2 with the patches reordered. We could merge the V4L2
> >>> side in a rc1-based stable branch and merge than in the arm-soc tree as
> >>
> >> You cannot ("cannot" as not following the process) merge drivers into
> >> DTS branch.
> >
> > Ah, I wasn't aware of that. DTS trees don't allow merging stable
> > branches shared with other subsystems ? Does it mean that a DTS change
>
> Not with driver subsystems. Why? Because it breaks encapsulation of
> hardware description being entirely independent of given Linux driver
> implementation.
>
> BTW, it is already documented in maintainer-soc in ABI stability (I will
> fix "devicetree" ambiguity to DTS) and driver branch dependencies.
I've just read that document, and didn't interpret it as stricly
forbidding merging a driver branch in the arm-soc tree. The rule makes
sense though, as it makes it easier to ensure that backward
compatibility isn't broken by accident. The downside is that it can slow
down merging patches in some cases.
> > that depends on a driver change always need to be delayed by one kernel
> > version ?
>
> This is one solution, although as I mentioned later it still affects all
> other users of DTS, so it has its own drawbacks.
>
> Other solution is to keep both properties for more than one cycle.
>
> >>> well, but I think we can also delay the .dts changes to the next kernel
> >>
> >> All users of DTS will be anyway affected and commit msg should address that.
> >
> > Which commit message, the one for the driver changes or the one for the
> > DTS changes ? I plan in the next version to indicate that the DT changes
> > depend on the driver changes.
>
> DTS changes, so the soc maintainers can judge whether they care about
> other DTS users or they do not.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 51+ messages in thread