Re: [PATCH v2 9/9] arm64: dts: ls1046a-qds: describe the two on-board SFP+ cages

[Frank Li <Frank.li@nxp.com>]

On Mon, Sep 15, 2025 at 03:23:54PM +0300, Ioana Ciornei wrote:
> Describe the two SFP+ cages present on the LS1046AQDS board and their
> associated I2C buses and GPIO lines.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - none
>
>  .../boot/dts/freescale/fsl-ls1046a-qds.dts    | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index 64133e63da96..c188977a901e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -42,6 +42,21 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	sfp1: sfp-1 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp1_i2c>;
> +		maximum-power-milliwatt = <2000>;
> +		mod-def0-gpios = <&stat_pres2 6 GPIO_ACTIVE_LOW>;
> +	};
> +
> +	sfp2: sfp-2 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp2_i2c>;
> +		maximum-power-milliwatt = <2000>;
> +		mod-def0-gpios = <&stat_pres2 7 GPIO_ACTIVE_LOW>;
> +	};
> +
>  };
>
>  &dspi {
> @@ -139,6 +154,31 @@ temp-sensor@4c {
>  				reg = <0x4c>;
>  			};
>  		};
> +
> +		i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x7>;

reg should be before #address-cells

Frank
> +
> +			i2c-mux@76 {
> +				compatible = "nxp,pca9547";
> +				reg = <0x76>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				sfp1_i2c: i2c@6 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					reg = <0x6>;
> +				};
> +
> +				sfp2_i2c: i2c@7 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					reg = <0x7>;
> +				};
> +			};
> +		};
>  	};
>  };
>
> --
> 2.25.1
>