[RFC PATCH 0/4] ARM: dts: renesas: mtd-rom has no clock and power domain

[RFC PATCH 0/4] ARM: dts: renesas: mtd-rom has no clock and power domain

[Wolfram Sang]

Addressing this dtb_check...

arch/arm/boot/dts/renesas/r7s72100-genmai.dtb: flash@18000000 (mtd-rom): Unevaluated properties are not allowed ('clocks', 'power-domains' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/mtd-physmap.yaml#

... I came to the solution proposed here that the clocks we cannot
define will be marked as critical. We could also try to add 'clocks' and
'power-domains' to MTD physmap but I could understand some objection to
that. Opinions?


Wolfram Sang (4):
  clk: renesas: mstp: mark 'spibsc' clocks as critical
  ARM: dts: renesas: genmai: mtd-rom has no clock and power domain
  ARM: dts: renesas: gr-peach: mtd-rom has no clock and power domain
  ARM: dts: renesas: rskrza1: mtd-rom has no clock and power domain

 arch/arm/boot/dts/renesas/r7s72100-genmai.dts   | 3 ---
 arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts | 3 ---
 arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts  | 2 --
 drivers/clk/renesas/clk-mstp.c                  | 7 +++++--
 4 files changed, 5 insertions(+), 10 deletions(-)

-- 
2.47.2

[RFC PATCH 2/4] ARM: dts: renesas: genmai: mtd-rom has no clock and power domain

[Wolfram Sang]

Clocks are now marked as critical to avoid regressions with XIP based
systems.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
index 3c3756509714..835a918a0924 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
@@ -31,9 +31,6 @@ flash@18000000 {
 		bank-width = <4>;
 		device-width = <1>;
 
-		clocks = <&mstp9_clks R7S72100_CLK_SPIBSC0>;
-		power-domains = <&cpg_clocks>;
-
 		#address-cells = <1>;
 		#size-cells = <1>;
 
-- 
2.47.2

[RFC PATCH 3/4] ARM: dts: renesas: gr-peach: mtd-rom has no clock and power domain

[Wolfram Sang]

Clocks are now marked as critical to avoid regressions with XIP based
systems.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts b/arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts
index 23ddec217685..3b2667be9056 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-gr-peach.dts
@@ -35,9 +35,6 @@ flash@18000000 {
 		bank-width = <4>;
 		device-width = <1>;
 
-		clocks = <&mstp9_clks R7S72100_CLK_SPIBSC0>;
-		power-domains = <&cpg_clocks>;
-
 		#address-cells = <1>;
 		#size-cells = <1>;
 
-- 
2.47.2

[RFC PATCH 4/4] ARM: dts: renesas: rskrza1: mtd-rom has no clock and power domain

[Wolfram Sang]

Clocks are now marked as critical to avoid regressions with XIP based
systems.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
index 91178fb9e721..4e206ebaae9b 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
@@ -32,8 +32,6 @@ memory@8000000 {
 	flash@18000000 {
 		compatible = "mtd-rom";
 		reg = <0x18000000 0x08000000>;
-		clocks = <&mstp9_clks R7S72100_CLK_SPIBSC0>;
-		power-domains = <&cpg_clocks>;
 		bank-width = <4>;
 		device-width = <1>;
 		#address-cells = <1>;
-- 
2.47.2

Re: [RFC PATCH 0/4] ARM: dts: renesas: mtd-rom has no clock and power domain

[Geert Uytterhoeven]

Hi Wolfram,

On Tue, 30 Sept 2025 at 12:17, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Addressing this dtb_check...
>
> arch/arm/boot/dts/renesas/r7s72100-genmai.dtb: flash@18000000 (mtd-rom): Unevaluated properties are not allowed ('clocks', 'power-domains' were unexpected)
>         from schema $id: http://devicetree.org/schemas/mtd/mtd-physmap.yaml#
>
> ... I came to the solution proposed here that the clocks we cannot
> define will be marked as critical. We could also try to add 'clocks' and
> 'power-domains' to MTD physmap but I could understand some objection to
> that. Opinions?

I would rather add clocks and power-domains to the DT bindings, for
two reasons:
  1. It describes the hardware better,
  2. It avoids keeping the clock running on systems where the FLASH
     is not used.

Does mtd-rom go through drivers/mtd/maps/physmap-core.c?
Then the clock domain is handled through Runtime PM since commit
0bc448b49e8a017e ("mtd: maps: physmap: Add minimal Runtime PM support").

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC PATCH 0/4] ARM: dts: renesas: mtd-rom has no clock and power domain

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi Geert,

> Does mtd-rom go through drivers/mtd/maps/physmap-core.c?
> Then the clock domain is handled through Runtime PM since commit
> 0bc448b49e8a017e ("mtd: maps: physmap: Add minimal Runtime PM support").

Thank you, Geert, for the pointers. I will have a try.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]