Devicetree
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Hans de Goede" <hansg@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Dongcheng Yan" <dongcheng.yan@intel.com>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
	"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
	"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
	"Jingjing Xiong" <jingjing.xiong@intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] media: i2c: add Sony IMX111 CMOS camera sensor driver
Date: Tue, 28 Oct 2025 18:31:08 +0200	[thread overview]
Message-ID: <aQDvzKMXhVlR2G3J@kekkonen.localdomain> (raw)
In-Reply-To: <aQDuOSUYbuoLoFbf@kekkonen.localdomain>

On Tue, Oct 28, 2025 at 06:24:25PM +0200, Sakari Ailus wrote:
> Hi Svyatoslav,
> 
> On Fri, Aug 29, 2025 at 09:20:10PM +0300, Svyatoslav Ryhel wrote:
> > чт, 28 серп. 2025 р. о 19:12 Sakari Ailus <sakari.ailus@linux.intel.com> пише:
> > >
> > > Hi Svyatoslaw,
> > >
> > > On Tue, Aug 19, 2025 at 03:04:25PM +0300, Svyatoslav Ryhel wrote:
> > > > Add driver for Sony IMX111 CMOS sensor found in LG Optimus 4X and Vu
> > > > smartphones.
> > >
> > > Thanks for the set.
> > >
> > > I wonder how would the sensor work with the CCS driver. The register layout
> > > appears to be very much aligned with that (I haven't checked whether there
> > > are MSRs that depend on the mode).
> > >
> > 
> > After deeper testing I have found that imx111 may be nokia,smia
> > compatible, at least most of general registers and CCS logic is
> > applicable. Some of registers may cause issues, for example,
> > "phy_ctrl_capability" = 0, 0x0 and some insane pll ranges. Maybe that
> > can be addressed with a firmware patch idk. The trickiest part is that
> > each mode requires non-standard and non-common manufacturer code
> > (0x3xxx ranges). If you can explain how to address these issues, I
> > would love to add imx111 and a few other modules into list of CCS
> > supported devices.
> 
> On a closer look, only the image size related configuration and a little
> more appears to be CCS-like. That's not enough to configure the sensor;
> this is conveyed in the MSR space which indeed makes the sensor difficult
> to control using the CCS driver, unfortunately.

Ok, the driver appears to be doing quite a bit of register writes outside
the register lists, which is good, and what's there appears indeed largely
CCS compliant. The MSRs remain an issue; it'd take quite a bit of reverse
engineering to figure out what the registers are and how to configure them
in a generic way. I think that's doable but I'm not sure it is justifiable
considering the expected effort.

-- 
Sakari Ailus

  reply	other threads:[~2025-10-28 16:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 12:04 [PATCH v1 0/2] media: i2c: add Sony IMX111 CMOS camera sensor driver Svyatoslav Ryhel
2025-08-19 12:04 ` [PATCH v1 1/2] dt-bindings: media: i2c: document Sony IMX111 CMOS sensor Svyatoslav Ryhel
2025-08-19 20:25   ` Rob Herring
2025-08-20  5:36     ` Svyatoslav Ryhel
2025-08-19 12:04 ` [PATCH v1 2/2] media: i2c: add Sony IMX111 CMOS camera sensor driver Svyatoslav Ryhel
2025-08-21 14:45   ` kernel test robot
2025-08-28 16:12 ` [PATCH v1 0/2] " Sakari Ailus
2025-08-28 17:00   ` Svyatoslav Ryhel
2025-08-29 18:20   ` Svyatoslav Ryhel
2025-10-28 16:24     ` Sakari Ailus
2025-10-28 16:31       ` Sakari Ailus [this message]
2025-10-28 16:34         ` Svyatoslav Ryhel
2025-10-28 16:38           ` Sakari Ailus
2025-10-28 16:55             ` Svyatoslav Ryhel
2025-10-28 16:59               ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQDvzKMXhVlR2G3J@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dongcheng.yan@intel.com \
    --cc=git@apitzsch.eu \
    --cc=hansg@kernel.org \
    --cc=heimir.sverrisson@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jingjing.xiong@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox