Re: [PATCH 2/3] media: dt-bindings: Add OmniVision OV13B10

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Antoine,

On Fri, Mar 20, 2026 at 09:27:18AM +0000, Antoine Bernard wrote:
> From: Antoine Bernard <zalnir@proton.me>
> 
> Document the device tree bindings for OmniVision OV13B10 image
> sensor.
> 
> Signed-off-by: Antoine Bernard <zalnir@proton.me>
> ---
>  .../bindings/media/i2c/ovti,ov13b10.yaml      | 99 +++++++++++++++++++
>  1 file changed, 99 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> new file mode 100644
> index 000000000000..4d6432488b79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov13b10.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Omnivision ov13b10 image sensor
> +
> +maintainers:
> +  - Arec Kao <arec.kao@intel.com>
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: ovti,ov13b10
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: System clock.

Typically this is called "external clock" or something like that.

> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO connected to the XSHUTDOWN pin. Active low.
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: Analog circuit voltage supply.
> +
> +  dvdd-supply:
> +    description: Digital circuit voltage supply.
> +
> +  dovdd-supply:
> +    description: Digital I/O circuit voltage supply.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        additionalProperties: false
> +
> +        properties:
> +          data-lanes:
> +            minItems: 1
> +            maxItems: 4
> +            items:
> +              enum: [1, 2, 3, 4]
> +
> +          link-frequencies: true
> +          remote-endpoint: true

These two you can drop I believe.

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +          - remote-endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ov13b10: camera@36 {
> +            compatible = "ovti,ov13b10";
> +            reg = <0x36>;
> +
> +            clocks = <&sensor_xclk>;
> +            reset-gpios = <&gpio 117 GPIO_ACTIVE_LOW>;
> +
> +            avdd-supply = <&ov13b10_avdd>;
> +            dvdd-supply = <&ov13b10_dvdd>;
> +            dovdd-supply = <&ov13b10_dovdd>;
> +
> +            port {
> +                ov13b10_ep: endpoint {
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <560000000>;
> +                    remote-endpoint = <&csiphy_ep>;
> +                };
> +            };
> +        };
> +    };
> +...

-- 
Kind regrads,

Sakari Ailus