Re: [PATCH 2/3] media: dt-bindings: Add OmniVision OV13B10

Re: [PATCH 2/3] media: dt-bindings: Add OmniVision OV13B10

[Sakari Ailus]

Hi Antoine,

On Fri, Mar 20, 2026 at 09:27:18AM +0000, Antoine Bernard wrote:
> From: Antoine Bernard <zalnir@proton.me>
> 
> Document the device tree bindings for OmniVision OV13B10 image
> sensor.
> 
> Signed-off-by: Antoine Bernard <zalnir@proton.me>
> ---
>  .../bindings/media/i2c/ovti,ov13b10.yaml      | 99 +++++++++++++++++++
>  1 file changed, 99 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> new file mode 100644
> index 000000000000..4d6432488b79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov13b10.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Omnivision ov13b10 image sensor
> +
> +maintainers:
> +  - Arec Kao <arec.kao@intel.com>
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: ovti,ov13b10
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: System clock.

Typically this is called "external clock" or something like that.

> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO connected to the XSHUTDOWN pin. Active low.
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: Analog circuit voltage supply.
> +
> +  dvdd-supply:
> +    description: Digital circuit voltage supply.
> +
> +  dovdd-supply:
> +    description: Digital I/O circuit voltage supply.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        additionalProperties: false
> +
> +        properties:
> +          data-lanes:
> +            minItems: 1
> +            maxItems: 4
> +            items:
> +              enum: [1, 2, 3, 4]
> +
> +          link-frequencies: true
> +          remote-endpoint: true

These two you can drop I believe.

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +          - remote-endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ov13b10: camera@36 {
> +            compatible = "ovti,ov13b10";
> +            reg = <0x36>;
> +
> +            clocks = <&sensor_xclk>;
> +            reset-gpios = <&gpio 117 GPIO_ACTIVE_LOW>;
> +
> +            avdd-supply = <&ov13b10_avdd>;
> +            dvdd-supply = <&ov13b10_dvdd>;
> +            dovdd-supply = <&ov13b10_dovdd>;
> +
> +            port {
> +                ov13b10_ep: endpoint {
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <560000000>;
> +                    remote-endpoint = <&csiphy_ep>;
> +                };
> +            };
> +        };
> +    };
> +...

-- 
Kind regrads,

Sakari Ailus

[PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Antoine Bernard]

Document the device tree bindings for OmniVision OV13B10 image
sensor.

Signed-off-by: Antoine Bernard <zalnir@proton.me>

---
v2:
- Rename to "external clock".
- Drop link-frequencies and remote-endpoint.
- Set maintainer as myself.
---
 .../bindings/media/i2c/ovti,ov13b10.yaml      | 94 +++++++++++++++++++
 1 file changed, 94 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
new file mode 100644
index 000000000000..b96b3683bc71
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov13b10.yaml
@@ -0,0 +1,94 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ovti,ov13b10.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Omnivision ov13b10 image sensor
+
+maintainers:
+  - Antoine Bernard <zalnir@proton.me>
+
+allOf:
+  - $ref: /schemas/media/video-interface-devices.yaml#
+
+properties:
+  compatible:
+    const: ovti,ov13b10
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description: External clock.
+    maxItems: 1
+
+  reset-gpios:
+    description: GPIO connected to the XSHUTDOWN pin. Active low.
+    maxItems: 1
+
+  avdd-supply:
+    description: Analog circuit voltage supply.
+
+  dvdd-supply:
+    description: Digital circuit voltage supply.
+
+  dovdd-supply:
+    description: Digital I/O circuit voltage supply.
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        additionalProperties: false
+
+        properties:
+          data-lanes:
+            minItems: 1
+            maxItems: 4
+            items:
+              enum: [1, 2, 3, 4]
+
+        required:
+          - data-lanes
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ov13b10: camera@36 {
+            compatible = "ovti,ov13b10";
+            reg = <0x36>;
+
+            clocks = <&sensor_xclk>;
+            reset-gpios = <&gpio 117 GPIO_ACTIVE_LOW>;
+
+            avdd-supply = <&ov13b10_avdd>;
+            dvdd-supply = <&ov13b10_dvdd>;
+            dovdd-supply = <&ov13b10_dovdd>;
+
+            port {
+                ov13b10_ep: endpoint {
+                    data-lanes = <1 2 3 4>;
+                    link-frequencies = /bits/ 64 <560000000>;
+                    remote-endpoint = <&csiphy_ep>;
+                };
+            };
+        };
+    };
+...
-- 
2.52.0

Re: [PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Krzysztof Kozlowski]

On Sat, Mar 21, 2026 at 04:36:09AM +0000, Antoine Bernard wrote:
> Document the device tree bindings for OmniVision OV13B10 image
> sensor.
> 
> Signed-off-by: Antoine Bernard <zalnir@proton.me>
> 
> ---

There is no 1/3 and 3/3 in this posting. There is v1 though...

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830


> v2:
> - Rename to "external clock".
> - Drop link-frequencies and remote-endpoint.
> - Set maintainer as myself.
> ---
>  .../bindings/media/i2c/ovti,ov13b10.yaml      | 94 +++++++++++++++++++

Looks exactly as ovti,ov08x40, no? Why another file is needed?

Best regards,
Krzysztof

Re: [PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Antoine Bernard]

> Do not attach (thread) your patchsets to some other threads
> (unrelated or older versions).

Sorry about that, I'll resend all patches in the series from now on.

> Looks exactly as ovti,ov08x40, no? Why another file is needed?

I kind of agree, ovti,ov08x40 looks the same. In fact, ovti,ov* documentations all look similar. I made it because after adding the dt of_match in the sensor driver, the validation script warned me that the related documentation is missing. If it is possible to have one documentation for different sensors, then I don't think this is needed.

Re: [PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Krzysztof Kozlowski]

On 21/03/2026 12:52, Antoine Bernard wrote:
>> Do not attach (thread) your patchsets to some other threads
>> (unrelated or older versions).
> 
> Sorry about that, I'll resend all patches in the series from now on.
> 
>> Looks exactly as ovti,ov08x40, no? Why another file is needed?
> 
> I kind of agree, ovti,ov08x40 looks the same. In fact, ovti,ov* documentations all look similar. I made it because after adding the dt of_match in the sensor driver, the validation script warned me that the related documentation is missing. If it is possible to have one documentation for different sensors, then I don't think this is needed.

Please wrap your emails.

If the hardware has the same properties, just document it in existing file.

Best regards,
Krzysztof

Re: [PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Antoine Bernard]

> Please wrap your emails.

Sorry, I noticed that after sending.

> If the hardware has the same properties

As of my understanding they are different hardware, can I really use
the documentation for another hardware?

Re: [PATCH v2 2/3] media: dt-bindings: Add OmniVision OV13B10

[Krzysztof Kozlowski]

On 21/03/2026 13:02, Antoine Bernard wrote:
>> Please wrap your emails.
> 
> Sorry, I noticed that after sending.
> 
>> If the hardware has the same properties
> 
> As of my understanding they are different hardware, can I really use
> the documentation for another hardware?

I asked to document it.

Best regards,
Krzysztof

Re: [PATCH 2/3] media: dt-bindings: Add OmniVision OV13B10

[Sakari Ailus]

One more thing...

On Fri, Mar 20, 2026 at 09:27:18AM +0000, Antoine Bernard wrote:
> +maintainers:
> +  - Arec Kao <arec.kao@intel.com>

I think you should put your own name here unless you have agreed
something else with Arec.

-- 
Sakari Ailus