Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sirat <email@sirat.me>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor
Date: Thu, 12 Mar 2026 17:23:55 +0200	[thread overview]
Message-ID: <abLaiwjU2NjFiIR3@ashevche-desk.local> (raw)
In-Reply-To: <CANn+LW+F2bVMAGwoF8q9yBpF3x5r_hWDqvE3_JYjcLd16A_cEA@mail.gmail.com>

On Thu, Mar 12, 2026 at 09:12:30PM +0600, Sirat wrote:
> On Thu, Mar 12, 2026 at 8:28 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Mar 12, 2026 at 04:40:35AM +0600, Siratul Islam wrote:

...

> > > ---
> > > Changes in v3:
> > > - Merge DT binding into existing st,vl53l0x.yaml (per Krzysztof).
> > > - Use "reset-gpios" in the binding but xshut_gpio in the driver since that's the actual pin name.
> >
> > But why is it "reset" in the bindings? If it's a power rail or enable pin, why
> > not call it as a such in the bindings? The connection on PCB level is different story.
> >
> In v2, I actually used a separate st,vl53l1x.yaml binding with
> `xshut-gpios` and a required `vdd-supply`.
> But Krzysztof pointed out that they share the same pins so the
> existing st,vl53l0x.yaml should suffice,
> using reset as the xshut pin.

> I think a choice has to be made here:
> 1. Either I use the st,vl53l0x.yaml binding with wrong pin name and
> optional vdd-supply to not break existing code.
> 2. Or use a separate binding st,vl53l1x.yaml with 1. correct pin name,
> and 2. require vdd-supply
> 
> Krzysztof, do you have a preference on how we should handle this?

I am not a DT guy, I only know (?) that the DT should describe HW.
In HW this pin seems like power enable which can roughly be considered
as reset. So from SW point of view it probably makes little to no
difference.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-03-12 15:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 22:40 [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor Siratul Islam
2026-03-11 22:40 ` [PATCH v3 1/2] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-11 22:40 ` [PATCH v3 2/2] iio: proximity: add driver for " Siratul Islam
2026-03-12 14:58   ` Andy Shevchenko
2026-03-12 17:37     ` Sirat
2026-03-13  9:35       ` Andy Shevchenko
2026-03-13 10:55         ` Sirat
2026-03-14 12:27       ` Jonathan Cameron
2026-03-12 14:27 ` [PATCH v3 0/2] " Andy Shevchenko
2026-03-12 15:12   ` Sirat
2026-03-12 15:23     ` Andy Shevchenko [this message]
2026-03-14 14:39     ` David Lechner
2026-03-14 15:25       ` Sirat
2026-03-15 18:57         ` Jonathan Cameron
2026-03-15 23:20           ` Sirat
2026-03-22 11:57             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abLaiwjU2NjFiIR3@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=email@sirat.me \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox