From: Jonathan Cameron <jic23@kernel.org>
To: Sirat <email@sirat.me>
Cc: David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
nuno.sa@analog.com, andy@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor
Date: Sun, 22 Mar 2026 11:57:04 +0000 [thread overview]
Message-ID: <20260322115704.10b2e0d4@jic23-huawei> (raw)
In-Reply-To: <CANn+LWL85Ot6yrfuNB4qw3YoUJPyE1YD2gf9PPPGoAGv8EOJ9w@mail.gmail.com>
On Mon, 16 Mar 2026 05:20:29 +0600
Sirat <email@sirat.me> wrote:
> On Mon, Mar 16, 2026 at 12:57 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sat, 14 Mar 2026 21:25:44 +0600
> > Sirat <email@sirat.me> wrote:
> >
> > > On Sat, Mar 14, 2026 at 8:39 PM David Lechner <dlechner@baylibre.com> wrote:
> > > >
> > > > On 3/12/26 10:12 AM, Sirat wrote:
> > > > > On Thu, Mar 12, 2026 at 8:28 PM Andy Shevchenko
> > > > > <andriy.shevchenko@intel.com> wrote:
> > > > >>
> > > > >> On Thu, Mar 12, 2026 at 04:40:35AM +0600, Siratul Islam wrote:
> > > > > ...
> > > > >>> ---
> ...
> > Can make it required in the binding. Just explain clearly why
> > it should be there. The driver should carry on coping without
> > it though (and leave a comment so we don't break that in the future).
> >
> > Jonathan
> >
> > >
> >
> Just to make sure that I understand this correctly,
>
> I will
> - make vdd-supply required and add a description of what it is.
> - add a comment in the driver like "vdd-supply is required in the DT
> binding but we continue if missing to support older DTs."
> - also add reset-gpio description and update the example to include the vdd.
>
> I'll send v6 after a few days.
>
Ah sorry. Took me too long to catch up with emails.
Bit late now but for the record, what we were aiming for was:
Make it required and add a note to the commit message to say why
the requirement should always have been there. Devices tend not to work
with no power.
The driver fallback stuff to provide a stub powersupply is very standard
so no specific need to call that out.
Jonathan
> Thanks,
> Sirat
> >
> >
parent reply other threads:[~2026-03-22 11:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CANn+LWL85Ot6yrfuNB4qw3YoUJPyE1YD2gf9PPPGoAGv8EOJ9w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260322115704.10b2e0d4@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox