Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor

Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor

[Jonathan Cameron]

On Mon, 16 Mar 2026 05:20:29 +0600
Sirat <email@sirat.me> wrote:

> On Mon, Mar 16, 2026 at 12:57 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sat, 14 Mar 2026 21:25:44 +0600
> > Sirat <email@sirat.me> wrote:
> >  
> > > On Sat, Mar 14, 2026 at 8:39 PM David Lechner <dlechner@baylibre.com> wrote:  
> > > >
> > > > On 3/12/26 10:12 AM, Sirat wrote:  
> > > > > On Thu, Mar 12, 2026 at 8:28 PM Andy Shevchenko
> > > > > <andriy.shevchenko@intel.com> wrote:  
> > > > >>
> > > > >> On Thu, Mar 12, 2026 at 04:40:35AM +0600, Siratul Islam wrote:  
> > > > > ...  
> > > > >>> ---  
> ...
> > Can make it required in the binding. Just explain clearly why
> > it should be there.  The driver should carry on coping without
> > it though (and leave a comment so we don't break that in the future).
> >
> > Jonathan
> >  
> > >  
> >  
> Just to make sure that I understand this correctly,
> 
> I will
>   - make vdd-supply required and add a description of what it is.
>   - add a comment in the driver like "vdd-supply is required in the DT
> binding but we continue if missing to support older DTs."
>   - also add reset-gpio description and update the example to include the vdd.
> 
>  I'll send v6 after a few days.
> 
Ah sorry. Took me too long to catch up with emails.

Bit late now but for the record, what we were aiming for was:

Make it required and add a note to the commit message to say why
the requirement should always have been there. Devices tend not to work
with no power.

The driver fallback stuff to provide a stub powersupply is very standard
so no specific need to call that out.

Jonathan



> Thanks,
> Sirat
> >
> >