From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Michael Hennerich" <michael.hennerich@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Jorge Marques" <jorge.marques@analog.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] iio: accel: adxl372: add support for ADXL371
Date: Fri, 13 Mar 2026 16:05:08 +0200 [thread overview]
Message-ID: <abQZlPRhCQfjKFEV@ashevche-desk.local> (raw)
In-Reply-To: <20260313115525.85435-5-antoniu.miclaus@analog.com>
On Fri, Mar 13, 2026 at 01:54:57PM +0200, Antoniu Miclaus wrote:
> Add support for the Analog Devices ADXL371, a +-200g 3-axis MEMS
> accelerometer sharing the same register map as the ADXL372 but with
> different ODR values (320/640/1280/2560/5120 Hz vs 400/800/1600/3200/
> 6400 Hz), different bandwidth values, and different timer scale
> factors for activity/inactivity detection.
>
> Due to a silicon anomaly (er001) causing FIFO data misalignment on
> all current ADXL371 silicon, FIFO and triggered buffer support is
> disabled for the ADXL371 - only direct mode reads are supported.
...
> +enum adxl371_odr {
> + ADXL371_ODR_320HZ,
> + ADXL371_ODR_640HZ,
> + ADXL371_ODR_1280HZ,
> + ADXL371_ODR_2560HZ,
> + ADXL371_ODR_5120HZ,
> + ADXL371_ODR_NUM,
No comma for the terminator entry.
> +};
...
> @@ -1217,8 +1258,8 @@ static int adxl372_buffer_setup(struct iio_dev *indio_dev)
> return -ENOMEM;
>
> st->peak_datardy_trig = devm_iio_trigger_alloc(dev, "%s-dev%d-peak",
> - indio_dev->name,
> - iio_device_id(indio_dev));
> + indio_dev->name,
> + iio_device_id(indio_dev));
> if (!st->peak_datardy_trig)
> return -ENOMEM;
Stray change. It doesn't belong to this patch.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-13 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 11:54 [PATCH v3 0/4] iio: accel: adxl372: add ADXL371 support Antoniu Miclaus
2026-03-13 11:54 ` [PATCH v3 1/4] iio: accel: adxl372: introduce chip_info structure Antoniu Miclaus
2026-03-13 14:01 ` Andy Shevchenko
2026-03-13 11:54 ` [PATCH v3 2/4] dt-bindings: iio: accel: adi,adxl372: add ADXL371 compatible Antoniu Miclaus
2026-03-13 11:54 ` [PATCH v3 3/4] iio: accel: adxl372: factor out buffer and trigger setup Antoniu Miclaus
2026-03-13 14:03 ` Andy Shevchenko
2026-03-13 11:54 ` [PATCH v3 4/4] iio: accel: adxl372: add support for ADXL371 Antoniu Miclaus
2026-03-13 14:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abQZlPRhCQfjKFEV@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox