Re: [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Shuai,


Thank you for your patch. gemini/gemini-3.1-pro-preview found a typo in 
the summary/title and commit message [1]:

> This isn't a bug, but there's a typo in the board name (monac) in the
> subject line. It looks like it should be monaco-arduino-monza.


Am 28.04.26 um 04:56 schrieb Shuai Zhang:
> enable bt on monac-arduino-monza

Please elaborate, that it’s UART 10, and how you tested it – including 
the low-power states.

> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4..092ca0b59 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -21,6 +21,7 @@ aliases {
>   		ethernet0 = &ethernet0;
>   		i2c1 = &i2c1;
>   		serial0 = &uart7;
> +		serial1 = &uart10;
>   	};
>   
>   	chosen {
> @@ -454,6 +455,16 @@ &uart7 {
>   	status = "okay";
>   };
>   
> +&uart10 {
> +	status = "okay";
> +	bluetooth: bluetooth {
> +		compatible = "qcom,qca2066-bt";
> +		max-speed = <3200000>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;

Next comment [1]:

> Should this node also include a clocks property?
> The device tree binding schema for qcom,qca2066-bt explicitly lists clocks
> in its required array to specify the external low-power 32.768 kHz clock
> input. Omitting it will cause dtbs_check to fail.
> While the Bluetooth driver treats the clock as optional, missing the sleep
> clock on Qualcomm platforms typically prevents the controller from entering
> low-power sleep states, which can lead to increased power consumption.

And this looks valid. From 
`Documentation/devicetree/bindings/net/bluetooth/qcom,qca2066-bt.yaml`:

     required:
       - compatible
       - clocks
       - enable-gpios

> +		status = "okay";
> +	};
> +};
> +
>   &usb_1 {
>   	status = "okay";
>   };


Kind regards,

Paul


[1]: 
https://sashiko.dev/#/patchset/20260428025652.662502-1-shuai.zhang%40oss.qualcomm.com