From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Shuai Zhang <shuai.zhang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com,
wei.deng@oss.qualcomm.com, jinwang.li@oss.qualcomm.com,
mengshi.wu@oss.qualcomm.com,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Subject: Re: [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node
Date: Tue, 28 Apr 2026 11:31:54 +0200 [thread overview]
Message-ID: <828c59ee-c30e-4a47-9ff8-6fbbe05bbdde@oss.qualcomm.com> (raw)
In-Reply-To: <20260428025652.662502-1-shuai.zhang@oss.qualcomm.com>
On 4/28/26 4:56 AM, Shuai Zhang wrote:
> enable bt on monac-arduino-monza
>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
This sign-off chain is invalid as-is - should this patch have
"From: Loic"? Who is the author?
> ---
> arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4..092ca0b59 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -21,6 +21,7 @@ aliases {
> ethernet0 = ðernet0;
> i2c1 = &i2c1;
> serial0 = &uart7;
> + serial1 = &uart10;
> };
>
> chosen {
> @@ -454,6 +455,16 @@ &uart7 {
> status = "okay";
> };
>
> +&uart10 {
> + status = "okay";
> + bluetooth: bluetooth {
Please keep a \n above the subnode definition
> + compatible = "qcom,qca2066-bt";
> + max-speed = <3200000>;
> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
> + status = "okay";
The node is enabled already, because nothing disabled it. Drop the
status line.
Konrad
next prev parent reply other threads:[~2026-04-28 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 2:56 [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node Shuai Zhang
2026-04-28 6:16 ` Paul Menzel
2026-04-28 9:31 ` Konrad Dybcio [this message]
2026-04-28 11:26 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=828c59ee-c30e-4a47-9ff8-6fbbe05bbdde@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=cheng.jiang@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jinwang.li@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mengshi.wu@oss.qualcomm.com \
--cc=quic_chezhou@quicinc.com \
--cc=robh@kernel.org \
--cc=shuai.zhang@oss.qualcomm.com \
--cc=wei.deng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox