public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node
@ 2026-04-28  2:56 Shuai Zhang
  2026-04-28  6:16 ` Paul Menzel
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Shuai Zhang @ 2026-04-28  2:56 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
	cheng.jiang, quic_chezhou, wei.deng, jinwang.li, mengshi.wu,
	shuai.zhang, Loic Poulain

enable bt on monac-arduino-monza

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
index ca14f0ea4..092ca0b59 100644
--- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
@@ -21,6 +21,7 @@ aliases {
 		ethernet0 = &ethernet0;
 		i2c1 = &i2c1;
 		serial0 = &uart7;
+		serial1 = &uart10;
 	};
 
 	chosen {
@@ -454,6 +455,16 @@ &uart7 {
 	status = "okay";
 };
 
+&uart10 {
+	status = "okay";
+	bluetooth: bluetooth {
+		compatible = "qcom,qca2066-bt";
+		max-speed = <3200000>;
+		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
+		status = "okay";
+	};
+};
+
 &usb_1 {
 	status = "okay";
 };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node
  2026-04-28  2:56 [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node Shuai Zhang
@ 2026-04-28  6:16 ` Paul Menzel
  2026-04-28  9:31 ` Konrad Dybcio
  2026-04-28 11:26 ` Dmitry Baryshkov
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2026-04-28  6:16 UTC (permalink / raw)
  To: Shuai Zhang
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	linux-bluetooth, cheng.jiang, quic_chezhou, wei.deng, jinwang.li,
	mengshi.wu, Loic Poulain

Dear Shuai,


Thank you for your patch. gemini/gemini-3.1-pro-preview found a typo in 
the summary/title and commit message [1]:

> This isn't a bug, but there's a typo in the board name (monac) in the
> subject line. It looks like it should be monaco-arduino-monza.


Am 28.04.26 um 04:56 schrieb Shuai Zhang:
> enable bt on monac-arduino-monza

Please elaborate, that it’s UART 10, and how you tested it – including 
the low-power states.

> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4..092ca0b59 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -21,6 +21,7 @@ aliases {
>   		ethernet0 = &ethernet0;
>   		i2c1 = &i2c1;
>   		serial0 = &uart7;
> +		serial1 = &uart10;
>   	};
>   
>   	chosen {
> @@ -454,6 +455,16 @@ &uart7 {
>   	status = "okay";
>   };
>   
> +&uart10 {
> +	status = "okay";
> +	bluetooth: bluetooth {
> +		compatible = "qcom,qca2066-bt";
> +		max-speed = <3200000>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;

Next comment [1]:

> Should this node also include a clocks property?
> The device tree binding schema for qcom,qca2066-bt explicitly lists clocks
> in its required array to specify the external low-power 32.768 kHz clock
> input. Omitting it will cause dtbs_check to fail.
> While the Bluetooth driver treats the clock as optional, missing the sleep
> clock on Qualcomm platforms typically prevents the controller from entering
> low-power sleep states, which can lead to increased power consumption.

And this looks valid. From 
`Documentation/devicetree/bindings/net/bluetooth/qcom,qca2066-bt.yaml`:

     required:
       - compatible
       - clocks
       - enable-gpios

> +		status = "okay";
> +	};
> +};
> +
>   &usb_1 {
>   	status = "okay";
>   };


Kind regards,

Paul


[1]: 
https://sashiko.dev/#/patchset/20260428025652.662502-1-shuai.zhang%40oss.qualcomm.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node
  2026-04-28  2:56 [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node Shuai Zhang
  2026-04-28  6:16 ` Paul Menzel
@ 2026-04-28  9:31 ` Konrad Dybcio
  2026-04-28 11:26 ` Dmitry Baryshkov
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-04-28  9:31 UTC (permalink / raw)
  To: Shuai Zhang, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
	cheng.jiang, quic_chezhou, wei.deng, jinwang.li, mengshi.wu,
	Loic Poulain

On 4/28/26 4:56 AM, Shuai Zhang wrote:
> enable bt on monac-arduino-monza
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>

This sign-off chain is invalid as-is - should this patch have
"From: Loic"? Who is the author?

> ---
>  arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4..092ca0b59 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -21,6 +21,7 @@ aliases {
>  		ethernet0 = &ethernet0;
>  		i2c1 = &i2c1;
>  		serial0 = &uart7;
> +		serial1 = &uart10;
>  	};
>  
>  	chosen {
> @@ -454,6 +455,16 @@ &uart7 {
>  	status = "okay";
>  };
>  
> +&uart10 {
> +	status = "okay";
> +	bluetooth: bluetooth {

Please keep a \n above the subnode definition

> +		compatible = "qcom,qca2066-bt";
> +		max-speed = <3200000>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
> +		status = "okay";

The node is enabled already, because nothing disabled it. Drop the
status line.

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node
  2026-04-28  2:56 [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node Shuai Zhang
  2026-04-28  6:16 ` Paul Menzel
  2026-04-28  9:31 ` Konrad Dybcio
@ 2026-04-28 11:26 ` Dmitry Baryshkov
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-04-28 11:26 UTC (permalink / raw)
  To: Shuai Zhang
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	linux-bluetooth, cheng.jiang, quic_chezhou, wei.deng, jinwang.li,
	mengshi.wu, Loic Poulain

On Tue, Apr 28, 2026 at 10:56:52AM +0800, Shuai Zhang wrote:
> enable bt on monac-arduino-monza
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4..092ca0b59 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -21,6 +21,7 @@ aliases {
>  		ethernet0 = &ethernet0;
>  		i2c1 = &i2c1;
>  		serial0 = &uart7;
> +		serial1 = &uart10;
>  	};
>  
>  	chosen {
> @@ -454,6 +455,16 @@ &uart7 {
>  	status = "okay";
>  };
>  
> +&uart10 {
> +	status = "okay";
> +	bluetooth: bluetooth {
> +		compatible = "qcom,qca2066-bt";

What powers on this BT device?

> +		max-speed = <3200000>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
> +		status = "okay";
> +	};
> +};
> +
>  &usb_1 {
>  	status = "okay";
>  };
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-28 11:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28  2:56 [PATCH v1] arm64: dts: monac-arduino-monza: Add Bluetooth UART node Shuai Zhang
2026-04-28  6:16 ` Paul Menzel
2026-04-28  9:31 ` Konrad Dybcio
2026-04-28 11:26 ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox