From: David Heidelberg <david@ixit.cz>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Petr Hodina <petr.hodina@protonmail.com>,
Richard Acayan <mailingradian@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras
Date: Tue, 1 Sep 2026 11:37:20 +0200 [thread overview]
Message-ID: <ac6b4f63-23e0-4a25-acfe-8b25d6f8ed08@ixit.cz> (raw)
In-Reply-To: <apYtQQkrZB5gHqJy@baldur>
it depends on the
https://lore.kernel.org/all/20260628-kbingham-orientation-v3-0-4ed92968aff8@ideasonboard.com/
I'll send the next revision.
David
On 01/09/2026 03:41, Bjorn Andersson wrote:
> On Tue, Jul 21, 2026 at 02:36:49PM +0200, Konrad Dybcio wrote:
>> On 7/21/26 2:33 PM, David Heidelberg via B4 Relay wrote:
>>> From: David Heidelberg <david@ixit.cz>
>>>
>>> The Pixel 3 features two front-facing Sony IMX355 sensors with
>>> different focal lengths (standard and wide-angle).
>>>
>>> Sensors are connected via CSIPHY port 1 and 2 and controlled over CCI
>>> I2C1, using MCLK2 as the clock source.
>>>
>>> This enables support for the dual front camera configuration.
>>>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 172 ++++++++++++++++++++-
>>> 1 file changed, 171 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
>>> index 9368fd6b87515..c8a28133fb38d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
>>> @@ -1,16 +1,18 @@
>>> // SPDX-License-Identifier: GPL-2.0-only
>>>
>>> /dts-v1/;
>>>
>>> #include <dt-bindings/arm/qcom,ids.h>
>>> #include <dt-bindings/dma/qcom-gpi.h>
>>> #include <dt-bindings/input/linux-event-codes.h>
>>> #include <dt-bindings/interrupt-controller/irq.h>
>>> +#include <dt-bindings/media/video-interfaces.h>
>>> +#include <dt-bindings/media/video-interface-devices.h>
>>
>> These should be flipped to be sorted.. if you smile very nicely,
>> Bjorn could prob fix it up
>>
>
> Sure can do, but I don't have dt-bindings/media/video-interface-devices.h :(
>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> Konrad
next prev parent reply other threads:[~2026-09-01 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 12:33 [PATCH v7 0/2] Add initial dual front camera and rear flash support for Pixel 3 / 3 XL David Heidelberg via B4 Relay
2026-07-21 12:33 ` [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras David Heidelberg via B4 Relay
2026-07-21 12:36 ` Konrad Dybcio
2026-09-01 1:41 ` Bjorn Andersson
2026-09-01 9:37 ` David Heidelberg [this message]
2026-07-21 12:45 ` sashiko-bot
2026-07-21 12:33 ` [PATCH v7 2/2] arm64: dts: qcom: sdm845-google: Enable PMI8998 camera flash LEDs David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6b4f63-23e0-4a25-acfe-8b25d6f8ed08@ixit.cz \
--to=david@ixit.cz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=petr.hodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).