Re: [PATCH v5 2/2] media: i2c: Add Sony IMX908 image sensor driver

[Lachlan Michael <Lachlan.Michael@sony.com>]

Laurent, Sakari,

On 10/21/2026 9:05 PM, Laurent Pinchart wrote:
> On Wed, Oct 21, 2026 at 02:56:50PM +0300, Sakari Ailus wrote:
>> On Tue, Oct 20, 2026 at 03:50:09PM +0100, Dave Stevenson wrote:
>>> On Tue, 20 Oct 2026 at 13:56, Laurent Pinchart wrote:
>>>> On Tue, Oct 20, 2026 at 01:47:11PM +0300, Sakari Ailus wrote:

>>> I have compared the datasheet for imx908 against the Starvis2 ones,
>>> and when we start looking at HDR modes they diverge a reasonable
>>> amount.
>>>
>>> Even the later Starvis2 sensors (IMX585 and IMX676) have minor changes
>>> to the earlier ones, so adding Starvis3 would need some care.
>>
>> There's quite a bit of this in the CCS driver, due to the variance it
>> allows for implementors. I don't see this being a problem as long as the
>> foundations are reasonably similar, albeit we can see whether this could be
>> further extended later on to other sensors.
>>
>> I'm fine with having a separate imx908 driver for now. Dave's driver also
>> exposes the variant information through the media entity name so that
>> should be done by the imx908, too (at least if there can be multiple ones).
> 
> As far as I understand, the IMX908 does not have a mono version.
> Lachlan, could you please confirm that ?

I checked with the developers and there is no mono version.

>> I'll review the driver properly soonish but I reckon it's in a pretty good
>> shape already.

Thanks. Appreciate your patience with us.

Best Regards,

Lachlan