Re: [PATCH v2 0/2] iio: magnetometer: add MEMSIC MMC5983MA driver

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, May 07, 2026 at 08:50:30PM +0000, Vladislav Kulikov wrote:
> Add an IIO driver for the MEMSIC MMC5983MA 3-axis magnetometer over
> I2C. The driver provides raw magnetic field readings with
> per-measurement SET/RESET offset cancellation, giving 18-bit output
> with a full-scale range of +/-8 Gauss.
> 
> Tested on a Raspberry Pi 2B with the sensor on I2C-1 at 0x30.
> 
> The initial driver implements the validated I2C single-measurement path.
> Other chip features are left for future work:
> 
> - SPI transport: the binding describes SPI wiring, but driver support is
>   left for follow-up validation of the SPI command and SET/RESET
>   sequencing.
> - Temperature channel: left until the temperature output behavior is
>   better validated.
> - Continuous measurement mode and Auto SET/RESET: left until the
>   interaction between CMM, TM_M, Meas_M_Done, and SET/RESET sequencing
>   is better understood.
> - Saturation/self-test bits and BW/decimation tuning: not exposed until
>   their behavior can be described reliably through stable IIO ABI.
> 
> The driver uses a conservative 500 us post-SET/RESET delay before
> starting the following measurement. The datasheet describes a 500 ns
> SET/RESET coil pulse, but testing showed that a longer software delay is
> needed before taking the next measurement.

My comment from v1 still applies. Note, when sending a new version of a driver
like this, give approximately as many days as hundreds of LoC in it.
The bare minimum 24h anyway.

-- 
With Best Regards,
Andy Shevchenko