Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>,
	neil.armstrong@linaro.org, jesszhan0024@gmail.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm/panel: novatek-nt36525: fix v1 review issues
Date: Tue, 17 Nov 2026 11:47:53 +0100	[thread overview]
Message-ID: <af565a17-f7a1-4c24-bf2a-130a025c68e3@kernel.org> (raw)
In-Reply-To: <20261117104353.1180634-2-tadilhusrev@gmail.com>

On 17/11/2026 11:43, Adil Hüsrev Tepe wrote:
> Addresses the issues Sashiko AI flagged on v1
> (https://sashiko.dev/#/patchset/20261116070212.314228-1-tadilhusrev@gmail.com?part=2):
> 
> - Set prepare_prev_first = true before drm_panel_add(). Without it,
>   drm_atomic_bridge_chain_pre_enable()/post_disable() call this panel's
>   prepare()/unprepare() on the wrong side of the DSI host bridge's own
>   enable/disable, which host_transfer() rejects on bridge-based hosts
>   (e.g. samsung-dsim).

v2 is the next version of patchset, not patch on top of v1. Please use
git to manage your work correctly and b4 to send it, which also would
solve it. Linaro had excellent guide, so please read it to avoid trivial
mistakes like this one:
https://www.linaro.org/blog/becoming-a-kernel-developer-part1-posting-your-first-patch/

Best regards,
Krzysztof

  reply	other threads:[~2026-11-17 10:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:02 [PATCH v1 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-16  7:02 ` [PATCH v1 1/2] dt-bindings: display: panel: add Novatek NT36525 Adil Hüsrev Tepe
2026-11-16  7:14   ` sashiko-bot
2026-11-16  7:02 ` [PATCH v1 2/2] drm/panel: add Novatek NT36525 panel driver Adil Hüsrev Tepe
2026-11-16  7:22   ` sashiko-bot
2026-11-17 10:43 ` [PATCH v2 1/2] dt-bindings: display: panel: novatek,nt36525: fix v1 review issues Adil Hüsrev Tepe
2026-11-17 10:43   ` [PATCH v2 2/2] drm/panel: novatek-nt36525: " Adil Hüsrev Tepe
2026-11-17 10:47     ` Krzysztof Kozlowski [this message]
2026-11-17 17:33       ` Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 1/2] dt-bindings: display: panel: add Novatek NT36525 Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 2/2] drm/panel: add Novatek NT36525 panel driver Adil Hüsrev Tepe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af565a17-f7a1-4c24-bf2a-130a025c68e3@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tadilhusrev@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox