From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH 2/2] regulator: add SGM3804 Dual Output driver
Date: Wed, 29 Apr 2026 09:44:55 +0900 [thread overview]
Message-ID: <afFUh21CNpv17-kN@sirena.co.uk> (raw)
In-Reply-To: <afFS3W5hokXy3T7x@sirena.co.uk>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Wed, Apr 29, 2026 at 09:37:49AM +0900, Mark Brown wrote:
> On Tue, Apr 28, 2026 at 03:52:06PM +0200, Neil Armstrong wrote:
> > + ret = regulator_set_active_discharge_regmap(rdev,
> > + ctx->active_discharge[rdev_get_id(rdev)]);
> It seems like this should be a regcache sync then only the enable and
> disable operations need to be custom? There is a register cache and it
> covers these registers, without it the _active_discharge wouldn't work
> since it does a regmap_update_bits() and all the registers are marked
> unreadable.
Actually I'm not clear how the cache works here since everything
writable is also marked as volatile but no register is readable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-29 0:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 13:52 [PATCH 0/2] regulator: add support for SGM3804 Dual Output driver Neil Armstrong
2026-04-28 13:52 ` [PATCH 1/2] dt-bindings: regulator: document the SGM3804 Dual Output regulator Neil Armstrong
2026-04-28 15:30 ` Rob Herring (Arm)
2026-04-29 0:23 ` Mark Brown
2026-04-29 0:38 ` Mark Brown
2026-04-29 8:02 ` Neil Armstrong
2026-04-28 13:52 ` [PATCH 2/2] regulator: add SGM3804 Dual Output driver Neil Armstrong
2026-04-29 0:37 ` Mark Brown
2026-04-29 0:44 ` Mark Brown [this message]
2026-04-29 8:05 ` Neil Armstrong
2026-04-30 1:06 ` Mark Brown
2026-04-30 7:16 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afFUh21CNpv17-kN@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox