From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH 2/2] regulator: add SGM3804 Dual Output driver
Date: Thu, 30 Apr 2026 10:06:39 +0900 [thread overview]
Message-ID: <afKrH4fdv1jXxLgk@sirena.co.uk> (raw)
In-Reply-To: <7d2fd0d7-2ac2-43d8-be5c-4f9fcd7908bb@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Wed, Apr 29, 2026 at 10:05:33AM +0200, Neil Armstrong wrote:
> On 4/29/26 02:37, Mark Brown wrote:
> > On Tue, Apr 28, 2026 at 03:52:06PM +0200, Neil Armstrong wrote:
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * SGMicro SGM3804 regulator Driver
> > > + *
> > > + * Copyright (C) 2025 Kancy Joe <kancy2333@outlook.com>
> > > + * Copyright (C) 2026 Linaro Limited
> > > + * Author: Neil Armstrong <neil.armstrong@linaro.org>
> > > + */
> > Please make the entire comment a C++ one so things look more
> > intentional. The authorship overall appears a bit confused?
> Sorry, what's confusing here ?
At various times both you and Kancy Joe are listed as authors of the
driver, but rarely both of you simulataneously. I can't tell what your
roles were here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-30 1:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 13:52 [PATCH 0/2] regulator: add support for SGM3804 Dual Output driver Neil Armstrong
2026-04-28 13:52 ` [PATCH 1/2] dt-bindings: regulator: document the SGM3804 Dual Output regulator Neil Armstrong
2026-04-28 15:30 ` Rob Herring (Arm)
2026-04-29 0:23 ` Mark Brown
2026-04-29 0:38 ` Mark Brown
2026-04-29 8:02 ` Neil Armstrong
2026-04-28 13:52 ` [PATCH 2/2] regulator: add SGM3804 Dual Output driver Neil Armstrong
2026-04-29 0:37 ` Mark Brown
2026-04-29 0:44 ` Mark Brown
2026-04-29 8:05 ` Neil Armstrong
2026-04-30 1:06 ` Mark Brown [this message]
2026-04-30 7:16 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afKrH4fdv1jXxLgk@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox