Re: [PATCH v3 1/2] dt-bindings: iio: light: add Broadcom APDS9999

["Jose A. Perez de Azpillaga" <azpijr@gmail.com>]

On Tue, May 19, 2026 at 06:30:20PM +0100, Conor Dooley wrote:
> On Tue, May 19, 2026 at 11:23:13AM +0200, Jose A. Perez de Azpillaga wrote:
> > Add Device Tree binding for the Broadcom APDS9999 ambient light
> > and proximity sensor. A separate binding file is used rather
> > than merging with avago,apds9300.yaml because the APDS9999
> > has an additional vled-supply for the VCSEL.
> >
> > The APDS9999 features individual R, G, B, and IR channels with
> > a green channel that uses optical coating to approximate the
> > human eye spectral response for ALS/lux measurements. Calibrated
> > RGB color sensing is not yet implemented in the driver.
> >
> > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > ---
> >  .../bindings/iio/light/brcm,apds9999.yaml     | 54 +++++++++++++++++++
> >  MAINTAINERS                                   |  6 +++
> >  2 files changed, 60 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > new file mode 100644
> > index 000000000000..4d9e9aff8894
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/light/brcm,apds9999.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +title: Broadcom APDS-9999 Digital Proximity and RGB Sensor
> > +
> > +maintainers:
> > +  - Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > +
> > +description: |
> > +  Broadcom APDS-9999 is a digital proximity and RGB sensor with
> > +  ambient light sensing (ALS) capability. The device uses individual
> > +  R, G, B, and IR channels plus a Vertical Cavity Surface Emitting
> > +  Laser (VCSEL) for proximity detection.
> > +
> > +  Datasheet: https://docs.broadcom.com/docs/APDS-9999-DS
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - brcm,apds9999
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply: true
> > +
> > +  vled-supply:
> > +    description: VCSEL power supply
>
> Why does the name in the description disagree with the name in the
> property? If the pin is called vcsel, please call the property that.
>

will rename to vcsel-supply in v4.

> Cheers,
> Conor.
>
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vdd-supply
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        light-sensor@52 {
> > +            compatible = "brcm,apds9999";
> > +            reg = <0x52>;
> > +            vdd-supply = <&vdd_reg>;
> > +            vled-supply = <&vled_reg>;
> > +        };
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1aa9c989973f..2d8d4e2eab6e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5000,6 +5000,12 @@ S:	Maintained
> >  F:	Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> >  F:	drivers/iio/light/apds9160.c
> >
> > +BROADCOM APDS9999 AMBIENT LIGHT SENSOR DRIVER
> > +M:	Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > +L:	linux-iio@vger.kernel.org
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > +
> >  BROADCOM ASP 2.0 ETHERNET DRIVER
> >  M:	Justin Chen <justin.chen@broadcom.com>
> >  M:	Florian Fainelli <florian.fainelli@broadcom.com>
> >
> >
>
> pw-bot: changes-requested

--
jose a. p-a