Re: [PATCH v3 1/2] dt-bindings: iio: light: add Broadcom APDS9999

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2746 bytes --]

On Wed, May 20, 2026 at 10:56:19AM +0200, Jose A. Perez de Azpillaga wrote:
> On Tue, May 19, 2026 at 06:30:20PM +0100, Conor Dooley wrote:
> > On Tue, May 19, 2026 at 11:23:13AM +0200, Jose A. Perez de Azpillaga wrote:
> > > Add Device Tree binding for the Broadcom APDS9999 ambient light
> > > and proximity sensor. A separate binding file is used rather
> > > than merging with avago,apds9300.yaml because the APDS9999
> > > has an additional vled-supply for the VCSEL.
> > >
> > > The APDS9999 features individual R, G, B, and IR channels with
> > > a green channel that uses optical coating to approximate the
> > > human eye spectral response for ALS/lux measurements. Calibrated
> > > RGB color sensing is not yet implemented in the driver.
> > >
> > > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > > ---
> > >  .../bindings/iio/light/brcm,apds9999.yaml     | 54 +++++++++++++++++++
> > >  MAINTAINERS                                   |  6 +++
> > >  2 files changed, 60 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > > new file mode 100644
> > > index 000000000000..4d9e9aff8894
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> > > @@ -0,0 +1,54 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/light/brcm,apds9999.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +title: Broadcom APDS-9999 Digital Proximity and RGB Sensor
> > > +
> > > +maintainers:
> > > +  - Jose A. Perez de Azpillaga <azpijr@gmail.com>
> > > +
> > > +description: |
> > > +  Broadcom APDS-9999 is a digital proximity and RGB sensor with
> > > +  ambient light sensing (ALS) capability. The device uses individual
> > > +  R, G, B, and IR channels plus a Vertical Cavity Surface Emitting
> > > +  Laser (VCSEL) for proximity detection.
> > > +
> > > +  Datasheet: https://docs.broadcom.com/docs/APDS-9999-DS
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - brcm,apds9999
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  vdd-supply: true
> > > +
> > > +  vled-supply:
> > > +    description: VCSEL power supply
> >
> > Why does the name in the description disagree with the name in the
> > property? If the pin is called vcsel, please call the property that.
> >
> 
> will rename to vcsel-supply in v4.

Sounds good.

pw-bot: changes-requested

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]