From: Brian Norris <briannorris@chromium.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Joe Perches <joe@perches.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Yingying Tang <yingying.tang@oss.qualcomm.com>
Subject: Re: [PATCH] checkpatch: Don't emit warnings for USB & PCI device DT compatible prefixes
Date: Fri, 15 May 2026 12:23:41 -0700 [thread overview]
Message-ID: <agdyvR0EjH-RXBcy@google.com> (raw)
In-Reply-To: <CAGXv+5HrunhENv3QD4uG0ZLs8BvdOdrQcfn_82DRP51+_+ECUQ@mail.gmail.com>
On Fri, May 15, 2026 at 11:24:09AM +0800, Chen-Yu Tsai wrote:
> We could import Documentation/devicetree/bindings/processed-schema.json
> and match against the compatibles and vendor prefixes from that. It
> might actually be faster (vs grepping through the entire DT bindings
> directory), but it requires the user having run make commands that
> produce it.
Personally, I would avoid having checkpatch do more duplication of
other/better tools, like the DT schema validator. I'd also avoid having
it run other tools that are not guaranteed to be easily available.
I would focus on eliminating the false positives, even if that means
making checkpatch less likely to catch omissions.
But my opinion may not be valuable.
Brian
next prev parent reply other threads:[~2026-05-15 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 10:51 [PATCH] checkpatch: Don't emit warnings for USB & PCI device DT compatible prefixes Chen-Yu Tsai
2026-05-14 17:40 ` Brian Norris
2026-05-14 18:10 ` Joe Perches
2026-05-15 3:24 ` Chen-Yu Tsai
2026-05-15 19:23 ` Brian Norris [this message]
2026-05-15 21:26 ` Joe Perches
2026-05-14 18:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agdyvR0EjH-RXBcy@google.com \
--to=briannorris@chromium.org \
--cc=apw@canonical.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=robh@kernel.org \
--cc=wenst@chromium.org \
--cc=yingying.tang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox