Re: [PATCH v9 2/9] dt-bindings: media: sun6i-a31-isp: Add optional interconnect properties

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

Hi,

Le Mon 18 May 26, 15:50, sashiko-bot@kernel.org a écrit :
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The commit message body incorrectly refers to the 'sun6i-a31-csi' device instead of the 'sun6i-a31-isp' device.
> --
> 
> commit 816ee95ed6c916a2cdd9b96a5a6e283ad0e7d42e
> Author: Paul Kocialkowski <paulk@sys-base.io>
> 
> dt-bindings: media: sun6i-a31-isp: Add optional interconnect properties
> 
> This commit updates the allwinner,sun6i-a31-isp device tree binding by adding
> optional interconnect and interconnect-names properties.
> 
> > An interconnect can be attached to the sun6i-a31-csi device, which is
> > useful to attach the dma memory offset. Add related properties.
> 
> This isn't a bug, but should the commit message body refer to the
> sun6i-a31-isp device instead of the sun6i-a31-csi device? 
> 
> The patch modifies the allwinner,sun6i-a31-isp.yaml binding and the commit
> title correctly indicates sun6i-a31-isp.

Yes that is true. Maybe it can be fixed while applying, or just ignored.
I don't think the level of confusion is worth sending a v10 just for
this.

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]