Re: [PATCH v6 03/16] firmware: qcom_scm: Migrate to generic PAS service

[Sumit Garg <sumit.garg@kernel.org>]

On Tue, May 19, 2026 at 07:33:47AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Missing NULL pointer check in `__qcom_scm_pas_metadata_release` leads to a kernel warning on error paths.
> --
> 
> commit d6345df3a23d159b333a40adf86ed6859c37ccc5
> Author: Sumit Garg <sumit.garg@oss.qualcomm.com>
> 
> firmware: qcom_scm: Migrate to generic PAS service
> 
> With the availability of generic PAS service, let's add SCM calls as
> a backend to keep supporting legacy QTEE interfaces. The exported
> qcom_scm* wrappers will get dropped once all the client drivers get
> migrated as part of future patches.
> 
> > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> > --- a/drivers/firmware/qcom/qcom_scm.c
> > +++ b/drivers/firmware/qcom/qcom_scm.c
> 
> [ ... ]
> 
> > -/**
> > - * qcom_scm_pas_metadata_release() - release metadata context
> > - * @ctx:	pas context
> > - */
> > -void qcom_scm_pas_metadata_release(struct qcom_scm_pas_context *ctx)
> > +int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size,
> > +			    struct qcom_scm_pas_context *ctx)
> >  {
> > -	if (!ctx->ptr)
> > -		return;
> > +	return __qcom_scm_pas_init_image2(__scm->dev, pas_id, metadata, size,
> > +					  (struct qcom_pas_context *)ctx);
> > +}
> > +EXPORT_SYMBOL_GPL(qcom_scm_pas_init_image);
> >  
> > +static void __qcom_scm_pas_metadata_release(struct device *dev,
> > +					    struct qcom_pas_context *ctx)
> > +{
> >  	if (ctx->use_tzmem)
> >  		qcom_tzmem_free(ctx->ptr);
> 
> Since the original if (!ctx->ptr) check was removed here, could this result
> in calling qcom_tzmem_free(NULL) on error paths?
> 
> Client drivers like qcom_q6v5_pas unconditionally call
> qcom_scm_pas_metadata_release() during cleanup, even if
> qcom_scm_pas_init_image() failed or was bypassed. In these cases, ctx->ptr
> would still be NULL.
> 
> Calling qcom_tzmem_free(NULL) unconditionally triggers a warning inside the
> allocator.
> 
> While this is fixed later in the patch series when all callers migrate to
> the generic PAS API and the legacy wrappers are dropped, does this
> intermediate patch break bisectability by introducing these warnings on
> error paths?

Not an issue as generic PAS APIs perform proper NULL check.

-Sumit

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260518072856.22790-1-sumit.garg@kernel.org?part=3