Devicetree
 help / color / mirror / Atom feed
* [PATCH v2 0/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A
@ 2026-05-28 17:34 Pradhan, Sanman
  2026-05-28 17:34 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add " Pradhan, Sanman
  2026-05-28 17:34 ` [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for " Pradhan, Sanman
  0 siblings, 2 replies; 7+ messages in thread
From: Pradhan, Sanman @ 2026-05-28 17:34 UTC (permalink / raw)
  To: linux-hwmon@vger.kernel.org
  Cc: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Syed, Arif, Sanman Pradhan

From: Sanman Pradhan <psanman@juniper.net>

Add PMBus hwmon driver and DT binding for the Analog Devices MAX20860A
step-down DC-DC switching regulator. The driver provides monitoring of
input/output voltage, output current, and temperature using linear data
format.

This is a monitoring-only driver. The device's hardware write-protection
(WRITE_PROTECT register = 0x20) is detected and respected automatically
by pmbus_core via pmbus_init_wp().

Tested on PTX platform with MAX20860A at i2c-195/0x23:
  - All sensors (vin, vout, iout, temp1, temp2) read correctly
  - Limit attributes correctly read-only (HW write-protect honored)
  - Clean dmesg (no probe errors)

Changes since v1:
  - DT binding: Added allOf regulator.yaml reference and unevaluatedProperties
  - DT binding: Added "maxim,max20860a" as alternative compatible
  - Driver: Added "maxim,max20860a" to of_device_id table
  - Driver: Removed redundant WRITE_PROTECT write from probe (pmbus_core
    handles it via pmbus_init_wp())

Syed Arif (1):
  hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A

Sanman Pradhan (1):
  dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A

 .../bindings/hwmon/pmbus/adi,max20860a.yaml   | 47 +++++++++++++++
 Documentation/hwmon/index.rst                 |  1 +
 Documentation/hwmon/max20860a.rst             | 57 ++++++++++++++++++
 MAINTAINERS                                   |  8 +++
 drivers/hwmon/pmbus/Kconfig                   |  9 +++
 drivers/hwmon/pmbus/Makefile                  |  1 +
 drivers/hwmon/pmbus/max20860a.c               | 58 +++++++++++++++++++
 7 files changed, 181 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
 create mode 100644 Documentation/hwmon/max20860a.rst
 create mode 100644 drivers/hwmon/pmbus/max20860a.c

-- 
2.34.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A
  2026-05-28 17:34 [PATCH v2 0/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A Pradhan, Sanman
@ 2026-05-28 17:34 ` Pradhan, Sanman
  2026-05-28 17:41   ` Conor Dooley
  2026-05-28 17:48   ` sashiko-bot
  2026-05-28 17:34 ` [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for " Pradhan, Sanman
  1 sibling, 2 replies; 7+ messages in thread
From: Pradhan, Sanman @ 2026-05-28 17:34 UTC (permalink / raw)
  To: linux-hwmon@vger.kernel.org
  Cc: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Syed, Arif, Sanman Pradhan

From: Sanman Pradhan <psanman@juniper.net>

Add devicetree binding documentation for the Analog Devices MAX20860A
step-down DC-DC switching regulator with PMBus interface.

Both "adi,max20860a" and "maxim,max20860a" compatible strings are
supported. The MAX20860A was originally manufactured by Maxim Integrated,
now part of Analog Devices.

Signed-off-by: Sanman Pradhan <psanman@juniper.net>
---
v2:
  - Added allOf regulator.yaml reference and unevaluatedProperties
  - Added "maxim,max20860a" as alternative compatible

 .../bindings/hwmon/pmbus/adi,max20860a.yaml   | 47 ++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
new file mode 100644
index 000000000000..f7eeb30f11b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/pmbus/adi,max20860a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX20860A Step-Down Converter
+
+maintainers:
+  - Sanman Pradhan <psanman@juniper.net>
+
+description: |
+  The MAX20860A is a fully integrated step-down DC-DC switching regulator
+  with PMBus interface for monitoring input/output voltage, output current
+  and temperature.
+
+  Datasheet: https://www.analog.com/en/products/max20860a.html
+
+allOf:
+  - $ref: /schemas/regulator/regulator.yaml#
+
+properties:
+  compatible:
+    enum:
+      - adi,max20860a
+      - maxim,max20860a
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        regulator@40 {
+            compatible = "adi,max20860a";
+            reg = <0x40>;
+        };
+    };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A
  2026-05-28 17:34 [PATCH v2 0/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A Pradhan, Sanman
  2026-05-28 17:34 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add " Pradhan, Sanman
@ 2026-05-28 17:34 ` Pradhan, Sanman
  2026-05-28 18:04   ` sashiko-bot
  1 sibling, 1 reply; 7+ messages in thread
From: Pradhan, Sanman @ 2026-05-28 17:34 UTC (permalink / raw)
  To: linux-hwmon@vger.kernel.org
  Cc: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Syed, Arif, Sanman Pradhan

From: Syed Arif <arif.syed@hpe.com>

Add a PMBus driver for the Analog Devices MAX20860A step-down DC-DC
switching regulator. The MAX20860A provides monitoring of input/output
voltage, output current, and temperature via the PMBus interface using
linear data format.

Both "adi,max20860a" and "maxim,max20860a" compatible strings are
supported for devicetree matching.

Signed-off-by: Syed Arif <arif.syed@hpe.com>
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
---
v2:
  - Added "maxim,max20860a" to of_device_id table
  - Removed WRITE_PROTECT write from probe

 Documentation/hwmon/index.rst     |  1 +
 Documentation/hwmon/max20860a.rst | 57 ++++++++++++++++++++++++++++++
 MAINTAINERS                       |  8 +++++
 drivers/hwmon/pmbus/Kconfig       |  9 +++++
 drivers/hwmon/pmbus/Makefile      |  1 +
 drivers/hwmon/pmbus/max20860a.c   | 58 +++++++++++++++++++++++++++++++
 6 files changed, 134 insertions(+)
 create mode 100644 Documentation/hwmon/max20860a.rst
 create mode 100644 drivers/hwmon/pmbus/max20860a.c

diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index e880c6ca84f0..ffaacda416e7 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -163,6 +163,7 @@ Hardware Monitoring Kernel Drivers
    max20730
    max20751
    max20830
+   max20860a
    max31722
    max31730
    max31760
diff --git a/Documentation/hwmon/max20860a.rst b/Documentation/hwmon/max20860a.rst
new file mode 100644
index 000000000000..ea6d2228fafc
--- /dev/null
+++ b/Documentation/hwmon/max20860a.rst
@@ -0,0 +1,57 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+Kernel driver max20860a
+=======================
+
+Supported chips:
+
+  * Analog Devices MAX20860A
+
+    Prefix: 'max20860a'
+
+    Addresses scanned: -
+
+    Datasheet: https://www.analog.com/en/products/max20860a.html
+
+Author:
+
+  - Syed Arif <arif.syed@hpe.com>
+  - Sanman Pradhan <psanman@juniper.net>
+
+
+Description
+-----------
+
+This driver supports hardware monitoring for Analog Devices MAX20860A
+Step-Down Switching Regulator with PMBus Interface.
+
+The MAX20860A is a fully integrated step-down DC-DC switching regulator.
+Through the PMBus interface, the device can monitor input/output voltages,
+output current and temperature.
+
+The driver is a client driver to the core PMBus driver. Please see
+Documentation/hwmon/pmbus.rst for details on PMBus client drivers.
+
+Usage Notes
+-----------
+
+This driver does not auto-detect devices. You will have to instantiate
+the devices explicitly.
+
+Sysfs entries
+-------------
+
+================= ========================================
+in1_label         "vin"
+in1_input         Measured input voltage
+in1_alarm         Input voltage alarm
+in2_label         "vout1"
+in2_input         Measured output voltage
+in2_alarm         Output voltage alarm
+curr1_label       "iout1"
+curr1_input       Measured output current
+curr1_alarm       Output current alarm
+temp1_input       Measured temperature
+temp1_alarm       Chip temperature alarm
+temp2_input       Measured temperature (secondary)
+================= ========================================
diff --git a/MAINTAINERS b/MAINTAINERS
index b71acb130395..1d9651947ee3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15688,6 +15688,14 @@ F:	Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
 F:	Documentation/hwmon/max20830.rst
 F:	drivers/hwmon/pmbus/max20830.c
 
+MAX20860A HARDWARE MONITOR DRIVER
+M:	Sanman Pradhan <psanman@juniper.net>
+L:	linux-hwmon@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
+F:	Documentation/hwmon/max20860a.rst
+F:	drivers/hwmon/pmbus/max20860a.c
+
 MAX2175 SDR TUNER DRIVER
 M:	Ramesh Shanmugasundaram <rashanmu@gmail.com>
 L:	linux-media@vger.kernel.org
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 64f38654f4e7..5825dda75f2c 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -402,6 +402,15 @@ config SENSORS_MAX20830
 	  This driver can also be built as a module. If so, the module will
 	  be called max20830.
 
+config SENSORS_MAX20860A
+	tristate "Analog Devices MAX20860A"
+	help
+	  If you say yes here you get hardware monitoring support for Analog
+	  Devices MAX20860A step-down converter.
+
+	  This driver can also be built as a module. If so, the module will
+	  be called max20860a.
+
 config SENSORS_MAX31785
 	tristate "Maxim MAX31785 and compatibles"
 	help
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index 1f2c73b71953..ffc05f493213 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -39,6 +39,7 @@ obj-$(CONFIG_SENSORS_MAX17616)	+= max17616.o
 obj-$(CONFIG_SENSORS_MAX20730)	+= max20730.o
 obj-$(CONFIG_SENSORS_MAX20751)	+= max20751.o
 obj-$(CONFIG_SENSORS_MAX20830)	+= max20830.o
+obj-$(CONFIG_SENSORS_MAX20860A)	+= max20860a.o
 obj-$(CONFIG_SENSORS_MAX31785)	+= max31785.o
 obj-$(CONFIG_SENSORS_MAX34440)	+= max34440.o
 obj-$(CONFIG_SENSORS_MAX8688)	+= max8688.o
diff --git a/drivers/hwmon/pmbus/max20860a.c b/drivers/hwmon/pmbus/max20860a.c
new file mode 100644
index 000000000000..5274147ad3d0
--- /dev/null
+++ b/drivers/hwmon/pmbus/max20860a.c
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Hardware monitoring driver for Analog Devices MAX20860A
+ *
+ * SPDX-FileCopyrightText: Copyright Hewlett Packard Enterprise Development LP
+ */
+
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "pmbus.h"
+
+static struct pmbus_driver_info max20860a_info = {
+	.pages = 1,
+	.format[PSC_VOLTAGE_IN] = linear,
+	.format[PSC_VOLTAGE_OUT] = linear,
+	.format[PSC_CURRENT_OUT] = linear,
+	.format[PSC_TEMPERATURE] = linear,
+	.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_VOUT |
+		PMBUS_HAVE_STATUS_VOUT |
+		PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT |
+		PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 |
+		PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_STATUS_INPUT,
+};
+
+static int max20860a_probe(struct i2c_client *client)
+{
+	return pmbus_do_probe(client, &max20860a_info);
+}
+
+static const struct i2c_device_id max20860a_id[] = {
+	{"max20860a"},
+	{}
+};
+MODULE_DEVICE_TABLE(i2c, max20860a_id);
+
+static const struct of_device_id max20860a_of_match[] = {
+	{ .compatible = "adi,max20860a" },
+	{ .compatible = "maxim,max20860a" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, max20860a_of_match);
+
+static struct i2c_driver max20860a_driver = {
+	.driver = {
+		.name = "max20860a",
+		.of_match_table = max20860a_of_match,
+	},
+	.probe = max20860a_probe,
+	.id_table = max20860a_id,
+};
+
+module_i2c_driver(max20860a_driver);
+
+MODULE_AUTHOR("Syed Arif <arif.syed@hpe.com>");
+MODULE_AUTHOR("Sanman Pradhan <psanman@juniper.net>");
+MODULE_DESCRIPTION("PMBus driver for Analog Devices MAX20860A");
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS("PMBUS");
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A
  2026-05-28 17:34 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add " Pradhan, Sanman
@ 2026-05-28 17:41   ` Conor Dooley
  2026-05-29  9:23     ` Nuno Sá
  2026-05-28 17:48   ` sashiko-bot
  1 sibling, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2026-05-28 17:41 UTC (permalink / raw)
  To: Pradhan, Sanman
  Cc: linux-hwmon@vger.kernel.org, linux@roeck-us.net, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net,
	skhan@linuxfoundation.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Syed, Arif, Sanman Pradhan

[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]

On Thu, May 28, 2026 at 05:34:36PM +0000, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@juniper.net>
> 
> Add devicetree binding documentation for the Analog Devices MAX20860A
> step-down DC-DC switching regulator with PMBus interface.
> 
> Both "adi,max20860a" and "maxim,max20860a" compatible strings are
> supported. The MAX20860A was originally manufactured by Maxim Integrated,
> now part of Analog Devices.
> 
> Signed-off-by: Sanman Pradhan <psanman@juniper.net>
> ---
> v2:
>   - Added allOf regulator.yaml reference and unevaluatedProperties

>   - Added "maxim,max20860a" as alternative compatible

No, please delete this.
I don't remember what the policy that ADI use for things that used to be
maxim products, but just pick one compatible for this device. I have a
feeling they want adi to always be used in these cases.

pw-bot: changes-requested

> 
>  .../bindings/hwmon/pmbus/adi,max20860a.yaml   | 47 ++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> new file mode 100644
> index 000000000000..f7eeb30f11b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,max20860a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX20860A Step-Down Converter
> +
> +maintainers:
> +  - Sanman Pradhan <psanman@juniper.net>
> +
> +description: |
> +  The MAX20860A is a fully integrated step-down DC-DC switching regulator
> +  with PMBus interface for monitoring input/output voltage, output current
> +  and temperature.
> +
> +  Datasheet: https://www.analog.com/en/products/max20860a.html
> +
> +allOf:
> +  - $ref: /schemas/regulator/regulator.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,max20860a
> +      - maxim,max20860a

And for future reference, please use fallback compatibles when dealing
with devices that have the same programming mode.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A
  2026-05-28 17:34 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add " Pradhan, Sanman
  2026-05-28 17:41   ` Conor Dooley
@ 2026-05-28 17:48   ` sashiko-bot
  1 sibling, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-05-28 17:48 UTC (permalink / raw)
  Cc: conor+dt, devicetree, linux-hwmon, robh

> From: Sanman Pradhan <psanman@juniper.net>
> 
> Add devicetree binding documentation for the Analog Devices MAX20860A
> step-down DC-DC switching regulator with PMBus interface.
> 
> Both "adi,max20860a" and "maxim,max20860a" compatible strings are
> supported. The MAX20860A was originally manufactured by Maxim Integrated,
> now part of Analog Devices.
> 
> Signed-off-by: Sanman Pradhan <psanman@juniper.net>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528173424.87503-1-sanman.pradhan@hpe.com?part=1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A
  2026-05-28 17:34 ` [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for " Pradhan, Sanman
@ 2026-05-28 18:04   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-05-28 18:04 UTC (permalink / raw)
  Cc: robh, linux-hwmon, devicetree, conor+dt

> From: Syed Arif <arif.syed@hpe.com>
> 
> Add a PMBus driver for the Analog Devices MAX20860A step-down DC-DC
> switching regulator. The MAX20860A provides monitoring of input/output
> voltage, output current, and temperature via the PMBus interface using
> linear data format.
> 
> Both "adi,max20860a" and "maxim,max20860a" compatible strings are
> supported for devicetree matching.
> 
> Signed-off-by: Syed Arif <arif.syed@hpe.com>
> Signed-off-by: Sanman Pradhan <psanman@juniper.net>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528173424.87503-1-sanman.pradhan@hpe.com?part=2


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A
  2026-05-28 17:41   ` Conor Dooley
@ 2026-05-29  9:23     ` Nuno Sá
  0 siblings, 0 replies; 7+ messages in thread
From: Nuno Sá @ 2026-05-29  9:23 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Pradhan, Sanman, linux-hwmon@vger.kernel.org, linux@roeck-us.net,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	corbet@lwn.net, skhan@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Syed, Arif, Sanman Pradhan

On Thu, May 28, 2026 at 06:41:31PM +0100, Conor Dooley wrote:
> On Thu, May 28, 2026 at 05:34:36PM +0000, Pradhan, Sanman wrote:
> > From: Sanman Pradhan <psanman@juniper.net>
> > 
> > Add devicetree binding documentation for the Analog Devices MAX20860A
> > step-down DC-DC switching regulator with PMBus interface.
> > 
> > Both "adi,max20860a" and "maxim,max20860a" compatible strings are
> > supported. The MAX20860A was originally manufactured by Maxim Integrated,
> > now part of Analog Devices.
> > 
> > Signed-off-by: Sanman Pradhan <psanman@juniper.net>
> > ---
> > v2:
> >   - Added allOf regulator.yaml reference and unevaluatedProperties
> 
> >   - Added "maxim,max20860a" as alternative compatible
> 
> No, please delete this.
> I don't remember what the policy that ADI use for things that used to be
> maxim products, but just pick one compatible for this device. I have a
> feeling they want adi to always be used in these cases.

Yes, adi should be the prefix.

- Nuno Sá

> 
> pw-bot: changes-requested
> 
> > 
> >  .../bindings/hwmon/pmbus/adi,max20860a.yaml   | 47 ++++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > new file mode 100644
> > index 000000000000..f7eeb30f11b3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,max20860a.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices MAX20860A Step-Down Converter
> > +
> > +maintainers:
> > +  - Sanman Pradhan <psanman@juniper.net>
> > +
> > +description: |
> > +  The MAX20860A is a fully integrated step-down DC-DC switching regulator
> > +  with PMBus interface for monitoring input/output voltage, output current
> > +  and temperature.
> > +
> > +  Datasheet: https://www.analog.com/en/products/max20860a.html
> > +
> > +allOf:
> > +  - $ref: /schemas/regulator/regulator.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max20860a
> > +      - maxim,max20860a
> 
> And for future reference, please use fallback compatibles when dealing
> with devices that have the same programming mode.
> 
> Cheers,
> Conor.



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-05-29  9:22 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 17:34 [PATCH v2 0/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A Pradhan, Sanman
2026-05-28 17:34 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add " Pradhan, Sanman
2026-05-28 17:41   ` Conor Dooley
2026-05-29  9:23     ` Nuno Sá
2026-05-28 17:48   ` sashiko-bot
2026-05-28 17:34 ` [PATCH v2 2/2] hwmon: (pmbus/max20860a) Add driver for " Pradhan, Sanman
2026-05-28 18:04   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox