From: Andi Shyti <andi.shyti@kernel.org>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Hongliang Wang <wanghongliang@loongson.cn>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
loongarch@lists.linux.dev, Huacai Chen <chenhuacai@loongson.cn>,
stable@vger.kernel.org
Subject: Re: [PATCH v6 2/2] i2c: ls2x: Add clocks property parsing and adjust bus speed
Date: Mon, 15 Jun 2026 10:33:06 +0200 [thread overview]
Message-ID: <ai-3ZiF7RL8J4lNP@zenone.zhora.eu> (raw)
In-Reply-To: <CAAhV-H5R9fPvUs7dvNrZAbXrGiWvE4YPkaca2nxnhgS3A+TVYw@mail.gmail.com>
...
> > >> Based on i2c bus reference clock(clock_a), i2c bus speed(clock_s)
> > >> and div, calculate the prcescale of i2c divider register. The
> > >> calculation formula is
> > >>
> > >> prcescale = (clock_a*10)/(div*clock_s)-1
> > >>
> > >> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> > > I think Huacai has not reviewed this patch, his review was only
> > > for patch 1. Am I right?
> > >
> > > Andi
> > Sorry, it was my mistake, I will send a new version later.
> Why? I really gave some suggestions in previous versions and you accepted.
> If an explicitly R-b is needed for each one, then
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Yes, no need to resend it. The R-b should be added only when it
is explicitly given; otherwise, I can't tell whether the reviewer
agrees with the changes.
Thanmks,
Andi
next prev parent reply other threads:[~2026-06-15 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 2:45 [PATCH v6 0/2] i2c: ls2x: Add clock- related properties and parsing Hongliang Wang
2026-06-08 2:45 ` [PATCH v6 1/2] dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties Hongliang Wang
2026-06-08 2:54 ` sashiko-bot
2026-06-08 2:45 ` [PATCH v6 2/2] i2c: ls2x: Add clocks property parsing and adjust bus speed Hongliang Wang
2026-06-08 2:57 ` sashiko-bot
2026-06-14 22:20 ` Andi Shyti
2026-06-15 1:27 ` Hongliang Wang
2026-06-15 2:28 ` Huacai Chen
2026-06-15 8:33 ` Andi Shyti [this message]
2026-06-16 22:55 ` Andi Shyti
2026-06-30 12:34 ` Hongliang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai-3ZiF7RL8J4lNP@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox