Re: [PATCH v4 4/4] arm64: dts: freescale: Add dual-channel LVDS overlay for TQMa8MPxS

[Frank Li <Frank.li@oss.nxp.com>]

On Mon, Jun 08, 2026 at 01:22:19PM +0200, Alexander Stein wrote:
> Hi Frank,
>
> Am Freitag, 5. Juni 2026, 18:47:07 CEST schrieb Frank Li:
> > On Wed, Jun 03, 2026 at 11:36:09AM +0200, Alexander Stein wrote:
> > > This adds an overlay for the supported LVDS display AUO G133HAN01.
> > > Configure the video PLL frequency to exactly match typical pixel clock of
> > > 141.200 MHz.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> >
> > Can you fix W=1 dtb build warnings?
>
> That would require to duplicate the setting from imx8mp.dtsi. Is this really
> intended?
>
> imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso:51.10-55.5: Warning (unit_address_vs_reg): /fragment@3/__overlay__/ports/port@1: node has a unit name, but no reg or ranges property
> imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso:57.10-61.5: Warning (unit_address_vs_reg): /fragment@3/__overlay__/ports/port@2: node has a unit name, but no reg or ranges property

Yes, add reg is not harmful. some overlay have reg and some have not.
So, I suggest fix it.

Frank

>
> IMHO this warning is not suitable for .dtbo, while it is for .dtb
> (with applied overlays). The .dtbo doesn't have all the information.
>
> Best reagrds
> Alexander
>
> > Frank
> >
> > > Changes in v4:
> > > * New to series v4
> > >
> > >  arch/arm64/boot/dts/freescale/Makefile        |  2 +
> > >  ...p-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso | 74 +++++++++++++++++++
> > >  2 files changed, 76 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > index dee2bea156740..3f466f102dc1d 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -385,8 +385,10 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtbo
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds-tm070jvhg33.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds-tm070jvhg33-imx219.dtb
> > >
> > > +imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01-dtbs += imx8mp-tqma8mpqs-mb-smarc-2.dtb imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtbo
> > >  imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33-dtbs += imx8mp-tqma8mpqs-mb-smarc-2.dtb imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33.dtbo
> > >  imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33-dtbs += imx8mp-tqma8mpqs-mb-smarc-2.dtb imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33.dtbo
> > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33.dtb
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso
> > > new file mode 100644
> > > index 0000000000000..9595cf4d43cd0
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso
> > > @@ -0,0 +1,74 @@
> > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > > +/*
> > > + * Copyright (c) 2025-2026 TQ-Systems GmbH <linux@ew.tq-group.com>,
> > > + * D-82229 Seefeld, Germany.
> > > + * Author: Martin Schmiedel
> > > + */
> > > +
> > > +/dts-v1/;
> > > +/plugin/;
> > > +
> > > +&backlight_lvds0 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&panel_lvds0 {
> > > +	compatible = "auo,g133han01";
> > > +	status = "okay";
> > > +
> > > +	ports {
> > > +		#address-cells = <1>;
> > > +		#size-cells = <0>;
> > > +
> > > +		port@0 {
> > > +			reg = <0>;
> > > +			dual-lvds-odd-pixels;
> > > +
> > > +			panel_in_lvds0: endpoint {
> > > +				remote-endpoint = <&ldb_lvds_ch0>;
> > > +			};
> > > +		};
> > > +
> > > +		port@1 {
> > > +			reg = <1>;
> > > +			dual-lvds-even-pixels;
> > > +
> > > +			panel_in_lvds1: endpoint {
> > > +				remote-endpoint = <&ldb_lvds_ch1>;
> > > +			};
> > > +		};
> > > +	};
> > > +};
> > > +
> > > +&lcdif2 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&lvds_bridge {
> > > +	status = "okay";
> > > +
> > > +	ports {
> > > +		port@1 {
> > > +			ldb_lvds_ch0: endpoint {
> > > +				remote-endpoint = <&panel_in_lvds0>;
> > > +			};
> > > +		};
> > > +
> > > +		port@2 {
> > > +			ldb_lvds_ch1: endpoint {
> > > +				remote-endpoint = <&panel_in_lvds1>;
> > > +			};
> > > +		};
> > > +	};
> > > +};
> > > +
> > > +// Update VIDEO_PLL1 frequency
> > > +&media_blk_ctrl {
> > > +	assigned-clock-rates = <500000000>, <200000000>,
> > > +			       <0>, <0>, <500000000>,
> > > +			       <988400000>;
> > > +};
> > > +
> > > +&pwm3 {
> > > +	status = "okay";
> > > +};
> > > --
> > > 2.54.0
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>
>