[PATCH 0/2] Add support for IPQ9650 CDSP remoteproc

[PATCH 0/2] Add support for IPQ9650 CDSP remoteproc

[Vignesh Viswanathan]

Add changes to enable IPQ9650 CDSP. This series adds new Devicetree
bindings for IPQ9650 PAS and also adds required changes in qcom_q6v5_pas
driver to support IPQ9650 CDSP remoteproc.

This series depends on [1], [2] and [3] to functionally bring up the CDSP
remoteproc on IPQ9650, but does not contain any compilation dependencies.

[1] https://lore.kernel.org/linux-arm-msm/20260518072856.22790-1-sumit.garg@kernel.org/
[2] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com/T/#t
[3] https://lore.kernel.org/linux-arm-msm/20260520-cdsp-power-v1-0-85eb9501a1cd@oss.qualcomm.com/T/#t

---
Vignesh Viswanathan (2):
      dt-bindings: remoteproc: Document IPQ9650 Compute DSP
      drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP

 .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
 drivers/remoteproc/qcom_q6v5_pas.c                 |  38 +++++-
 2 files changed, 172 insertions(+), 2 deletions(-)
---
base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c
change-id: 20260520-ipq9650-remoteproc-9aa8c6d05de3

Best regards,
-- 
Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>

[PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Vignesh Viswanathan]

Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
Peripheral Authentication Service (PAS). Unlike existing PAS
implementations, the IPQ9650 CDSP does not require power domains or an XO
clock, requiring a separate binding.

Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
---
 .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
 1 file changed, 136 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
new file mode 100644
index 000000000000..58b3a9352d87
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
@@ -0,0 +1,136 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9650-pas.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ9650 Peripheral Authentication Service
+
+maintainers:
+  - Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
+
+description:
+  Qualcomm IPQ9650 SoC Peripheral Authentication Service loads and boots
+  firmware on the Qualcomm CDSP Hexagon core.
+
+properties:
+  compatible:
+    enum:
+      - qcom,ipq9650-cdsp-pas
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 6
+
+  interrupt-names:
+    maxItems: 6
+
+  memory-region:
+    items:
+      - description: Memory region for main Firmware authentication
+      - description: Memory region for Devicetree Firmware authentication
+
+  firmware-name:
+    items:
+      - description: Firmware name of the Hexagon core
+      - description: Firmware name of the Hexagon Devicetree
+
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description: States used by the AP to signal the Hexagon core
+    items:
+      - description: Stop the modem
+
+  qcom,smem-state-names:
+    description: The names of the state bits used for SMP2P output
+    items:
+      - const: stop
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the CDSP.
+    unevaluatedProperties: false
+
+  smd-edge: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - memory-region
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,ipq9650-cdsp-pas
+    then:
+      properties:
+        interrupts:
+          items:
+            - description: Watchdog interrupt
+            - description: Fatal interrupt
+            - description: Ready interrupt
+            - description: Handover interrupt
+            - description: Stop acknowledge interrupt
+            - description: Shutdown acknowledge interrupt
+        interrupt-names:
+          items:
+            - const: wdog
+            - const: fatal
+            - const: ready
+            - const: handover
+            - const: stop-ack
+            - const: shutdown-ack
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/mailbox/qcom-ipcc.h>
+
+    remoteproc@24000000 {
+        compatible = "qcom,ipq9650-cdsp-pas";
+        reg = <0x24000000 0x10000>;
+
+        interrupts-extended = <&intc GIC_SPI 447 IRQ_TYPE_EDGE_RISING 0>,
+                              <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
+                              <&smp2p_cdsp_in 1 IRQ_TYPE_EDGE_RISING>,
+                              <&smp2p_cdsp_in 2 IRQ_TYPE_EDGE_RISING>,
+                              <&smp2p_cdsp_in 3 IRQ_TYPE_EDGE_RISING>,
+                              <&smp2p_cdsp_in 7 IRQ_TYPE_EDGE_RISING>;
+        interrupt-names = "wdog",
+                          "fatal",
+                          "ready",
+                          "handover",
+                          "stop-ack",
+                          "shutdown-ack";
+
+        memory-region = <&cdsp_mem>, <&cdsp_dtb_mem>;
+
+        qcom,smem-states = <&smp2p_cdsp_out 0>;
+        qcom,smem-state-names = "stop";
+
+        glink-edge {
+            interrupts-extended = <&ipcc IPCC_CLIENT_CDSP
+                                         IPCC_MPROC_SIGNAL_GLINK_QMP
+                                         IRQ_TYPE_EDGE_RISING>;
+            mboxes = <&ipcc IPCC_CLIENT_CDSP
+                            IPCC_MPROC_SIGNAL_GLINK_QMP>;
+
+            label = "cdsp";
+            qcom,remote-pid = <5>;
+
+            /* ... */
+        };
+    };

-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Rob Herring (Arm)]

On Wed, 20 May 2026 00:56:17 +0530, Vignesh Viswanathan wrote:
> Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
> Peripheral Authentication Service (PAS). Unlike existing PAS
> implementations, the IPQ9650 CDSP does not require power domains or an XO
> clock, requiring a separate binding.
> 
> Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
> ---
>  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
>  1 file changed, 136 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml: properties:qcom,smem-states:items:0: 'anyOf' conditional failed, one must be fixed:
	'items' is a required property
	'minItems' is a required property
	'maxItems' is a required property
	from schema $id: http://devicetree.org/meta-schemas/items.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260520-ipq9650-remoteproc-v1-1-542feb6efb2a@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Konrad Dybcio]

On 5/19/26 9:26 PM, Vignesh Viswanathan wrote:
> Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
> Peripheral Authentication Service (PAS). Unlike existing PAS
> implementations, the IPQ9650 CDSP does not require power domains or an XO
> clock, requiring a separate binding.

Your other patchset made me believe there should be a pair of required
supplies instead

Konrad

Re: [PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Vignesh Viswanathan]

On 5/20/2026 3:36 PM, Konrad Dybcio wrote:
> On 5/19/26 9:26 PM, Vignesh Viswanathan wrote:
>> Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
>> Peripheral Authentication Service (PAS). Unlike existing PAS
>> implementations, the IPQ9650 CDSP does not require power domains or an XO
>> clock, requiring a separate binding.
> 
> Your other patchset made me believe there should be a pair of required
> supplies instead

Yes, this requires a pair of supplies (cx/mx) but does not use the
"power-domains" property like other PAS implementations.

I'll rephrase this in a better way in next patchset.

Thanks,
Vignesh
> 
> Konrad

Re: [PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Krzysztof Kozlowski]

On Wed, May 20, 2026 at 12:56:17AM +0530, Vignesh Viswanathan wrote:
> Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
> Peripheral Authentication Service (PAS). Unlike existing PAS
> implementations, the IPQ9650 CDSP does not require power domains or an XO
> clock, requiring a separate binding.

You still need to reference common bindings, to get common properties
like smem-states.

Especially that you wrote this binding like it was including that ref.


> 
> Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
> ---
>  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
>  1 file changed, 136 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
> new file mode 100644
> index 000000000000..58b3a9352d87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
> @@ -0,0 +1,136 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9650-pas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm IPQ9650 Peripheral Authentication Service
> +
> +maintainers:
> +  - Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
> +
> +description:
> +  Qualcomm IPQ9650 SoC Peripheral Authentication Service loads and boots
> +  firmware on the Qualcomm CDSP Hexagon core.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,ipq9650-cdsp-pas
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 6
> +
> +  interrupt-names:
> +    maxItems: 6
> +
> +  memory-region:
> +    items:
> +      - description: Memory region for main Firmware authentication
> +      - description: Memory region for Devicetree Firmware authentication
> +
> +  firmware-name:
> +    items:
> +      - description: Firmware name of the Hexagon core
> +      - description: Firmware name of the Hexagon Devicetree
> +
> +  qcom,smem-states:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: States used by the AP to signal the Hexagon core
> +    items:
> +      - description: Stop the modem
> +
> +  qcom,smem-state-names:
> +    description: The names of the state bits used for SMP2P output
> +    items:
> +      - const: stop
> +
> +  glink-edge:
> +    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
> +    description:
> +      Qualcomm G-Link subnode which represents communication edge, channels
> +      and devices related to the CDSP.
> +    unevaluatedProperties: false
> +
> +  smd-edge: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - memory-region
> +  - qcom,smem-states
> +  - qcom,smem-state-names
> +
> +allOf:
> +  - if:

Pointless. Why do you need if? There are no other devices.

Best regards,
Krzysztof

[PATCH 2/2] drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP

[Vignesh Viswanathan]

Add the IPQ9650 CDSP remoteproc resource data and its corresponding device
tree compatible string to enable CDSP support on IPQ9650.

IPQ9650 CDSP requires an mx regulator supply in addition to the existing cx
and px supplies. Add mx-supply handling in the init, start, and handover
paths to support this configuration.

IPQ9650 CDSP does not use an XO clock, so make the XO clock optional by
switching to devm_clk_get_optional() to avoid probe failures on platforms
that do not provide it.

Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index da27d1d3c9da..0f1a0358fefb 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -72,6 +72,7 @@ struct qcom_pas {
 	struct clk *aggre2_clk;
 
 	struct regulator *cx_supply;
+	struct regulator *mx_supply;
 	struct regulator *px_supply;
 
 	struct device *proxy_pds[3];
@@ -299,10 +300,16 @@ static int qcom_pas_start(struct rproc *rproc)
 			goto disable_aggre2_clk;
 	}
 
+	if (pas->mx_supply) {
+		ret = regulator_enable(pas->mx_supply);
+		if (ret)
+			goto disable_cx_supply;
+	}
+
 	if (pas->px_supply) {
 		ret = regulator_enable(pas->px_supply);
 		if (ret)
-			goto disable_cx_supply;
+			goto disable_mx_supply;
 	}
 
 	if (pas->dtb_pas_id) {
@@ -365,6 +372,9 @@ static int qcom_pas_start(struct rproc *rproc)
 disable_px_supply:
 	if (pas->px_supply)
 		regulator_disable(pas->px_supply);
+disable_mx_supply:
+	if (pas->mx_supply)
+		regulator_disable(pas->mx_supply);
 disable_cx_supply:
 	if (pas->cx_supply)
 		regulator_disable(pas->cx_supply);
@@ -389,6 +399,8 @@ static void qcom_pas_handover(struct qcom_q6v5 *q6v5)
 
 	if (pas->px_supply)
 		regulator_disable(pas->px_supply);
+	if (pas->mx_supply)
+		regulator_disable(pas->mx_supply);
 	if (pas->cx_supply)
 		regulator_disable(pas->cx_supply);
 	clk_disable_unprepare(pas->aggre2_clk);
@@ -533,7 +545,7 @@ static const struct rproc_ops qcom_pas_minidump_ops = {
 
 static int qcom_pas_init_clock(struct qcom_pas *pas)
 {
-	pas->xo = devm_clk_get(pas->dev, "xo");
+	pas->xo = devm_clk_get_optional(pas->dev, "xo");
 	if (IS_ERR(pas->xo))
 		return dev_err_probe(pas->dev, PTR_ERR(pas->xo),
 				     "failed to get xo clock");
@@ -559,6 +571,14 @@ static int qcom_pas_init_regulator(struct qcom_pas *pas)
 	if (pas->cx_supply)
 		regulator_set_load(pas->cx_supply, 100000);
 
+	pas->mx_supply = devm_regulator_get_optional(pas->dev, "mx");
+	if (IS_ERR(pas->mx_supply)) {
+		if (PTR_ERR(pas->mx_supply) == -ENODEV)
+			pas->mx_supply = NULL;
+		else
+			return PTR_ERR(pas->mx_supply);
+	}
+
 	pas->px_supply = devm_regulator_get_optional(pas->dev, "px");
 	if (IS_ERR(pas->px_supply)) {
 		if (PTR_ERR(pas->px_supply) == -ENODEV)
@@ -1530,8 +1550,22 @@ static const struct qcom_pas_data sm8750_mpss_resource = {
 	.region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
 };
 
+static const struct qcom_pas_data ipq9650_cdsp_resource = {
+	.crash_reason_smem = 601,
+	.firmware_name = "cdsp.mbn",
+	.dtb_firmware_name = "cdsp_dtb.mbn",
+	.pas_id = 18,
+	.dtb_pas_id = 0x25,
+	.auto_boot = false,
+	.load_state = "cdsp",
+	.ssr_name = "cdsp",
+	.sysmon_name = "cdsp",
+	.ssctl_id = 0x17,
+};
+
 static const struct of_device_id qcom_pas_of_match[] = {
 	{ .compatible = "qcom,eliza-adsp-pas", .data = &sm8550_adsp_resource },
+	{ .compatible = "qcom,ipq9650-cdsp-pas", .data = &ipq9650_cdsp_resource },
 	{ .compatible = "qcom,milos-adsp-pas", .data = &sm8550_adsp_resource },
 	{ .compatible = "qcom,milos-cdsp-pas", .data = &milos_cdsp_resource },
 	{ .compatible = "qcom,milos-mpss-pas", .data = &sm8450_mpss_resource },

-- 
2.43.0

Re: [PATCH 0/2] Add support for IPQ9650 CDSP remoteproc

[Bjorn Andersson]

On Wed, May 20, 2026 at 12:56:16AM +0530, Vignesh Viswanathan wrote:
> Add changes to enable IPQ9650 CDSP. This series adds new Devicetree
> bindings for IPQ9650 PAS and also adds required changes in qcom_q6v5_pas
> driver to support IPQ9650 CDSP remoteproc.
> 
> This series depends on [1], [2] and [3] to functionally bring up the CDSP
> remoteproc on IPQ9650, but does not contain any compilation dependencies.
> 
> [1] https://lore.kernel.org/linux-arm-msm/20260518072856.22790-1-sumit.garg@kernel.org/

I'm not able to determine why this is a dependency from cover letter,
commit messages, or the patches. If you have a dependency on this series
this isn't your typical PAS-based subsystem, so describing what it is in
the cover letter would be wonderful.

> [2] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com/T/#t
> [3] https://lore.kernel.org/linux-arm-msm/20260520-cdsp-power-v1-0-85eb9501a1cd@oss.qualcomm.com/T/#t

#3 is a fundamental part of the addition of this remoteproc driver and
the solution would be better reviewed as a whole - so you should send
the two parts in the same series.

PS. If you run "git log --oneline" you will see that there shouldn't be
a "drivers:" prefix in your subject.

Regards,
Bjorn

> 
> ---
> Vignesh Viswanathan (2):
>       dt-bindings: remoteproc: Document IPQ9650 Compute DSP
>       drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP
> 
>  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
>  drivers/remoteproc/qcom_q6v5_pas.c                 |  38 +++++-
>  2 files changed, 172 insertions(+), 2 deletions(-)
> ---
> base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c
> change-id: 20260520-ipq9650-remoteproc-9aa8c6d05de3
> 
> Best regards,
> -- 
> Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
> 

Re: [PATCH 0/2] Add support for IPQ9650 CDSP remoteproc

[Sumit Garg]

Hi Bjorn,

On Mon, Jun 08, 2026 at 09:59:35PM -0500, Bjorn Andersson wrote:
> On Wed, May 20, 2026 at 12:56:16AM +0530, Vignesh Viswanathan wrote:
> > Add changes to enable IPQ9650 CDSP. This series adds new Devicetree
> > bindings for IPQ9650 PAS and also adds required changes in qcom_q6v5_pas
> > driver to support IPQ9650 CDSP remoteproc.
> > 
> > This series depends on [1], [2] and [3] to functionally bring up the CDSP
> > remoteproc on IPQ9650, but does not contain any compilation dependencies.
> > 
> > [1] https://lore.kernel.org/linux-arm-msm/20260518072856.22790-1-sumit.garg@kernel.org/
> 
> I'm not able to determine why this is a dependency from cover letter,
> commit messages, or the patches. If you have a dependency on this series
> this isn't your typical PAS-based subsystem, so describing what it is in
> the cover letter would be wonderful.

Probably the cover letter didn't mention that this IPQ chipset runs
OP-TEE/TF-A as the TZ, that's why it's unclear. Without the OP-TEE PAS
series, the CDSP can't be brought up on this chipset. Similar would be
the case for all other Qcom chipsets supporting OP-TEE.

Not sure if there is anything missing for the OP-TEE PAS series to be
picked up. Surely we missed the current merge window but hopeful you
will be able to give some attention to that series for the next merge
window.

-Sumit

> 
> > [2] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com/T/#t
> > [3] https://lore.kernel.org/linux-arm-msm/20260520-cdsp-power-v1-0-85eb9501a1cd@oss.qualcomm.com/T/#t
> 
> #3 is a fundamental part of the addition of this remoteproc driver and
> the solution would be better reviewed as a whole - so you should send
> the two parts in the same series.
> 
> PS. If you run "git log --oneline" you will see that there shouldn't be
> a "drivers:" prefix in your subject.
> 
> Regards,
> Bjorn
> 
> > 
> > ---
> > Vignesh Viswanathan (2):
> >       dt-bindings: remoteproc: Document IPQ9650 Compute DSP
> >       drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP
> > 
> >  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
> >  drivers/remoteproc/qcom_q6v5_pas.c                 |  38 +++++-
> >  2 files changed, 172 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c
> > change-id: 20260520-ipq9650-remoteproc-9aa8c6d05de3
> > 
> > Best regards,
> > -- 
> > Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
> > 

Re: [PATCH 0/2] Add support for IPQ9650 CDSP remoteproc

[Vignesh Viswanathan]

On 6/9/2026 8:29 AM, Bjorn Andersson wrote:
> On Wed, May 20, 2026 at 12:56:16AM +0530, Vignesh Viswanathan wrote:
>> Add changes to enable IPQ9650 CDSP. This series adds new Devicetree
>> bindings for IPQ9650 PAS and also adds required changes in qcom_q6v5_pas
>> driver to support IPQ9650 CDSP remoteproc.
>>
>> This series depends on [1], [2] and [3] to functionally bring up the CDSP
>> remoteproc on IPQ9650, but does not contain any compilation dependencies.
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20260518072856.22790-1-sumit.garg@kernel.org/
> 
> I'm not able to determine why this is a dependency from cover letter,
> commit messages, or the patches. If you have a dependency on this series
> this isn't your typical PAS-based subsystem, so describing what it is in
> the cover letter would be wonderful.

Ack, will describe it better in the next version.

> 
>> [2] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com/T/#t
>> [3] https://lore.kernel.org/linux-arm-msm/20260520-cdsp-power-v1-0-85eb9501a1cd@oss.qualcomm.com/T/#t
> 
> #3 is a fundamental part of the addition of this remoteproc driver and
> the solution would be better reviewed as a whole - so you should send
> the two parts in the same series.

Sure, as mentioned in the cdsp power thread, I'll make this a separate 
driver instead of adding it to the standard PAS driver.

> 
> PS. If you run "git log --oneline" you will see that there shouldn't be
> a "drivers:" prefix in your subject.

Ack.

Thanks,
Vignesh
> 
> Regards,
> Bjorn
> 
>>
>> ---
>> Vignesh Viswanathan (2):
>>       dt-bindings: remoteproc: Document IPQ9650 Compute DSP
>>       drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP
>>
>>  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
>>  drivers/remoteproc/qcom_q6v5_pas.c                 |  38 +++++-
>>  2 files changed, 172 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c
>> change-id: 20260520-ipq9650-remoteproc-9aa8c6d05de3
>>
>> Best regards,
>> -- 
>> Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
>>