Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikhil Gautam <nikhilgtr@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	u.kleine-koenig@baylibre.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] iio: magnetometer: add support for Melexis MLX90393
Date: Mon, 29 Jun 2026 16:53:34 +0300	[thread overview]
Message-ID: <akJ43m8p06Vb5FE_@ashevche-desk.local> (raw)
In-Reply-To: <20260627095519.8377-1-nikhilgtr@gmail.com>

On Sat, Jun 27, 2026 at 03:25:17PM +0530, Nikhil Gautam wrote:
> Hi,
> 
> This series adds initial Industrial I/O subsystem support for the
> Melexis MLX90393 3-axis magnetometer and temperature sensor.
> 
> The MLX90393 supports both I2C and SPI interfaces. This series
> implements support for the I2C interface while keeping the driver
> structure transport-independent to simplify future SPI support.
> 
> The device uses a command-based communication protocol rather than a
> conventional register-addressed interface. A small transport abstraction
> layer is therefore used instead of regmap to share the common sensor
> logic between the current I2C implementation and future SPI support.
> 
> Currently supported features:
> 
> * Raw magnetic field measurements for X/Y/Z axes
> * Raw temperature measurements
> * Configurable gain/scale selection
> * Configurable oversampling ratio
> * Direct mode operation through the IIO subsystem
> * I2C interface support
> 
> The driver has been tested on Raspberry Pi 5 hardware using an
> MLX90393 sensor connected over I2C. Magnetic field and temperature
> measurements were verified through the IIO sysfs interface.

...

> v3: https://lore.kernel.org/linux-iio/20260627005843.7786-3-nikhilgtr@gmail.com/T/#u
> v2: https://lore.kernel.org/linux-iio/20260618160141.11409-1-nikhilgtr@gmail.com/T/#t
> v1: https://lore.kernel.org/linux-iio/20260510191010.155380-1-nikhilgtr@gmail.com/

No, do not issue versions so often, especially for a new driver. *Minimum* of
one week must be between two versions.

NAK. Please, go to v3, study, address, and settle down the comments given there.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-06-29 13:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-27  9:55 [PATCH v4 0/2] iio: magnetometer: add support for Melexis MLX90393 Nikhil Gautam
2026-06-27  9:55 ` [PATCH v4 1/2] dt-bindings: iio: magnetometer: add " Nikhil Gautam
2026-06-28 15:12   ` Krzysztof Kozlowski
2026-06-27  9:55 ` [PATCH v4 2/2] iio: magnetometer: add support for " Nikhil Gautam
2026-06-27 10:06   ` sashiko-bot
2026-06-27 19:49   ` David Lechner
2026-07-01  0:59   ` Jonathan Cameron
2026-06-29 13:53 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akJ43m8p06Vb5FE_@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhilgtr@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox