* [PATCH v3 0/2] media: Add Himax HM1092 mono NIR sensor driver
@ 2026-07-02 7:34 Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh R
0 siblings, 2 replies; 5+ messages in thread
From: Ramshouriesh R @ 2026-07-02 7:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Hans Verkuil, Bryan O'Donoghue, Vladimir Zapolskiy,
linux-media, devicetree, linux-kernel, Ramshouriesh R,
Conor Dooley
This adds a V4L2 subdev driver and DT binding for the Himax HM1092, a
1 megapixel monochrome near-infrared image sensor. On laptops it sits
behind the IR camera used for face unlock. It speaks a single MIPI CSI-2
data lane and outputs 10-bit RAW at 560x360.
The driver exposes that one native mode, a test pattern control and the
standard fwnode properties (orientation, rotation). It has been tested on
real hardware (an ASUS Zenbook A14): the sensor probes, streams, and the
on-chip test pattern comes through the full CSI-2 pipeline.
The sensor driver and its binding are SoC-neutral, so they are sent on
their own through the media tree. The board-level device tree and PHY
work that wires this camera up on the ASUS Zenbook A14 will be sent as
its own series.
Signed-off-by: Ramshouriesh R <rshouriesh@gmail.com>
---
Changes in v3:
- dt-bindings: add the Reviewed-by tag from Conor Dooley.
- hm1092: initialize RAW colorimetry fields in the pad format helper so
userspace values cannot leak into subdevice state.
- hm1092: return -ENXIO when the required firmware graph endpoint is
absent instead of deferring probe indefinitely.
- Link to v2: https://patch.msgid.link/20260702-hm1092-driver-v2-0-4f9f369d6a48@gmail.com
Changes in v2:
- hm1092: use pm_ptr() instead of pm_sleep_ptr() for the dev_pm_ops
pointer. The ops come from DEFINE_RUNTIME_DEV_PM_OPS(), so gating them
on CONFIG_PM_SLEEP dropped runtime PM on a CONFIG_PM=y, PM_SLEEP=n
build.
- hm1092: free the control handler on the error paths in
hm1092_init_controls(); the fwnode-parse and ctrl_hdlr->error returns
leaked the handler.
- Link to v1: https://patch.msgid.link/20260701-hm1092-driver-v1-0-d1bd81e233b5@gmail.com
To: Ramshouriesh R <rshouriesh@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Ramshouriesh R (2):
media: dt-bindings: Add Himax HM1092 NIR sensor
media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver
.../bindings/media/i2c/himax,hm1092.yaml | 107 +++
MAINTAINERS | 7 +
drivers/media/i2c/Kconfig | 11 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/hm1092.c | 794 +++++++++++++++++++++
5 files changed, 920 insertions(+)
---
base-commit: be5c93fa674f0fc3c8f359c2143abce6bbb422e6
change-id: 20260618-hm1092-driver-a6f2aaddf201
Best regards,
--
Ramshouriesh R <rshouriesh@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor
2026-07-02 7:34 [PATCH v3 0/2] media: Add Himax HM1092 mono NIR sensor driver Ramshouriesh R
@ 2026-07-02 7:34 ` Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh R
1 sibling, 0 replies; 5+ messages in thread
From: Ramshouriesh R @ 2026-07-02 7:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Hans Verkuil, Bryan O'Donoghue, Vladimir Zapolskiy,
linux-media, devicetree, linux-kernel, Ramshouriesh R,
Conor Dooley
Add a dt-binding schema for the Himax HM1092, a 1 megapixel monochrome
near-infrared CMOS image sensor used as the face-authentication IR
camera on laptops. The sensor streams 10-bit RAW over a single MIPI
CSI-2 data lane.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Ramshouriesh R <rshouriesh@gmail.com>
---
.../bindings/media/i2c/himax,hm1092.yaml | 107 +++++++++++++++++++++
1 file changed, 107 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml
new file mode 100644
index 000000000000..d324569836af
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/himax,hm1092.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HM1092 Monochrome NIR Sensor
+
+maintainers:
+ - Ramshouriesh R <rshouriesh@gmail.com>
+
+description:
+ The Himax HM1092 is a 1 megapixel monochrome near-infrared CMOS image
+ sensor with a MIPI CSI-2 interface, commonly used as the IR camera for
+ face authentication on laptops. It outputs 10-bit RAW over a single
+ MIPI CSI-2 data lane.
+
+allOf:
+ - $ref: /schemas/media/video-interface-devices.yaml#
+
+properties:
+ compatible:
+ const: himax,hm1092
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ avdd-supply:
+ description: Analogue circuit voltage supply.
+
+ dovdd-supply:
+ description: I/O circuit voltage supply.
+
+ dvdd-supply:
+ description: Digital circuit voltage supply.
+
+ reset-gpios:
+ maxItems: 1
+ description: Active low GPIO connected to the XSHUTDOWN pad.
+
+ port:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ maxItems: 1
+
+ required:
+ - data-lanes
+ - link-frequencies
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - avdd-supply
+ - dovdd-supply
+ - dvdd-supply
+ - port
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@24 {
+ compatible = "himax,hm1092";
+ reg = <0x24>;
+
+ reset-gpios = <&tlmm 109 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&cam_ir_default>;
+
+ clocks = <&camcc 1>;
+ assigned-clocks = <&camcc 1>;
+ assigned-clock-rates = <24000000>;
+
+ orientation = <0>;
+
+ avdd-supply = <&vreg_l7m_2p9>;
+ dvdd-supply = <&vreg_l7m_2p9>;
+ dovdd-supply = <&vreg_l4m_1p8>;
+
+ port {
+ hm1092_ep: endpoint {
+ data-lanes = <1>;
+ link-frequencies = /bits/ 64 <400000000>;
+ remote-endpoint = <&camss_csiphy0_inep>;
+ };
+ };
+ };
+ };
+...
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver
2026-07-02 7:34 [PATCH v3 0/2] media: Add Himax HM1092 mono NIR sensor driver Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor Ramshouriesh R
@ 2026-07-02 7:34 ` Ramshouriesh R
2026-07-04 13:57 ` Sakari Ailus
1 sibling, 1 reply; 5+ messages in thread
From: Ramshouriesh R @ 2026-07-02 7:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Hans Verkuil, Bryan O'Donoghue, Vladimir Zapolskiy,
linux-media, devicetree, linux-kernel, Ramshouriesh R
Add a V4L2 subdev driver for the Himax HM1092, a 1 megapixel monochrome
near-infrared image sensor with a single-lane MIPI CSI-2 interface,
typically used as the face-authentication IR camera on laptops.
The driver supports the sensor's native 560x360 10-bit mono mode, a test
pattern control and the standard fwnode properties (orientation,
rotation).
Signed-off-by: Ramshouriesh R <rshouriesh@gmail.com>
---
MAINTAINERS | 7 +
drivers/media/i2c/Kconfig | 11 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/hm1092.c | 794 +++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 813 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5e11dd741d9f..4d9a4991ca2b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11652,6 +11652,13 @@ L: linux-kernel@vger.kernel.org
S: Maintained
F: drivers/misc/hisi_hikey_usb.c
+HIMAX HM1092 SENSOR DRIVER
+M: Ramshouriesh R <rshouriesh@gmail.com>
+L: linux-media@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml
+F: drivers/media/i2c/hm1092.c
+
HIMAX HX83112B TOUCHSCREEN SUPPORT
M: Job Noorman <job@noorman.info>
L: linux-input@vger.kernel.org
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 5d173e0ecf42..f94621edbe1a 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -137,6 +137,17 @@ config VIDEO_HI847
To compile this driver as a module, choose M here: the
module will be called hi847.
+config VIDEO_HM1092
+ tristate "Himax HM1092 sensor support"
+ select V4L2_CCI_I2C
+ help
+ This is a Video4Linux2 sensor driver for the Himax HM1092
+ monochrome near-infrared CMOS image sensor, used as the
+ face-authentication IR camera on laptops.
+
+ To compile this driver as a module, choose M here: the
+ module will be called hm1092.
+
config VIDEO_IMX111
tristate "Sony IMX111 sensor support"
select V4L2_CCI_I2C
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index e45359efe0e4..6507c173d0fa 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -45,6 +45,7 @@ obj-$(CONFIG_VIDEO_GC2145) += gc2145.o
obj-$(CONFIG_VIDEO_HI556) += hi556.o
obj-$(CONFIG_VIDEO_HI846) += hi846.o
obj-$(CONFIG_VIDEO_HI847) += hi847.o
+obj-$(CONFIG_VIDEO_HM1092) += hm1092.o
obj-$(CONFIG_VIDEO_I2C) += video-i2c.o
obj-$(CONFIG_VIDEO_IMX111) += imx111.o
obj-$(CONFIG_VIDEO_IMX208) += imx208.o
diff --git a/drivers/media/i2c/hm1092.c b/drivers/media/i2c/hm1092.c
new file mode 100644
index 000000000000..e668bc59e1fc
--- /dev/null
+++ b/drivers/media/i2c/hm1092.c
@@ -0,0 +1,794 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Himax HM1092 monochrome near-infrared image sensor driver.
+ */
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
+#include <media/v4l2-cci.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-fwnode.h>
+
+#define HM1092_LINK_FREQ_400MHZ 400000000ULL
+#define HM1092_MCLK 24000000
+#define HM1092_BITS_PER_SAMPLE 10
+
+#define HM1092_REG_STREAM CCI_REG8(0x0100)
+
+struct hm1092_reg {
+ u16 address;
+ u8 val;
+};
+
+static const struct hm1092_reg hm1092_init_regs[] = {
+ { 0x0103, 0x00 },
+ { 0x030a, 0x05 },
+ { 0x030d, 0x0c },
+ { 0x030f, 0x5a },
+ { 0x0307, 0x00 },
+ { 0x0309, 0x01 },
+ { 0x0387, 0x01 },
+ { 0x0100, 0x02 },
+ { 0x4265, 0x02 },
+ { 0x4002, 0x2b },
+ { 0x4001, 0x00 },
+ { 0x0101, 0x03 },
+ { 0x4024, 0x40 },
+ { 0x0203, 0xbe },
+ { 0x0202, 0x00 },
+ { 0x0341, 0xee },
+ { 0x0340, 0x02 },
+ { 0x0343, 0x50 },
+ { 0x0342, 0x06 },
+ { 0x0345, 0x30 },
+ { 0x0344, 0x00 },
+ { 0x0349, 0xad },
+ { 0x0348, 0x04 },
+ { 0x0347, 0x08 },
+ { 0x0346, 0x00 },
+ { 0x034b, 0xd5 },
+ { 0x034a, 0x02 },
+ { 0x5015, 0xb3 },
+ { 0x0350, 0x53 },
+ { 0x0361, 0x30 },
+ { 0x0360, 0x00 },
+ { 0x034d, 0x30 },
+ { 0x034c, 0x02 },
+ { 0x034f, 0x68 },
+ { 0x034e, 0x01 },
+ { 0x0390, 0x03 },
+ { 0x0383, 0x00 },
+ { 0x0387, 0x10 },
+ { 0x50dd, 0x01 },
+ { 0x50cb, 0x21 },
+ { 0x5005, 0x28 },
+ { 0x5004, 0x40 },
+ { 0x5007, 0x28 },
+ { 0x5006, 0x40 },
+ { 0x5011, 0x00 },
+ { 0x501d, 0x4c },
+ { 0x5013, 0x03 },
+ { 0x4131, 0x01 },
+ { 0x5283, 0x03 },
+ { 0x5282, 0xff },
+ { 0x5010, 0x20 },
+ { 0x4132, 0x20 },
+ { 0x50d5, 0xe0 },
+ { 0x50d7, 0x12 },
+ { 0x50bb, 0x14 },
+ { 0x50b7, 0x00 },
+ { 0x50b9, 0xff },
+ { 0x50b8, 0x70 },
+ { 0x50ba, 0xff },
+ { 0x50fa, 0x02 },
+ { 0x50b4, 0x00 },
+ { 0x50a2, 0x0b },
+ { 0x50ad, 0x07 },
+ { 0x50ac, 0x24 },
+ { 0x50af, 0x40 },
+ { 0x50ae, 0x20 },
+ { 0x50ab, 0x07 },
+ { 0x50aa, 0x22 },
+ { 0x50a7, 0x00 },
+ { 0x50a6, 0x00 },
+ { 0x5099, 0x11 },
+ { 0x509b, 0x03 },
+ { 0x50b3, 0x04 },
+ { 0x50a0, 0x30 },
+ { 0x5098, 0x00 },
+ { 0x52f2, 0x53 },
+ { 0x5209, 0x0c },
+ { 0x5216, 0x02 },
+ { 0x521e, 0x01 },
+ { 0x50e8, 0x00 },
+ { 0x5200, 0x60 },
+ { 0x5202, 0x00 },
+ { 0x5201, 0x80 },
+ { 0x5203, 0x01 },
+ { 0x5208, 0x0b },
+ { 0x520d, 0x40 },
+ { 0x520c, 0x15 },
+ { 0x5215, 0x04 },
+ { 0x50ea, 0x74 },
+ { 0x5214, 0x28 },
+ { 0x5218, 0x07 },
+ { 0x5217, 0x01 },
+ { 0x0310, 0x00 },
+ { 0x4b31, 0x06 },
+ { 0x4b3b, 0x02 },
+ { 0x4b45, 0x01 },
+ { 0x4b44, 0x0c },
+ { 0x4b47, 0x00 },
+ { 0x5101, 0x13 },
+ { 0x5100, 0x03 },
+ { 0x5103, 0x33 },
+ { 0x5102, 0x23 },
+ { 0x5105, 0x42 },
+ { 0x5104, 0x43 },
+ { 0x5106, 0x40 },
+ { 0x5119, 0x00 },
+ { 0x5118, 0x00 },
+ { 0x511b, 0x00 },
+ { 0x511a, 0x00 },
+ { 0x511d, 0x00 },
+ { 0x511c, 0x00 },
+ { 0x511e, 0x00 },
+ { 0x5131, 0x23 },
+ { 0x5130, 0x13 },
+ { 0x5133, 0x43 },
+ { 0x5132, 0x33 },
+ { 0x5135, 0x40 },
+ { 0x5134, 0x42 },
+ { 0x5136, 0x40 },
+ { 0x5149, 0x01 },
+ { 0x5148, 0x01 },
+ { 0x514b, 0x01 },
+ { 0x514a, 0x01 },
+ { 0x514d, 0x01 },
+ { 0x514c, 0x01 },
+ { 0x514e, 0x01 },
+ { 0x51c0, 0x00 },
+ { 0x51c6, 0x00 },
+ { 0x51cc, 0x00 },
+ { 0x51d2, 0x00 },
+ { 0x51d8, 0x00 },
+ { 0x51c1, 0x81 },
+ { 0x51c7, 0x81 },
+ { 0x51cd, 0x81 },
+ { 0x51d3, 0x81 },
+ { 0x51d9, 0x81 },
+ { 0x51c2, 0xec },
+ { 0x51c8, 0xec },
+ { 0x51ce, 0xec },
+ { 0x51d4, 0xec },
+ { 0x51da, 0xec },
+ { 0x51c3, 0x00 },
+ { 0x51c9, 0x00 },
+ { 0x51cf, 0x00 },
+ { 0x51d5, 0x00 },
+ { 0x51db, 0x00 },
+ { 0x51c4, 0x55 },
+ { 0x51ca, 0x55 },
+ { 0x51d0, 0x54 },
+ { 0x51d6, 0x53 },
+ { 0x51dc, 0x53 },
+ { 0x51c5, 0x44 },
+ { 0x51cb, 0x24 },
+ { 0x51d1, 0x24 },
+ { 0x51d7, 0x14 },
+ { 0x51dd, 0x14 },
+ { 0x51e0, 0x09 },
+ { 0x51e2, 0x04 },
+ { 0x51e4, 0x08 },
+ { 0x51e6, 0x08 },
+ { 0x51e1, 0x03 },
+ { 0x51e3, 0x03 },
+ { 0x51e5, 0x07 },
+ { 0x51e8, 0x04 },
+ { 0x51e7, 0x07 },
+ { 0x51e9, 0x46 },
+ { 0x51eb, 0x62 },
+ { 0x51ea, 0x43 },
+ { 0x51ed, 0x00 },
+ { 0x51ec, 0x61 },
+ { 0x51ee, 0x00 },
+ { 0x5206, 0x80 },
+ { 0x3110, 0x02 },
+ { 0x3704, 0x02 },
+ { 0x3704, 0x02 },
+ { 0x4b20, 0x9e },
+ { 0x4b18, 0x00 },
+ { 0x4b3e, 0x00 },
+ { 0x4b0e, 0x0e },
+ { 0x4800, 0xac },
+ { 0x0104, 0x01 },
+ { 0x0104, 0x00 },
+ { 0x4801, 0xae },
+ { 0x0000, 0x00 },
+ { 0x0037, 0x30 },
+};
+
+static const struct hm1092_reg hm1092_start_streaming[] = {
+ { 0x0100, 0x01 },
+};
+
+static const struct hm1092_reg hm1092_test_pattern_mode0[] = {
+ { 0x0601, 0x00 },
+};
+
+static const struct hm1092_reg hm1092_test_pattern_mode1[] = {
+ { 0x0601, 0x01 },
+};
+
+static const struct hm1092_reg hm1092_test_pattern_mode2[] = {
+ { 0x0601, 0x02 },
+};
+
+static const struct hm1092_reg hm1092_test_pattern_mode3[] = {
+ { 0x0601, 0x03 },
+};
+
+static const struct hm1092_reg hm1092_test_pattern_mode4[] = {
+ { 0x0601, 0x04 },
+};
+
+struct hm1092_mode {
+ u32 width;
+ u32 height;
+ u32 hts;
+ u32 vts;
+};
+
+static const struct hm1092_mode hm1092_mode_560x360 = {
+ .width = 560,
+ .height = 360,
+ .hts = 0x0650,
+ .vts = 0x02ee,
+};
+
+static const char * const hm1092_supply_names[] = {
+ "dovdd",
+ "avdd",
+ "dvdd",
+};
+
+static const char * const hm1092_test_pattern_menu[] = {
+ "Disabled",
+ "Mode 1",
+ "Mode 2",
+ "Mode 3",
+ "Mode 4",
+};
+
+static const s64 hm1092_link_freq_menu[] = {
+ HM1092_LINK_FREQ_400MHZ,
+};
+
+struct hm1092 {
+ struct device *dev;
+ struct v4l2_subdev sd;
+ struct media_pad pad;
+ struct v4l2_ctrl_handler ctrl_handler;
+ struct regmap *regmap;
+ struct clk *img_clk;
+ struct gpio_desc *reset;
+ struct regulator_bulk_data supplies[ARRAY_SIZE(hm1092_supply_names)];
+ struct v4l2_ctrl *link_freq;
+ struct v4l2_ctrl *pixel_rate;
+ struct v4l2_ctrl *hblank;
+ struct v4l2_ctrl *vblank;
+ u8 mipi_lanes;
+};
+
+static inline struct hm1092 *to_hm1092(struct v4l2_subdev *sd)
+{
+ return container_of(sd, struct hm1092, sd);
+}
+
+static int hm1092_write_regs(struct hm1092 *hm1092,
+ const struct hm1092_reg *regs, unsigned int len)
+{
+ unsigned int i;
+ int ret = 0;
+
+ for (i = 0; i < len; i++) {
+ cci_write(hm1092->regmap, CCI_REG8(regs[i].address),
+ regs[i].val, &ret);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
+static int hm1092_set_test_pattern(struct hm1092 *hm1092, int pattern)
+{
+ switch (pattern) {
+ case 0:
+ return hm1092_write_regs(hm1092, hm1092_test_pattern_mode0,
+ ARRAY_SIZE(hm1092_test_pattern_mode0));
+ case 1:
+ return hm1092_write_regs(hm1092, hm1092_test_pattern_mode1,
+ ARRAY_SIZE(hm1092_test_pattern_mode1));
+ case 2:
+ return hm1092_write_regs(hm1092, hm1092_test_pattern_mode2,
+ ARRAY_SIZE(hm1092_test_pattern_mode2));
+ case 3:
+ return hm1092_write_regs(hm1092, hm1092_test_pattern_mode3,
+ ARRAY_SIZE(hm1092_test_pattern_mode3));
+ case 4:
+ return hm1092_write_regs(hm1092, hm1092_test_pattern_mode4,
+ ARRAY_SIZE(hm1092_test_pattern_mode4));
+ default:
+ return -EINVAL;
+ }
+}
+
+static int hm1092_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+ struct hm1092 *hm1092 = container_of(ctrl->handler, struct hm1092,
+ ctrl_handler);
+ int ret;
+
+ /*
+ * The control value is cached by the framework and (re)applied from
+ * hm1092_enable_streams() once the device is powered up for streaming.
+ */
+ if (pm_runtime_get_if_in_use(hm1092->dev) == 0)
+ return 0;
+
+ switch (ctrl->id) {
+ case V4L2_CID_TEST_PATTERN:
+ ret = hm1092_set_test_pattern(hm1092, ctrl->val);
+ break;
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ pm_runtime_put(hm1092->dev);
+
+ return ret;
+}
+
+static const struct v4l2_ctrl_ops hm1092_ctrl_ops = {
+ .s_ctrl = hm1092_set_ctrl,
+};
+
+static int hm1092_init_controls(struct hm1092 *hm1092)
+{
+ struct v4l2_ctrl_handler *ctrl_hdlr = &hm1092->ctrl_handler;
+ const struct hm1092_mode *mode = &hm1092_mode_560x360;
+ struct v4l2_fwnode_device_properties props;
+ s64 hblank, pixel_rate;
+ int ret;
+
+ v4l2_ctrl_handler_init(ctrl_hdlr, 6);
+
+ hm1092->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
+ &hm1092_ctrl_ops,
+ V4L2_CID_LINK_FREQ,
+ 0, 0,
+ hm1092_link_freq_menu);
+ if (hm1092->link_freq)
+ hm1092->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+ pixel_rate = div_u64(HM1092_LINK_FREQ_400MHZ * 2 * hm1092->mipi_lanes,
+ HM1092_BITS_PER_SAMPLE);
+ hm1092->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
+ V4L2_CID_PIXEL_RATE, 0,
+ pixel_rate, 1, pixel_rate);
+
+ hblank = mode->hts - mode->width;
+ hm1092->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
+ V4L2_CID_HBLANK, hblank, hblank, 1,
+ hblank);
+ if (hm1092->hblank)
+ hm1092->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+ hm1092->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
+ V4L2_CID_VBLANK,
+ mode->vts - mode->height,
+ 0xffff - mode->height, 1,
+ mode->vts - mode->height);
+ if (hm1092->vblank)
+ hm1092->vblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+ v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &hm1092_ctrl_ops,
+ V4L2_CID_TEST_PATTERN,
+ ARRAY_SIZE(hm1092_test_pattern_menu) - 1,
+ 0, 0, hm1092_test_pattern_menu);
+
+ ret = v4l2_fwnode_device_parse(hm1092->dev, &props);
+ if (ret)
+ goto err_free;
+
+ v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &hm1092_ctrl_ops, &props);
+
+ if (ctrl_hdlr->error) {
+ ret = ctrl_hdlr->error;
+ goto err_free;
+ }
+
+ hm1092->sd.ctrl_handler = ctrl_hdlr;
+
+ return 0;
+
+err_free:
+ v4l2_ctrl_handler_free(ctrl_hdlr);
+
+ return ret;
+}
+
+static void hm1092_update_pad_format(struct v4l2_mbus_framefmt *fmt)
+{
+ fmt->width = hm1092_mode_560x360.width;
+ fmt->height = hm1092_mode_560x360.height;
+ fmt->code = MEDIA_BUS_FMT_Y10_1X10;
+ fmt->field = V4L2_FIELD_NONE;
+ fmt->colorspace = V4L2_COLORSPACE_RAW;
+ fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+ fmt->quantization = V4L2_QUANTIZATION_DEFAULT;
+ fmt->xfer_func = V4L2_XFER_FUNC_NONE;
+}
+
+static int hm1092_enable_streams(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ u32 pad, u64 streams_mask)
+{
+ struct hm1092 *hm1092 = to_hm1092(sd);
+ int ret;
+
+ ret = pm_runtime_resume_and_get(hm1092->dev);
+ if (ret)
+ return ret;
+
+ ret = hm1092_write_regs(hm1092, hm1092_init_regs,
+ ARRAY_SIZE(hm1092_init_regs));
+ if (ret) {
+ dev_err(hm1092->dev, "failed to write init registers\n");
+ goto out;
+ }
+
+ ret = __v4l2_ctrl_handler_setup(hm1092->sd.ctrl_handler);
+ if (ret)
+ goto out;
+
+ ret = hm1092_write_regs(hm1092, hm1092_start_streaming,
+ ARRAY_SIZE(hm1092_start_streaming));
+ if (ret)
+ dev_err(hm1092->dev, "failed to start streaming\n");
+
+out:
+ if (ret)
+ pm_runtime_put(hm1092->dev);
+
+ return ret;
+}
+
+static int hm1092_disable_streams(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ u32 pad, u64 streams_mask)
+{
+ struct hm1092 *hm1092 = to_hm1092(sd);
+ int ret = 0;
+
+ cci_write(hm1092->regmap, HM1092_REG_STREAM, 0, &ret);
+ pm_runtime_put(hm1092->dev);
+
+ return ret;
+}
+
+static int hm1092_set_format(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ struct v4l2_subdev_format *fmt)
+{
+ hm1092_update_pad_format(&fmt->format);
+ *v4l2_subdev_state_get_format(state, fmt->pad) = fmt->format;
+
+ return 0;
+}
+
+static int hm1092_enum_mbus_code(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ struct v4l2_subdev_mbus_code_enum *code)
+{
+ if (code->index)
+ return -EINVAL;
+
+ code->code = MEDIA_BUS_FMT_Y10_1X10;
+
+ return 0;
+}
+
+static int hm1092_enum_frame_size(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ struct v4l2_subdev_frame_size_enum *fse)
+{
+ if (fse->index)
+ return -EINVAL;
+
+ if (fse->code != MEDIA_BUS_FMT_Y10_1X10)
+ return -EINVAL;
+
+ fse->min_width = hm1092_mode_560x360.width;
+ fse->max_width = hm1092_mode_560x360.width;
+ fse->min_height = hm1092_mode_560x360.height;
+ fse->max_height = hm1092_mode_560x360.height;
+
+ return 0;
+}
+
+static int hm1092_init_state(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state)
+{
+ hm1092_update_pad_format(v4l2_subdev_state_get_format(state, 0));
+
+ return 0;
+}
+
+static const struct v4l2_subdev_video_ops hm1092_video_ops = {
+ .s_stream = v4l2_subdev_s_stream_helper,
+};
+
+static const struct v4l2_subdev_pad_ops hm1092_pad_ops = {
+ .set_fmt = hm1092_set_format,
+ .get_fmt = v4l2_subdev_get_fmt,
+ .enum_mbus_code = hm1092_enum_mbus_code,
+ .enum_frame_size = hm1092_enum_frame_size,
+ .enable_streams = hm1092_enable_streams,
+ .disable_streams = hm1092_disable_streams,
+};
+
+static const struct v4l2_subdev_ops hm1092_subdev_ops = {
+ .video = &hm1092_video_ops,
+ .pad = &hm1092_pad_ops,
+};
+
+static const struct media_entity_operations hm1092_entity_ops = {
+ .link_validate = v4l2_subdev_link_validate,
+};
+
+static const struct v4l2_subdev_internal_ops hm1092_internal_ops = {
+ .init_state = hm1092_init_state,
+};
+
+static int hm1092_check_hwcfg(struct hm1092 *hm1092)
+{
+ struct v4l2_fwnode_endpoint bus_cfg = {
+ .bus_type = V4L2_MBUS_CSI2_DPHY,
+ };
+ struct device *dev = hm1092->dev;
+ struct fwnode_handle *ep, *fwnode = dev_fwnode(dev);
+ unsigned long link_freq_bitmap;
+ int ret;
+
+ ep = fwnode_graph_get_endpoint_by_id(fwnode, 0, 0, 0);
+ if (!ep)
+ return dev_err_probe(dev, -ENXIO,
+ "fwnode graph endpoint not found\n");
+
+ ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
+ fwnode_handle_put(ep);
+ if (ret)
+ return dev_err_probe(dev, ret, "parsing endpoint failed\n");
+
+ ret = v4l2_link_freq_to_bitmap(dev, bus_cfg.link_frequencies,
+ bus_cfg.nr_of_link_frequencies,
+ hm1092_link_freq_menu,
+ ARRAY_SIZE(hm1092_link_freq_menu),
+ &link_freq_bitmap);
+ if (ret)
+ goto out;
+
+ if (bus_cfg.bus.mipi_csi2.num_data_lanes != 1) {
+ ret = dev_err_probe(dev, -EINVAL,
+ "only 1 data lane is supported, got %u\n",
+ bus_cfg.bus.mipi_csi2.num_data_lanes);
+ goto out;
+ }
+
+ hm1092->mipi_lanes = bus_cfg.bus.mipi_csi2.num_data_lanes;
+
+out:
+ v4l2_fwnode_endpoint_free(&bus_cfg);
+ return ret;
+}
+
+static int hm1092_get_pm_resources(struct hm1092 *hm1092)
+{
+ unsigned int i;
+
+ hm1092->reset = devm_gpiod_get_optional(hm1092->dev, "reset",
+ GPIOD_OUT_HIGH);
+ if (IS_ERR(hm1092->reset))
+ return dev_err_probe(hm1092->dev, PTR_ERR(hm1092->reset),
+ "failed to get reset gpio\n");
+
+ for (i = 0; i < ARRAY_SIZE(hm1092_supply_names); i++)
+ hm1092->supplies[i].supply = hm1092_supply_names[i];
+
+ return devm_regulator_bulk_get(hm1092->dev,
+ ARRAY_SIZE(hm1092_supply_names),
+ hm1092->supplies);
+}
+
+static int hm1092_power_off(struct device *dev)
+{
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
+ struct hm1092 *hm1092 = to_hm1092(sd);
+
+ gpiod_set_value_cansleep(hm1092->reset, 1);
+ clk_disable_unprepare(hm1092->img_clk);
+ regulator_bulk_disable(ARRAY_SIZE(hm1092_supply_names),
+ hm1092->supplies);
+
+ return 0;
+}
+
+static int hm1092_power_on(struct device *dev)
+{
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
+ struct hm1092 *hm1092 = to_hm1092(sd);
+ int ret;
+
+ /*
+ * Power-up sequence:
+ * 1. enable all rails (~3 ms ramp)
+ * 2. hold reset asserted
+ * 3. start MCLK and let the sensor clock for ~1 ms
+ * 4. release reset and wait 18 ms for the sensor to come up
+ */
+ ret = regulator_bulk_enable(ARRAY_SIZE(hm1092_supply_names),
+ hm1092->supplies);
+ if (ret)
+ return ret;
+ usleep_range(3000, 3500);
+
+ if (hm1092->reset)
+ gpiod_set_value_cansleep(hm1092->reset, 1);
+
+ ret = clk_prepare_enable(hm1092->img_clk);
+ if (ret) {
+ regulator_bulk_disable(ARRAY_SIZE(hm1092_supply_names),
+ hm1092->supplies);
+ return ret;
+ }
+ usleep_range(1000, 1200);
+
+ if (hm1092->reset)
+ gpiod_set_value_cansleep(hm1092->reset, 0);
+ usleep_range(18000, 19000);
+
+ return 0;
+}
+
+static void hm1092_remove(struct i2c_client *client)
+{
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct hm1092 *hm1092 = to_hm1092(sd);
+
+ v4l2_async_unregister_subdev(sd);
+ v4l2_subdev_cleanup(sd);
+ media_entity_cleanup(&sd->entity);
+ v4l2_ctrl_handler_free(sd->ctrl_handler);
+ pm_runtime_disable(hm1092->dev);
+ if (!pm_runtime_status_suspended(hm1092->dev)) {
+ hm1092_power_off(hm1092->dev);
+ pm_runtime_set_suspended(hm1092->dev);
+ }
+}
+
+static int hm1092_probe(struct i2c_client *client)
+{
+ struct hm1092 *hm1092;
+ unsigned long freq;
+ int ret;
+
+ hm1092 = devm_kzalloc(&client->dev, sizeof(*hm1092), GFP_KERNEL);
+ if (!hm1092)
+ return -ENOMEM;
+
+ hm1092->dev = &client->dev;
+
+ hm1092->img_clk = devm_v4l2_sensor_clk_get(hm1092->dev, NULL);
+ if (IS_ERR(hm1092->img_clk))
+ return dev_err_probe(hm1092->dev, PTR_ERR(hm1092->img_clk),
+ "failed to get imaging clock\n");
+
+ freq = clk_get_rate(hm1092->img_clk);
+ if (freq != HM1092_MCLK) {
+ return dev_err_probe(hm1092->dev, -EINVAL,
+ "external clock %lu is not supported\n",
+ freq);
+ }
+
+ v4l2_i2c_subdev_init(&hm1092->sd, client, &hm1092_subdev_ops);
+
+ ret = hm1092_check_hwcfg(hm1092);
+ if (ret)
+ return ret;
+
+ ret = hm1092_get_pm_resources(hm1092);
+ if (ret)
+ return ret;
+
+ hm1092->regmap = devm_cci_regmap_init_i2c(client, 16);
+ if (IS_ERR(hm1092->regmap))
+ return PTR_ERR(hm1092->regmap);
+
+ ret = hm1092_power_on(hm1092->dev);
+ if (ret)
+ return dev_err_probe(hm1092->dev, ret, "failed to power on\n");
+
+ ret = hm1092_init_controls(hm1092);
+ if (ret)
+ goto err_power_off;
+
+ hm1092->sd.internal_ops = &hm1092_internal_ops;
+ hm1092->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
+ hm1092->sd.entity.ops = &hm1092_entity_ops;
+ hm1092->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
+ hm1092->pad.flags = MEDIA_PAD_FL_SOURCE;
+ ret = media_entity_pads_init(&hm1092->sd.entity, 1, &hm1092->pad);
+ if (ret)
+ goto err_ctrls;
+
+ hm1092->sd.state_lock = hm1092->ctrl_handler.lock;
+ ret = v4l2_subdev_init_finalize(&hm1092->sd);
+ if (ret)
+ goto err_entity;
+
+ pm_runtime_set_active(hm1092->dev);
+ pm_runtime_enable(hm1092->dev);
+
+ ret = v4l2_async_register_subdev_sensor(&hm1092->sd);
+ if (ret)
+ goto err_subdev;
+
+ pm_runtime_idle(hm1092->dev);
+ return 0;
+
+err_subdev:
+ pm_runtime_disable(hm1092->dev);
+ pm_runtime_set_suspended(hm1092->dev);
+ v4l2_subdev_cleanup(&hm1092->sd);
+err_entity:
+ media_entity_cleanup(&hm1092->sd.entity);
+err_ctrls:
+ v4l2_ctrl_handler_free(hm1092->sd.ctrl_handler);
+err_power_off:
+ hm1092_power_off(hm1092->dev);
+
+ return ret;
+}
+
+static DEFINE_RUNTIME_DEV_PM_OPS(hm1092_pm_ops, hm1092_power_off,
+ hm1092_power_on, NULL);
+
+static const struct of_device_id hm1092_of_match[] = {
+ { .compatible = "himax,hm1092" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, hm1092_of_match);
+
+static struct i2c_driver hm1092_i2c_driver = {
+ .driver = {
+ .name = "hm1092",
+ .pm = pm_ptr(&hm1092_pm_ops),
+ .of_match_table = hm1092_of_match,
+ },
+ .probe = hm1092_probe,
+ .remove = hm1092_remove,
+};
+
+module_i2c_driver(hm1092_i2c_driver);
+
+MODULE_DESCRIPTION("Himax HM1092 monochrome NIR image sensor driver");
+MODULE_LICENSE("GPL");
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver
2026-07-02 7:34 ` [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh R
@ 2026-07-04 13:57 ` Sakari Ailus
2026-07-04 19:31 ` Ramshouriesh R
0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2026-07-04 13:57 UTC (permalink / raw)
To: Ramshouriesh R
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Hans Verkuil, Bryan O'Donoghue,
Vladimir Zapolskiy, linux-media, devicetree, linux-kernel
Hi Ramesh,
Thanks for the patch; please see my comments below.
On Thu, Jul 02, 2026 at 01:04:26PM +0530, Ramshouriesh R wrote:
> Add a V4L2 subdev driver for the Himax HM1092, a 1 megapixel monochrome
> near-infrared image sensor with a single-lane MIPI CSI-2 interface,
> typically used as the face-authentication IR camera on laptops.
>
> The driver supports the sensor's native 560x360 10-bit mono mode, a test
> pattern control and the standard fwnode properties (orientation,
> rotation).
>
> Signed-off-by: Ramshouriesh R <rshouriesh@gmail.com>
> ---
> MAINTAINERS | 7 +
> drivers/media/i2c/Kconfig | 11 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/hm1092.c | 794 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 813 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5e11dd741d9f..4d9a4991ca2b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11652,6 +11652,13 @@ L: linux-kernel@vger.kernel.org
> S: Maintained
> F: drivers/misc/hisi_hikey_usb.c
>
> +HIMAX HM1092 SENSOR DRIVER
> +M: Ramshouriesh R <rshouriesh@gmail.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml
> +F: drivers/media/i2c/hm1092.c
> +
> HIMAX HX83112B TOUCHSCREEN SUPPORT
> M: Job Noorman <job@noorman.info>
> L: linux-input@vger.kernel.org
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 5d173e0ecf42..f94621edbe1a 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -137,6 +137,17 @@ config VIDEO_HI847
> To compile this driver as a module, choose M here: the
> module will be called hi847.
>
> +config VIDEO_HM1092
> + tristate "Himax HM1092 sensor support"
> + select V4L2_CCI_I2C
> + help
> + This is a Video4Linux2 sensor driver for the Himax HM1092
> + monochrome near-infrared CMOS image sensor, used as the
> + face-authentication IR camera on laptops.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called hm1092.
> +
> config VIDEO_IMX111
> tristate "Sony IMX111 sensor support"
> select V4L2_CCI_I2C
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index e45359efe0e4..6507c173d0fa 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -45,6 +45,7 @@ obj-$(CONFIG_VIDEO_GC2145) += gc2145.o
> obj-$(CONFIG_VIDEO_HI556) += hi556.o
> obj-$(CONFIG_VIDEO_HI846) += hi846.o
> obj-$(CONFIG_VIDEO_HI847) += hi847.o
> +obj-$(CONFIG_VIDEO_HM1092) += hm1092.o
> obj-$(CONFIG_VIDEO_I2C) += video-i2c.o
> obj-$(CONFIG_VIDEO_IMX111) += imx111.o
> obj-$(CONFIG_VIDEO_IMX208) += imx208.o
> diff --git a/drivers/media/i2c/hm1092.c b/drivers/media/i2c/hm1092.c
> new file mode 100644
> index 000000000000..e668bc59e1fc
> --- /dev/null
> +++ b/drivers/media/i2c/hm1092.c
> @@ -0,0 +1,794 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Himax HM1092 monochrome near-infrared image sensor driver.
Is there copyright for this code?
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>
> +#include <media/v4l2-cci.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-fwnode.h>
> +
> +#define HM1092_LINK_FREQ_400MHZ 400000000ULL
> +#define HM1092_MCLK 24000000
> +#define HM1092_BITS_PER_SAMPLE 10
> +
> +#define HM1092_REG_STREAM CCI_REG8(0x0100)
> +
> +struct hm1092_reg {
> + u16 address;
> + u8 val;
> +};
Please rely on v4l2-cci/regmap instead of driver specific structs and other
definitions. See e.g. the imx219 driver for an example.
> +
> +static const struct hm1092_reg hm1092_init_regs[] = {
> + { 0x0103, 0x00 },
> + { 0x030a, 0x05 },
> + { 0x030d, 0x0c },
> + { 0x030f, 0x5a },
> + { 0x0307, 0x00 },
> + { 0x0309, 0x01 },
> + { 0x0387, 0x01 },
> + { 0x0100, 0x02 },
> + { 0x4265, 0x02 },
> + { 0x4002, 0x2b },
> + { 0x4001, 0x00 },
> + { 0x0101, 0x03 },
> + { 0x4024, 0x40 },
> + { 0x0203, 0xbe },
> + { 0x0202, 0x00 },
> + { 0x0341, 0xee },
> + { 0x0340, 0x02 },
> + { 0x0343, 0x50 },
> + { 0x0342, 0x06 },
> + { 0x0345, 0x30 },
> + { 0x0344, 0x00 },
> + { 0x0349, 0xad },
> + { 0x0348, 0x04 },
> + { 0x0347, 0x08 },
> + { 0x0346, 0x00 },
> + { 0x034b, 0xd5 },
> + { 0x034a, 0x02 },
> + { 0x5015, 0xb3 },
> + { 0x0350, 0x53 },
> + { 0x0361, 0x30 },
> + { 0x0360, 0x00 },
> + { 0x034d, 0x30 },
> + { 0x034c, 0x02 },
> + { 0x034f, 0x68 },
> + { 0x034e, 0x01 },
> + { 0x0390, 0x03 },
> + { 0x0383, 0x00 },
> + { 0x0387, 0x10 },
> + { 0x50dd, 0x01 },
> + { 0x50cb, 0x21 },
> + { 0x5005, 0x28 },
> + { 0x5004, 0x40 },
> + { 0x5007, 0x28 },
> + { 0x5006, 0x40 },
> + { 0x5011, 0x00 },
> + { 0x501d, 0x4c },
> + { 0x5013, 0x03 },
> + { 0x4131, 0x01 },
> + { 0x5283, 0x03 },
> + { 0x5282, 0xff },
> + { 0x5010, 0x20 },
> + { 0x4132, 0x20 },
> + { 0x50d5, 0xe0 },
> + { 0x50d7, 0x12 },
> + { 0x50bb, 0x14 },
> + { 0x50b7, 0x00 },
> + { 0x50b9, 0xff },
> + { 0x50b8, 0x70 },
> + { 0x50ba, 0xff },
> + { 0x50fa, 0x02 },
> + { 0x50b4, 0x00 },
> + { 0x50a2, 0x0b },
> + { 0x50ad, 0x07 },
> + { 0x50ac, 0x24 },
> + { 0x50af, 0x40 },
> + { 0x50ae, 0x20 },
> + { 0x50ab, 0x07 },
> + { 0x50aa, 0x22 },
> + { 0x50a7, 0x00 },
> + { 0x50a6, 0x00 },
> + { 0x5099, 0x11 },
> + { 0x509b, 0x03 },
> + { 0x50b3, 0x04 },
> + { 0x50a0, 0x30 },
> + { 0x5098, 0x00 },
> + { 0x52f2, 0x53 },
> + { 0x5209, 0x0c },
> + { 0x5216, 0x02 },
> + { 0x521e, 0x01 },
> + { 0x50e8, 0x00 },
> + { 0x5200, 0x60 },
> + { 0x5202, 0x00 },
> + { 0x5201, 0x80 },
> + { 0x5203, 0x01 },
> + { 0x5208, 0x0b },
> + { 0x520d, 0x40 },
> + { 0x520c, 0x15 },
> + { 0x5215, 0x04 },
> + { 0x50ea, 0x74 },
> + { 0x5214, 0x28 },
> + { 0x5218, 0x07 },
> + { 0x5217, 0x01 },
> + { 0x0310, 0x00 },
> + { 0x4b31, 0x06 },
> + { 0x4b3b, 0x02 },
> + { 0x4b45, 0x01 },
> + { 0x4b44, 0x0c },
> + { 0x4b47, 0x00 },
> + { 0x5101, 0x13 },
> + { 0x5100, 0x03 },
> + { 0x5103, 0x33 },
> + { 0x5102, 0x23 },
> + { 0x5105, 0x42 },
> + { 0x5104, 0x43 },
> + { 0x5106, 0x40 },
> + { 0x5119, 0x00 },
> + { 0x5118, 0x00 },
> + { 0x511b, 0x00 },
> + { 0x511a, 0x00 },
> + { 0x511d, 0x00 },
> + { 0x511c, 0x00 },
> + { 0x511e, 0x00 },
> + { 0x5131, 0x23 },
> + { 0x5130, 0x13 },
> + { 0x5133, 0x43 },
> + { 0x5132, 0x33 },
> + { 0x5135, 0x40 },
> + { 0x5134, 0x42 },
> + { 0x5136, 0x40 },
> + { 0x5149, 0x01 },
> + { 0x5148, 0x01 },
> + { 0x514b, 0x01 },
> + { 0x514a, 0x01 },
> + { 0x514d, 0x01 },
> + { 0x514c, 0x01 },
> + { 0x514e, 0x01 },
> + { 0x51c0, 0x00 },
> + { 0x51c6, 0x00 },
> + { 0x51cc, 0x00 },
> + { 0x51d2, 0x00 },
> + { 0x51d8, 0x00 },
> + { 0x51c1, 0x81 },
> + { 0x51c7, 0x81 },
> + { 0x51cd, 0x81 },
> + { 0x51d3, 0x81 },
> + { 0x51d9, 0x81 },
> + { 0x51c2, 0xec },
> + { 0x51c8, 0xec },
> + { 0x51ce, 0xec },
> + { 0x51d4, 0xec },
> + { 0x51da, 0xec },
> + { 0x51c3, 0x00 },
> + { 0x51c9, 0x00 },
> + { 0x51cf, 0x00 },
> + { 0x51d5, 0x00 },
> + { 0x51db, 0x00 },
> + { 0x51c4, 0x55 },
> + { 0x51ca, 0x55 },
> + { 0x51d0, 0x54 },
> + { 0x51d6, 0x53 },
> + { 0x51dc, 0x53 },
> + { 0x51c5, 0x44 },
> + { 0x51cb, 0x24 },
> + { 0x51d1, 0x24 },
> + { 0x51d7, 0x14 },
> + { 0x51dd, 0x14 },
> + { 0x51e0, 0x09 },
> + { 0x51e2, 0x04 },
> + { 0x51e4, 0x08 },
> + { 0x51e6, 0x08 },
> + { 0x51e1, 0x03 },
> + { 0x51e3, 0x03 },
> + { 0x51e5, 0x07 },
> + { 0x51e8, 0x04 },
> + { 0x51e7, 0x07 },
> + { 0x51e9, 0x46 },
> + { 0x51eb, 0x62 },
> + { 0x51ea, 0x43 },
> + { 0x51ed, 0x00 },
> + { 0x51ec, 0x61 },
> + { 0x51ee, 0x00 },
> + { 0x5206, 0x80 },
> + { 0x3110, 0x02 },
> + { 0x3704, 0x02 },
> + { 0x3704, 0x02 },
> + { 0x4b20, 0x9e },
> + { 0x4b18, 0x00 },
> + { 0x4b3e, 0x00 },
> + { 0x4b0e, 0x0e },
> + { 0x4800, 0xac },
> + { 0x0104, 0x01 },
> + { 0x0104, 0x00 },
> + { 0x4801, 0xae },
> + { 0x0000, 0x00 },
> + { 0x0037, 0x30 },
> +};
> +
> +static const struct hm1092_reg hm1092_start_streaming[] = {
> + { 0x0100, 0x01 },
> +};
> +
> +static const struct hm1092_reg hm1092_test_pattern_mode0[] = {
> + { 0x0601, 0x00 },
> +};
> +
> +static const struct hm1092_reg hm1092_test_pattern_mode1[] = {
> + { 0x0601, 0x01 },
> +};
> +
> +static const struct hm1092_reg hm1092_test_pattern_mode2[] = {
> + { 0x0601, 0x02 },
> +};
> +
> +static const struct hm1092_reg hm1092_test_pattern_mode3[] = {
> + { 0x0601, 0x03 },
> +};
> +
> +static const struct hm1092_reg hm1092_test_pattern_mode4[] = {
> + { 0x0601, 0x04 },
> +};
Add human-readable macros for these values and use them as arguments for
cci_write().
> +
> +struct hm1092_mode {
> + u32 width;
> + u32 height;
> + u32 hts;
> + u32 vts;
> +};
> +
> +static const struct hm1092_mode hm1092_mode_560x360 = {
> + .width = 560,
> + .height = 360,
> + .hts = 0x0650,
> + .vts = 0x02ee,
> +};
> +
> +static const char * const hm1092_supply_names[] = {
> + "dovdd",
> + "avdd",
> + "dvdd",
> +};
> +
> +static const char * const hm1092_test_pattern_menu[] = {
> + "Disabled",
> + "Mode 1",
> + "Mode 2",
> + "Mode 3",
> + "Mode 4",
Is there any more descriptive information on the test patterns?
> +};
> +
> +static const s64 hm1092_link_freq_menu[] = {
> + HM1092_LINK_FREQ_400MHZ,
> +};
> +
> +struct hm1092 {
> + struct device *dev;
> + struct v4l2_subdev sd;
> + struct media_pad pad;
> + struct v4l2_ctrl_handler ctrl_handler;
> + struct regmap *regmap;
> + struct clk *img_clk;
> + struct gpio_desc *reset;
> + struct regulator_bulk_data supplies[ARRAY_SIZE(hm1092_supply_names)];
> + struct v4l2_ctrl *link_freq;
> + struct v4l2_ctrl *pixel_rate;
> + struct v4l2_ctrl *hblank;
> + struct v4l2_ctrl *vblank;
> + u8 mipi_lanes;
> +};
> +
> +static inline struct hm1092 *to_hm1092(struct v4l2_subdev *sd)
> +{
> + return container_of(sd, struct hm1092, sd);
> +}
> +
> +static int hm1092_write_regs(struct hm1092 *hm1092,
> + const struct hm1092_reg *regs, unsigned int len)
> +{
> + unsigned int i;
> + int ret = 0;
> +
> + for (i = 0; i < len; i++) {
> + cci_write(hm1092->regmap, CCI_REG8(regs[i].address),
> + regs[i].val, &ret);
> + if (ret)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int hm1092_set_test_pattern(struct hm1092 *hm1092, int pattern)
> +{
> + switch (pattern) {
> + case 0:
> + return hm1092_write_regs(hm1092, hm1092_test_pattern_mode0,
> + ARRAY_SIZE(hm1092_test_pattern_mode0));
> + case 1:
> + return hm1092_write_regs(hm1092, hm1092_test_pattern_mode1,
> + ARRAY_SIZE(hm1092_test_pattern_mode1));
> + case 2:
> + return hm1092_write_regs(hm1092, hm1092_test_pattern_mode2,
> + ARRAY_SIZE(hm1092_test_pattern_mode2));
> + case 3:
> + return hm1092_write_regs(hm1092, hm1092_test_pattern_mode3,
> + ARRAY_SIZE(hm1092_test_pattern_mode3));
> + case 4:
> + return hm1092_write_regs(hm1092, hm1092_test_pattern_mode4,
> + ARRAY_SIZE(hm1092_test_pattern_mode4));
> + default:
> + return -EINVAL;
> + }
> +}
> +
> +static int hm1092_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
> + struct hm1092 *hm1092 = container_of(ctrl->handler, struct hm1092,
> + ctrl_handler);
> + int ret;
> +
> + /*
> + * The control value is cached by the framework and (re)applied from
> + * hm1092_enable_streams() once the device is powered up for streaming.
> + */
> + if (pm_runtime_get_if_in_use(hm1092->dev) == 0)
> + return 0;
> +
> + switch (ctrl->id) {
> + case V4L2_CID_TEST_PATTERN:
> + ret = hm1092_set_test_pattern(hm1092, ctrl->val);
> + break;
> + default:
> + ret = -EINVAL;
> + break;
> + }
> +
> + pm_runtime_put(hm1092->dev);
> +
> + return ret;
> +}
> +
> +static const struct v4l2_ctrl_ops hm1092_ctrl_ops = {
> + .s_ctrl = hm1092_set_ctrl,
> +};
> +
> +static int hm1092_init_controls(struct hm1092 *hm1092)
> +{
> + struct v4l2_ctrl_handler *ctrl_hdlr = &hm1092->ctrl_handler;
> + const struct hm1092_mode *mode = &hm1092_mode_560x360;
> + struct v4l2_fwnode_device_properties props;
> + s64 hblank, pixel_rate;
> + int ret;
> +
> + v4l2_ctrl_handler_init(ctrl_hdlr, 6);
> +
> + hm1092->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> + &hm1092_ctrl_ops,
> + V4L2_CID_LINK_FREQ,
> + 0, 0,
> + hm1092_link_freq_menu);
> + if (hm1092->link_freq)
> + hm1092->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + pixel_rate = div_u64(HM1092_LINK_FREQ_400MHZ * 2 * hm1092->mipi_lanes,
> + HM1092_BITS_PER_SAMPLE);
> + hm1092->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
> + V4L2_CID_PIXEL_RATE, 0,
> + pixel_rate, 1, pixel_rate);
> +
> + hblank = mode->hts - mode->width;
> + hm1092->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
> + V4L2_CID_HBLANK, hblank, hblank, 1,
> + hblank);
> + if (hm1092->hblank)
> + hm1092->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + hm1092->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &hm1092_ctrl_ops,
> + V4L2_CID_VBLANK,
> + mode->vts - mode->height,
> + 0xffff - mode->height, 1,
> + mode->vts - mode->height);
> + if (hm1092->vblank)
> + hm1092->vblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &hm1092_ctrl_ops,
> + V4L2_CID_TEST_PATTERN,
> + ARRAY_SIZE(hm1092_test_pattern_menu) - 1,
> + 0, 0, hm1092_test_pattern_menu);
> +
> + ret = v4l2_fwnode_device_parse(hm1092->dev, &props);
Move this to the beginning of the function and error handling will be
simplified.
> + if (ret)
> + goto err_free;
> +
> + v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &hm1092_ctrl_ops, &props);
> +
> + if (ctrl_hdlr->error) {
> + ret = ctrl_hdlr->error;
> + goto err_free;
> + }
You can move setting control flags here and remove the non-NULL checks.
> +
> + hm1092->sd.ctrl_handler = ctrl_hdlr;
> +
> + return 0;
> +
> +err_free:
> + v4l2_ctrl_handler_free(ctrl_hdlr);
> +
> + return ret;
> +}
> +
> +static void hm1092_update_pad_format(struct v4l2_mbus_framefmt *fmt)
> +{
> + fmt->width = hm1092_mode_560x360.width;
> + fmt->height = hm1092_mode_560x360.height;
> + fmt->code = MEDIA_BUS_FMT_Y10_1X10;
> + fmt->field = V4L2_FIELD_NONE;
> + fmt->colorspace = V4L2_COLORSPACE_RAW;
> + fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> + fmt->quantization = V4L2_QUANTIZATION_DEFAULT;
> + fmt->xfer_func = V4L2_XFER_FUNC_NONE;
> +}
> +
> +static int hm1092_enable_streams(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + u32 pad, u64 streams_mask)
> +{
> + struct hm1092 *hm1092 = to_hm1092(sd);
> + int ret;
> +
> + ret = pm_runtime_resume_and_get(hm1092->dev);
> + if (ret)
> + return ret;
> +
> + ret = hm1092_write_regs(hm1092, hm1092_init_regs,
> + ARRAY_SIZE(hm1092_init_regs));
> + if (ret) {
> + dev_err(hm1092->dev, "failed to write init registers\n");
> + goto out;
> + }
> +
> + ret = __v4l2_ctrl_handler_setup(hm1092->sd.ctrl_handler);
> + if (ret)
> + goto out;
> +
> + ret = hm1092_write_regs(hm1092, hm1092_start_streaming,
> + ARRAY_SIZE(hm1092_start_streaming));
> + if (ret)
> + dev_err(hm1092->dev, "failed to start streaming\n");
> +
> +out:
> + if (ret)
> + pm_runtime_put(hm1092->dev);
> +
> + return ret;
> +}
> +
> +static int hm1092_disable_streams(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + u32 pad, u64 streams_mask)
> +{
> + struct hm1092 *hm1092 = to_hm1092(sd);
> + int ret = 0;
You can remove the initialisation...
> +
> + cci_write(hm1092->regmap, HM1092_REG_STREAM, 0, &ret);
and assign ret here.
> + pm_runtime_put(hm1092->dev);
> +
> + return ret;
> +}
> +
> +static int hm1092_set_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + struct v4l2_subdev_format *fmt)
> +{
> + hm1092_update_pad_format(&fmt->format);
> + *v4l2_subdev_state_get_format(state, fmt->pad) = fmt->format;
> +
> + return 0;
> +}
> +
> +static int hm1092_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + if (code->index)
> + return -EINVAL;
> +
> + code->code = MEDIA_BUS_FMT_Y10_1X10;
> +
> + return 0;
> +}
> +
> +static int hm1092_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + struct v4l2_subdev_frame_size_enum *fse)
> +{
> + if (fse->index)
> + return -EINVAL;
> +
> + if (fse->code != MEDIA_BUS_FMT_Y10_1X10)
> + return -EINVAL;
> +
> + fse->min_width = hm1092_mode_560x360.width;
> + fse->max_width = hm1092_mode_560x360.width;
> + fse->min_height = hm1092_mode_560x360.height;
> + fse->max_height = hm1092_mode_560x360.height;
> +
> + return 0;
> +}
> +
> +static int hm1092_init_state(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state)
> +{
> + hm1092_update_pad_format(v4l2_subdev_state_get_format(state, 0));
> +
> + return 0;
> +}
> +
> +static const struct v4l2_subdev_video_ops hm1092_video_ops = {
> + .s_stream = v4l2_subdev_s_stream_helper,
> +};
> +
> +static const struct v4l2_subdev_pad_ops hm1092_pad_ops = {
> + .set_fmt = hm1092_set_format,
Could you use the get_fmt() callback here as you support a single mode?
> + .get_fmt = v4l2_subdev_get_fmt,
> + .enum_mbus_code = hm1092_enum_mbus_code,
> + .enum_frame_size = hm1092_enum_frame_size,
> + .enable_streams = hm1092_enable_streams,
> + .disable_streams = hm1092_disable_streams,
> +};
> +
> +static const struct v4l2_subdev_ops hm1092_subdev_ops = {
> + .video = &hm1092_video_ops,
> + .pad = &hm1092_pad_ops,
> +};
> +
> +static const struct media_entity_operations hm1092_entity_ops = {
> + .link_validate = v4l2_subdev_link_validate,
> +};
> +
> +static const struct v4l2_subdev_internal_ops hm1092_internal_ops = {
> + .init_state = hm1092_init_state,
> +};
> +
> +static int hm1092_check_hwcfg(struct hm1092 *hm1092)
> +{
> + struct v4l2_fwnode_endpoint bus_cfg = {
> + .bus_type = V4L2_MBUS_CSI2_DPHY,
> + };
> + struct device *dev = hm1092->dev;
> + struct fwnode_handle *ep, *fwnode = dev_fwnode(dev);
> + unsigned long link_freq_bitmap;
> + int ret;
> +
> + ep = fwnode_graph_get_endpoint_by_id(fwnode, 0, 0, 0);
> + if (!ep)
This check is now redundant -- v4l2_fwnode_endpoint_alloc_parse() below
handles it.
> + return dev_err_probe(dev, -ENXIO,
> + "fwnode graph endpoint not found\n");
> +
> + ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> + fwnode_handle_put(ep);
> + if (ret)
> + return dev_err_probe(dev, ret, "parsing endpoint failed\n");
> +
> + ret = v4l2_link_freq_to_bitmap(dev, bus_cfg.link_frequencies,
> + bus_cfg.nr_of_link_frequencies,
> + hm1092_link_freq_menu,
> + ARRAY_SIZE(hm1092_link_freq_menu),
> + &link_freq_bitmap);
> + if (ret)
> + goto out;
> +
> + if (bus_cfg.bus.mipi_csi2.num_data_lanes != 1) {
> + ret = dev_err_probe(dev, -EINVAL,
> + "only 1 data lane is supported, got %u\n",
> + bus_cfg.bus.mipi_csi2.num_data_lanes);
> + goto out;
If the driver supports a single data lane only, there's no need to put that
to DT either, is there?
> + }
> +
> + hm1092->mipi_lanes = bus_cfg.bus.mipi_csi2.num_data_lanes;
> +
> +out:
> + v4l2_fwnode_endpoint_free(&bus_cfg);
> + return ret;
> +}
> +
> +static int hm1092_get_pm_resources(struct hm1092 *hm1092)
> +{
> + unsigned int i;
> +
> + hm1092->reset = devm_gpiod_get_optional(hm1092->dev, "reset",
> + GPIOD_OUT_HIGH);
> + if (IS_ERR(hm1092->reset))
> + return dev_err_probe(hm1092->dev, PTR_ERR(hm1092->reset),
> + "failed to get reset gpio\n");
> +
> + for (i = 0; i < ARRAY_SIZE(hm1092_supply_names); i++)
You can declare i here.
> + hm1092->supplies[i].supply = hm1092_supply_names[i];
> +
> + return devm_regulator_bulk_get(hm1092->dev,
> + ARRAY_SIZE(hm1092_supply_names),
> + hm1092->supplies);
> +}
> +
> +static int hm1092_power_off(struct device *dev)
> +{
> + struct v4l2_subdev *sd = dev_get_drvdata(dev);
> + struct hm1092 *hm1092 = to_hm1092(sd);
> +
> + gpiod_set_value_cansleep(hm1092->reset, 1);
> + clk_disable_unprepare(hm1092->img_clk);
> + regulator_bulk_disable(ARRAY_SIZE(hm1092_supply_names),
> + hm1092->supplies);
> +
> + return 0;
> +}
> +
> +static int hm1092_power_on(struct device *dev)
> +{
> + struct v4l2_subdev *sd = dev_get_drvdata(dev);
> + struct hm1092 *hm1092 = to_hm1092(sd);
> + int ret;
> +
> + /*
> + * Power-up sequence:
> + * 1. enable all rails (~3 ms ramp)
> + * 2. hold reset asserted
> + * 3. start MCLK and let the sensor clock for ~1 ms
> + * 4. release reset and wait 18 ms for the sensor to come up
> + */
> + ret = regulator_bulk_enable(ARRAY_SIZE(hm1092_supply_names),
> + hm1092->supplies);
> + if (ret)
> + return ret;
> + usleep_range(3000, 3500);
> +
> + if (hm1092->reset)
> + gpiod_set_value_cansleep(hm1092->reset, 1);
No need for NULL checks for gpiod API.
> +
> + ret = clk_prepare_enable(hm1092->img_clk);
> + if (ret) {
> + regulator_bulk_disable(ARRAY_SIZE(hm1092_supply_names),
> + hm1092->supplies);
> + return ret;
> + }
> + usleep_range(1000, 1200);
Could you use fsleep() instead of usleep_range()?
> +
> + if (hm1092->reset)
> + gpiod_set_value_cansleep(hm1092->reset, 0);
Ditto.
> + usleep_range(18000, 19000);
> +
> + return 0;
> +}
> +
> +static void hm1092_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct hm1092 *hm1092 = to_hm1092(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + v4l2_subdev_cleanup(sd);
> + media_entity_cleanup(&sd->entity);
> + v4l2_ctrl_handler_free(sd->ctrl_handler);
> + pm_runtime_disable(hm1092->dev);
> + if (!pm_runtime_status_suspended(hm1092->dev)) {
> + hm1092_power_off(hm1092->dev);
> + pm_runtime_set_suspended(hm1092->dev);
> + }
> +}
> +
> +static int hm1092_probe(struct i2c_client *client)
> +{
> + struct hm1092 *hm1092;
> + unsigned long freq;
> + int ret;
> +
> + hm1092 = devm_kzalloc(&client->dev, sizeof(*hm1092), GFP_KERNEL);
> + if (!hm1092)
> + return -ENOMEM;
> +
> + hm1092->dev = &client->dev;
> +
> + hm1092->img_clk = devm_v4l2_sensor_clk_get(hm1092->dev, NULL);
> + if (IS_ERR(hm1092->img_clk))
> + return dev_err_probe(hm1092->dev, PTR_ERR(hm1092->img_clk),
> + "failed to get imaging clock\n");
> +
> + freq = clk_get_rate(hm1092->img_clk);
> + if (freq != HM1092_MCLK) {
> + return dev_err_probe(hm1092->dev, -EINVAL,
> + "external clock %lu is not supported\n",
> + freq);
> + }
No need for braces.
> +
> + v4l2_i2c_subdev_init(&hm1092->sd, client, &hm1092_subdev_ops);
> +
> + ret = hm1092_check_hwcfg(hm1092);
> + if (ret)
> + return ret;
> +
> + ret = hm1092_get_pm_resources(hm1092);
> + if (ret)
> + return ret;
> +
> + hm1092->regmap = devm_cci_regmap_init_i2c(client, 16);
> + if (IS_ERR(hm1092->regmap))
> + return PTR_ERR(hm1092->regmap);
> +
> + ret = hm1092_power_on(hm1092->dev);
> + if (ret)
> + return dev_err_probe(hm1092->dev, ret, "failed to power on\n");
> +
> + ret = hm1092_init_controls(hm1092);
> + if (ret)
> + goto err_power_off;
> +
> + hm1092->sd.internal_ops = &hm1092_internal_ops;
> + hm1092->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> + hm1092->sd.entity.ops = &hm1092_entity_ops;
> + hm1092->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + hm1092->pad.flags = MEDIA_PAD_FL_SOURCE;
> + ret = media_entity_pads_init(&hm1092->sd.entity, 1, &hm1092->pad);
> + if (ret)
> + goto err_ctrls;
> +
> + hm1092->sd.state_lock = hm1092->ctrl_handler.lock;
> + ret = v4l2_subdev_init_finalize(&hm1092->sd);
> + if (ret)
> + goto err_entity;
> +
> + pm_runtime_set_active(hm1092->dev);
> + pm_runtime_enable(hm1092->dev);
> +
> + ret = v4l2_async_register_subdev_sensor(&hm1092->sd);
> + if (ret)
> + goto err_subdev;
> +
> + pm_runtime_idle(hm1092->dev);
A newline would be nice here.
> + return 0;
> +
> +err_subdev:
> + pm_runtime_disable(hm1092->dev);
> + pm_runtime_set_suspended(hm1092->dev);
> + v4l2_subdev_cleanup(&hm1092->sd);
Before labels, too.
> +err_entity:
> + media_entity_cleanup(&hm1092->sd.entity);
> +err_ctrls:
> + v4l2_ctrl_handler_free(hm1092->sd.ctrl_handler);
> +err_power_off:
> + hm1092_power_off(hm1092->dev);
> +
> + return ret;
> +}
> +
> +static DEFINE_RUNTIME_DEV_PM_OPS(hm1092_pm_ops, hm1092_power_off,
> + hm1092_power_on, NULL);
> +
> +static const struct of_device_id hm1092_of_match[] = {
> + { .compatible = "himax,hm1092" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, hm1092_of_match);
> +
> +static struct i2c_driver hm1092_i2c_driver = {
> + .driver = {
> + .name = "hm1092",
> + .pm = pm_ptr(&hm1092_pm_ops),
> + .of_match_table = hm1092_of_match,
> + },
> + .probe = hm1092_probe,
> + .remove = hm1092_remove,
> +};
> +
> +module_i2c_driver(hm1092_i2c_driver);
> +
> +MODULE_DESCRIPTION("Himax HM1092 monochrome NIR image sensor driver");
> +MODULE_LICENSE("GPL");
>
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver
2026-07-04 13:57 ` Sakari Ailus
@ 2026-07-04 19:31 ` Ramshouriesh R
0 siblings, 0 replies; 5+ messages in thread
From: Ramshouriesh R @ 2026-07-04 19:31 UTC (permalink / raw)
To: Sakari Ailus
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Hans Verkuil, Bryan O'Donoghue,
Vladimir Zapolskiy, linux-media, devicetree, linux-kernel
Hi Sakari,
Small correction: my name is Ramshouriesh. You can address me as Ram.
Thanks for the review. I’ll address the comments in the next revision.
However regarding the mode names, there is no proper datasheet for
this sensor released publicly.
I will add the proper mode names based on what the camera does in each mode.
And regarding the driver supporting single data lane, I will make
data-lanes optional and
will initialize the endpoint parser with a default of one data lane
and configurations
explicitly specifying anything other than one lane will be rejected.
The binding will retain an optional constraint permitting only <1>, so
an explicit invalid
value will be caught by schema validation, but data-lanes will be
omitted from the example.
Regards,
Ramshouriesh R
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-04 19:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-02 7:34 [PATCH v3 0/2] media: Add Himax HM1092 mono NIR sensor driver Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor Ramshouriesh R
2026-07-02 7:34 ` [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh R
2026-07-04 13:57 ` Sakari Ailus
2026-07-04 19:31 ` Ramshouriesh R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox