* [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2
@ 2026-07-10 9:53 Luca Weiss
2026-07-10 9:58 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luca Weiss @ 2026-07-10 9:53 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: ~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
linux-arm-msm, devicetree, linux-kernel, Luca Weiss
Add the missing reset (BCR) for sdhc_2.
Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
index 8c9232988953..262fa8801256 100644
--- a/arch/arm64/boot/dts/qcom/milos.dtsi
+++ b/arch/arm64/boot/dts/qcom/milos.dtsi
@@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
iommus = <&apps_smmu 0x540 0>;
+ resets = <&gcc GCC_SDCC2_BCR>;
+
bus-width = <4>;
qcom,dll-config = <0x0007442c>;
---
base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2
2026-07-10 9:53 [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2 Luca Weiss
@ 2026-07-10 9:58 ` Konrad Dybcio
2026-07-12 15:05 ` Bjorn Andersson
2026-07-12 15:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-07-10 9:58 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 7/10/26 11:53 AM, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.
>
> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2
2026-07-10 9:53 [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2 Luca Weiss
2026-07-10 9:58 ` Konrad Dybcio
@ 2026-07-12 15:05 ` Bjorn Andersson
2026-07-12 15:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-07-12 15:05 UTC (permalink / raw)
To: Luca Weiss
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov, ~postmarketos/upstreaming, phone-devel,
Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel
On Fri, Jul 10, 2026 at 11:53:57AM +0200, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.
Don't be afraid of tell the world why a particular change is needed...
Regards,
Bjorn
>
> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 8c9232988953..262fa8801256 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>
> iommus = <&apps_smmu 0x540 0>;
>
> + resets = <&gcc GCC_SDCC2_BCR>;
> +
> bus-width = <4>;
>
> qcom,dll-config = <0x0007442c>;
>
> ---
> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
> change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8
>
> Best regards,
> --
> Luca Weiss <luca.weiss@fairphone.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2
2026-07-10 9:53 [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2 Luca Weiss
2026-07-10 9:58 ` Konrad Dybcio
2026-07-12 15:05 ` Bjorn Andersson
@ 2026-07-12 15:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-07-12 15:07 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov, Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
linux-arm-msm, devicetree, linux-kernel
On Fri, 10 Jul 2026 11:53:57 +0200, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: milos: Add reset for sdhc_2
commit: ab07ee0b1b29ce2672ae3b9ca208033c3ada12c2
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-12 15:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 9:53 [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2 Luca Weiss
2026-07-10 9:58 ` Konrad Dybcio
2026-07-12 15:05 ` Bjorn Andersson
2026-07-12 15:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox