public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: socfpga: dts: add fpga manager
@ 2015-10-13 19:38 atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
  2015-10-13 19:51 ` Dinh Nguyen
  0 siblings, 1 reply; 4+ messages in thread
From: atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2015-10-13 19:38 UTC (permalink / raw)
  To: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w, Alan Tull

From: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>

Add FPGA manager to device tree for SoCFPGA.

Signed-off-by: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
---
v2: Remove 0x after @
    No caps in hex numbers
    renamed hps_0_fpgamgr to fpgamgr0
    move node to be in alpha order by node name
---
 arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 314e589..0f50ae8 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -513,6 +513,13 @@
 				};
 		};
 
+		fpgamgr0: fpgamgr@ff706000 {
+			compatible = "altr,socfpga-fpga-mgr";
+			reg = <0xff706000 0x1000
+			       0xffb90000 0x1000>;
+			interrupts = <0 175 4>;
+		};
+
 		gmac0: ethernet@ff700000 {
 			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.70a", "snps,dwmac";
 			altr,sysmgr-syscon = <&sysmgr 0x60 0>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: socfpga: dts: add fpga manager
  2015-10-13 19:38 [PATCH v2] ARM: socfpga: dts: add fpga manager atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
@ 2015-10-13 19:51 ` Dinh Nguyen
  2015-10-13 20:33   ` Steffen Trumtrar
  0 siblings, 1 reply; 4+ messages in thread
From: Dinh Nguyen @ 2015-10-13 19:51 UTC (permalink / raw)
  To: Alan Tull
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, linux-kernel,
	Rob Herring, Kumar Gala, delicious.quinoa, linux-arm-kernel

On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:

> From: Alan Tull <atull@opensource.altera.com>
> 
> Add FPGA manager to device tree for SoCFPGA.
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
> v2: Remove 0x after @
>     No caps in hex numbers
>     renamed hps_0_fpgamgr to fpgamgr0
>     move node to be in alpha order by node name
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Applied!

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: socfpga: dts: add fpga manager
  2015-10-13 19:51 ` Dinh Nguyen
@ 2015-10-13 20:33   ` Steffen Trumtrar
  2015-10-13 21:16     ` Dinh Nguyen
  0 siblings, 1 reply; 4+ messages in thread
From: Steffen Trumtrar @ 2015-10-13 20:33 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, Alan Tull,
	linux-kernel, Rob Herring, Kumar Gala, delicious.quinoa,
	linux-arm-kernel

On Tue, Oct 13, 2015 at 02:51:28PM -0500, Dinh Nguyen wrote:
> On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:
> 
> > From: Alan Tull <atull@opensource.altera.com>
> > 
> > Add FPGA manager to device tree for SoCFPGA.
> > 
> > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > ---
> > v2: Remove 0x after @
> >     No caps in hex numbers
> >     renamed hps_0_fpgamgr to fpgamgr0
> >     move node to be in alpha order by node name
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> 
> Applied!

What about the

"Also, you need to document the "altr,socfpga-fpga-mgr"."

you mentioned in v1 ???

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: socfpga: dts: add fpga manager
  2015-10-13 20:33   ` Steffen Trumtrar
@ 2015-10-13 21:16     ` Dinh Nguyen
  0 siblings, 0 replies; 4+ messages in thread
From: Dinh Nguyen @ 2015-10-13 21:16 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: Alan Tull, Mark Rutland, devicetree, Pawel Moll, Ian Campbell,
	linux-kernel, Rob Herring, Kumar Gala, delicious.quinoa,
	linux-arm-kernel

On Tue, 13 Oct 2015, Steffen Trumtrar wrote:

> On Tue, Oct 13, 2015 at 02:51:28PM -0500, Dinh Nguyen wrote:
> > On Tue, 13 Oct 2015, atull@opensource.altera.com wrote:
> > 
> > > From: Alan Tull <atull@opensource.altera.com>
> > > 
> > > Add FPGA manager to device tree for SoCFPGA.
> > > 
> > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > ---
> > > v2: Remove 0x after @
> > >     No caps in hex numbers
> > >     renamed hps_0_fpgamgr to fpgamgr0
> > >     move node to be in alpha order by node name
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > 
> > Applied!
> 
> What about the
> 
> "Also, you need to document the "altr,socfpga-fpga-mgr"."
> 
> you mentioned in v1 ???
>

It was my oversight. It has already been documented. 

BR,
Dinh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-13 21:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 19:38 [PATCH v2] ARM: socfpga: dts: add fpga manager atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2015-10-13 19:51 ` Dinh Nguyen
2015-10-13 20:33   ` Steffen Trumtrar
2015-10-13 21:16     ` Dinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox