Re: [PATCH v4 3/3] device property: add test cases for fwnode_for_each_child_node()

Re: [PATCH v4 3/3] device property: add test cases for fwnode_for_each_child_node()

[Danilo Krummrich]

(Cc: OF)

On Thu Jun 11, 2026 at 10:31 PM CEST, Andy Shevchenko wrote:
> From: Xu Yang <xu.yang_2@nxp.com>
>
> Add test cases for fwnode_for_each_child_node() API.
>
> Test command:
> $ ./tools/testing/kunit/kunit.py run property-entry
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

This patch broke the build [1], hence I dropped it from the queue (but kept the
first two patches of this series).

of_node_init() can't be used from modules, either it needs EXPORT_SYMBOL_GPL()
itself, or of_node_ktype needs to be exported for this kunit test to work.

[1] https://lore.kernel.org/all/202607181651.RnUuV8n6-lkp@intel.com/

Re: [PATCH v4 3/3] device property: add test cases for fwnode_for_each_child_node()

[Andy Shevchenko]

On Sat, Jul 18, 2026 at 04:18:12PM +0200, Danilo Krummrich wrote:
> On Thu Jun 11, 2026 at 10:31 PM CEST, Andy Shevchenko wrote:
> >
> > Add test cases for fwnode_for_each_child_node() API.
> >
> > Test command:
> > $ ./tools/testing/kunit/kunit.py run property-entry
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> This patch broke the build [1], hence I dropped it from the queue (but kept the
> first two patches of this series).
> 
> of_node_init() can't be used from modules, either it needs EXPORT_SYMBOL_GPL()
> itself, or of_node_ktype needs to be exported for this kunit test to work.

Oh, thanks for pointing out.

> [1] https://lore.kernel.org/all/202607181651.RnUuV8n6-lkp@intel.com/

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v4 3/3] device property: add test cases for fwnode_for_each_child_node()

[Xu Yang]

Hi Danilo and Andy,

On Sun, Jul 19, 2026 at 11:37:49AM +0300, Andy Shevchenko wrote:
> On Sat, Jul 18, 2026 at 04:18:12PM +0200, Danilo Krummrich wrote:
> > On Thu Jun 11, 2026 at 10:31 PM CEST, Andy Shevchenko wrote:
> > >
> > > Add test cases for fwnode_for_each_child_node() API.
> > >
> > > Test command:
> > > $ ./tools/testing/kunit/kunit.py run property-entry
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > This patch broke the build [1], hence I dropped it from the queue (but kept the
> > first two patches of this series).
> > 
> > of_node_init() can't be used from modules, either it needs EXPORT_SYMBOL_GPL()
> > itself, or of_node_ktype needs to be exported for this kunit test to work.
> 
> Oh, thanks for pointing out.

Fix patches are sent:
https://lore.kernel.org/imx/20260720104730.1285552-1-xu.yang_2@oss.nxp.com/

Thanks,
Xu Yang