Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] iio: light: add support for veml6031x00 ALS series
Date: Thu, 13 Aug 2026 10:30:20 +0300	[thread overview]
Message-ID: <an1yjHnXyfXeCaWX@ashevche-desk.local> (raw)
In-Reply-To: <20260813022715.19d15cbf@jic23-huawei>

On Thu, Aug 13, 2026 at 02:27:15AM +0100, Jonathan Cameron wrote:
> On Thu, 13 Aug 2026 02:04:29 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> > On Wed, 12 Aug 2026 22:27:41 +0200
> > Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> > > +	}  
> > 
> > Trailing comma.  Maybe we'll add more after this and they will fit on one line.
> > Yeah it's a stretch but generally always add comma unless it is a specific
> > terminating entry.

Which is correct suggestion.

> Ah. Not such a stretch. I'd forgotten timestamp channels.  This creates
> unnecessary noise in the very next patch!

Exactly, so trailing comma here saves us from unneeded churn in the next patch.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-13  7:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 20:27 [PATCH v6 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-08-12 20:27 ` [PATCH v6 1/4] dt-bindings: iio: light: veml6030: add " Javier Carrasco
2026-08-12 20:27 ` [PATCH v6 2/4] iio: light: add support for " Javier Carrasco
2026-08-13  1:04   ` Jonathan Cameron
2026-08-13  1:27     ` Jonathan Cameron
2026-08-13  7:30       ` Andy Shevchenko [this message]
2026-08-17 11:03     ` Javier Carrasco
2026-08-13  6:59   ` Andy Shevchenko
2026-08-13  9:46     ` Javier Carrasco
2026-08-14  7:49       ` Andy Shevchenko
2026-08-14  8:58         ` Javier Carrasco
2026-08-14  9:07           ` Andy Shevchenko
2026-08-14  9:23             ` Javier Carrasco
2026-08-17  2:34             ` Jonathan Cameron
2026-08-12 20:27 ` [PATCH v6 3/4] iio: light: veml6031x00: add support for triggered buffers Javier Carrasco
2026-08-13  1:09   ` Jonathan Cameron
2026-08-13  8:34     ` Andy Shevchenko
2026-08-12 20:27 ` [PATCH v6 4/4] iio: light: veml6031x00: add support for events and trigger Javier Carrasco
2026-08-12 20:47   ` sashiko-bot
2026-08-13  1:24   ` Jonathan Cameron
2026-08-13 12:43     ` Javier Carrasco
2026-08-17  2:36       ` Jonathan Cameron
2026-08-17 10:41         ` Javier Carrasco
2026-08-13  8:41   ` Andy Shevchenko
2026-08-14 22:29   ` Javier Carrasco
2026-08-13  0:48 ` [PATCH v6 0/4] iio: light: add support for veml6031x00 ALS series Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an1yjHnXyfXeCaWX@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox