Re: [RESEND V2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

On Tue, Aug 04, 2026 at 09:37:14AM +0200, Krzysztof Kozlowski wrote:
> On Mon, Jul 27, 2026 at 02:11:20PM +0000, Prathamesh Shete wrote:
> > The DAP2_DIN and DAP2_DOUT pins were listed with swapped ball suffixes:
> > DAP2_DIN as PV7 and DAP2_DOUT as PW0. On silicon DAP2_DIN is on ball PW0
> > and DAP2_DOUT is on ball PV7. Correct the pin and drive group names to
> > dap2_din_pw0 and dap2_dout_pv7.
> > 
> > Fixes: 30a9d5162f25 ("dt-bindings: pinctrl: Document Tegra264 pin controllers")
> > Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> 
> This will break the users and only for fixing naming style? Are you sure
> it is worth beraking ABI?

This isn't just fixing the naming style, it's fixing the name of the
pins as they are referred to in a number of different places. With the
wrong ball suffix people might easily be confused as to what pin they
should be using.

So yes, I'd consider this a bug fix and worth an ABI break. The ABI
break is theoretical, too. This pin is currently not listed in any
upstream DTS files and all of the downstream ones I've seen use the
corrected suffix already.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]