Devicetree
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: tomm.merciai@gmail.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add USB2.0 placeholder nodes
Date: Tue, 25 Aug 2026 12:12:59 +0200	[thread overview]
Message-ID: <ao1qq7HOKvoOC8-F@tom-desktop> (raw)
In-Reply-To: <CAMuHMdUUAcrUbYV+_CFp5sZ1gQtn5eHzswZPvfZs=-=FX44DVg@mail.gmail.com>

Hi Geert,
Thanks for your review.

On Mon, Aug 24, 2026 at 04:36:10PM +0200, Geert Uytterhoeven wrote:
> Hi Tommaso,
> 
> On Tue, 18 Aug 2026 at 16:29, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > The USB2.0 wiring on the RZ SMARC Carrier-II board is the same for the
> > RZ/G3E and RZ/G3L SoMs, so the nodes belong in the shared
> > renesas-smarc2.dtsi. Enabling them there breaks the RZ/G3L SMARC EVK
> > build, as the r9a08g046 (RZ/G3L) SoC DTSI describes neither the USB2.0
> > host (OHCI/EHCI) nor function (HSUSB) instances:
> >
> > Error: arch/arm64/boot/dts/renesas/renesas-smarc2.dtsi:94.1-7 Label or path ehci0 not found
> > Error: arch/arm64/boot/dts/renesas/renesas-smarc2.dtsi:99.1-7 Label or path ehci1 not found
> > Error: arch/arm64/boot/dts/renesas/renesas-smarc2.dtsi:104.1-8 Label or path hsusb0 not found
> > Error: arch/arm64/boot/dts/renesas/renesas-smarc2.dtsi:114.1-7 Label or path ohci0 not found
> > Error: arch/arm64/boot/dts/renesas/renesas-smarc2.dtsi:119.1-7 Label or path ohci1 not found
> >
> > Add minimal placeholder nodes carrying only the reg property.
> > The remaining properties will be filled in once USB2.0 support for
> > RZ/G3L is complete.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > ---
> >  arch/arm64/boot/dts/renesas/r9a08g046.dtsi | 25 ++++++++++++++++++++++
> 
> FTR, this conflicts with Biju's "[PATCH v7 6/9] arm64: dts: renesas:
> r9a08g046: Add USB2.0 host/phy device nodes". which does add the real
> device nodes.
> 
> [1] https://lore.kernel.org/20260812141940.246223-7-biju.das.jz@bp.renesas.com

I will send v2 picking [2] and [3] from [1], then I will rework [4] to
properly disable common nodes from arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts.

In this way we can drop this patch.

[2] https://lore.kernel.org/all/20260812141940.246223-7-biju.das.jz@bp.renesas.com/
[3] https://lore.kernel.org/all/20260812141940.246223-8-biju.das.jz@bp.renesas.com/
[4] https://patchwork.kernel.org/project/linux-renesas-soc/patch/c2a9a45078773cd022cfec77578ed68c57921c73.1787062965.git.tommaso.merciai.xr@bp.renesas.com/


Kind regards,
Tommaso

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

  parent reply	other threads:[~2026-08-25 10:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 14:28 [PATCH 0/3] Add USB2.0 support for RZ/G3E Tommaso Merciai
2026-08-18 14:28 ` [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add USB2.0 placeholder nodes Tommaso Merciai
2026-08-18 14:35   ` sashiko-bot
2026-08-24 14:36   ` Geert Uytterhoeven
2026-08-24 15:21     ` Biju Das
2026-08-25 10:12     ` Tommaso Merciai [this message]
2026-08-18 14:29 ` [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add USB2.0 support Tommaso Merciai
2026-08-18 14:38   ` sashiko-bot
2026-08-18 14:29 ` [PATCH 3/3] arm64: dts: renesas: r9a09g047e57-smarc: Enable " Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao1qq7HOKvoOC8-F@tom-desktop \
    --to=tommaso.merciai.xr@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox