* [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526
@ 2026-08-24 2:27 Rudi Heitbaum
2026-08-24 11:38 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rudi Heitbaum @ 2026-08-24 2:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Mark Brown, Liam Girdwood, Heiko Stuebner, devicetree,
linux-kernel, rudi
The driver has accepted tcs,tcs4526 since commit 5eee5eced95f
("regulator: fan53555: add tcs4526"), which added the compatible to both
the of_device_id and i2c_device_id tables for the TCS4526, a chip that
reports id 0 rather than the TCS4525's id 12.
The binding was converted to DT schema afterwards, in commit 6cea468b680e
("regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema"), and
only picked up tcs,tcs4525. No in-tree DTS used the 4526 string at the
time, so nothing flagged the omission.
RK3399Pro boards use the TCS4526 for vdd_gpu and vdd_cpu_b, so a DTS
describing them fails dtbs_check today even though the driver binds
correctly.
Add the missing compatible.
Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
---
Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
index 69bae90fc4b2..1c54803d16eb 100644
--- a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
+++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
@@ -23,6 +23,7 @@ properties:
- silergy,syr827
- silergy,syr828
- tcs,tcs4525
+ - tcs,tcs4526
- items:
- const: rockchip,rk8601
- const: rockchip,rk8600
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526
2026-08-24 2:27 [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526 Rudi Heitbaum
@ 2026-08-24 11:38 ` Mark Brown
2026-08-24 16:37 ` Conor Dooley
2026-08-31 21:57 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-08-24 11:38 UTC (permalink / raw)
To: Rudi Heitbaum
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liam Girdwood,
Heiko Stuebner, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Mon, Aug 24, 2026 at 02:27:29AM +0000, Rudi Heitbaum wrote:
> The driver has accepted tcs,tcs4526 since commit 5eee5eced95f
> ("regulator: fan53555: add tcs4526"), which added the compatible to both
> the of_device_id and i2c_device_id tables for the TCS4526, a chip that
> reports id 0 rather than the TCS4525's id 12.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526
2026-08-24 2:27 [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526 Rudi Heitbaum
2026-08-24 11:38 ` Mark Brown
@ 2026-08-24 16:37 ` Conor Dooley
2026-08-31 21:57 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-08-24 16:37 UTC (permalink / raw)
To: Rudi Heitbaum
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mark Brown,
Liam Girdwood, Heiko Stuebner, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 75 bytes --]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526
2026-08-24 2:27 [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526 Rudi Heitbaum
2026-08-24 11:38 ` Mark Brown
2026-08-24 16:37 ` Conor Dooley
@ 2026-08-31 21:57 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-08-31 21:57 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rudi Heitbaum
Cc: Liam Girdwood, Heiko Stuebner, devicetree, linux-kernel
On Mon, 24 Aug 2026 02:27:29 +0000, Rudi Heitbaum wrote:
> dt-bindings: regulator: fan53555: add tcs,tcs4526
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.3
Thanks!
[1/1] dt-bindings: regulator: fan53555: add tcs,tcs4526
https://git.kernel.org/broonie/regulator/c/ca12149896ed
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-01 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 2:27 [PATCH] dt-bindings: regulator: fan53555: add tcs,tcs4526 Rudi Heitbaum
2026-08-24 11:38 ` Mark Brown
2026-08-24 16:37 ` Conor Dooley
2026-08-31 21:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox