From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Janani Sunil" <janani.sunil@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Michael Walle" <mwalle@kernel.org>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
jananisunil.dev@gmail.com,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v3 05/14] iio: adc: Add AD7768 and AD7768-4 core support
Date: Mon, 24 Aug 2026 18:06:48 +0300 [thread overview]
Message-ID: <aoxeCDspYo_jaBhx@ashevche-desk.local> (raw)
In-Reply-To: <31aa140058fde422c12e34fe926e7df01ba448df.camel@pengutronix.de>
On Mon, Aug 24, 2026 at 04:45:01PM +0200, Philipp Zabel wrote:
> On So, 2026-08-16 at 20:10 +0100, Jonathan Cameron wrote:
> > On Thu, 13 Aug 2026 15:56:58 +0200
> > Janani Sunil <janani.sunil@analog.com> wrote:
[...]
> > > +static int ad7768_reset(struct ad7768_state *st)
> > > +{
> > > + struct reset_control *reset_ctrl;
> > > + unsigned long reset_low_us;
> > > + unsigned long mclk;
> > > + int ret;
> > > +
> > > + reset_ctrl = devm_reset_control_get_optional_exclusive(regmap_get_device(st->regmap),
> >
> > Probably use a local variable for struct device *dev = regmap_get_device(st->regmap);
> > to reduce line length.
>
> Or just pass dev into ad7768_reset() as an additional parameter.
It might make code be less understandable as this function is not something
like devm_*(). I slightly prefer my suggestion over this one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-24 15:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 13:56 [PATCH v3 00/14] iio: adc: Add AD7768/AD7768-4 ADC driver support Janani Sunil
2026-08-13 13:56 ` [PATCH v3 01/14] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-08-16 18:24 ` Jonathan Cameron
2026-08-18 8:27 ` Janani Sunil
2026-08-22 1:45 ` Jonathan Cameron
2026-08-13 13:56 ` [PATCH v3 02/14] iio: backend: Add support for CRC Janani Sunil
2026-08-16 18:27 ` Jonathan Cameron
2026-08-16 18:33 ` Jonathan Cameron
2026-08-13 13:56 ` [PATCH v3 03/14] iio: adc: adi-axi-adc: Initialize state mutex Janani Sunil
2026-08-16 18:29 ` Jonathan Cameron
2026-08-13 13:56 ` [PATCH v3 04/14] iio: adc: adi-axi-adc: Add support for CRC Janani Sunil
2026-08-13 13:56 ` [PATCH v3 05/14] iio: adc: Add AD7768 and AD7768-4 core support Janani Sunil
[not found] ` <20260816201049.480143e1@jic23-huawei>
2026-08-24 14:45 ` Philipp Zabel
2026-08-24 15:06 ` Andy Shevchenko [this message]
2026-08-13 13:56 ` [PATCH v3 06/14] iio: adc: ad7768: Add configurable sampling modes Janani Sunil
2026-08-16 19:35 ` Jonathan Cameron
2026-08-13 13:57 ` [PATCH v3 07/14] iio: adc: ad7768: Add calibration controls Janani Sunil
2026-08-16 19:37 ` Jonathan Cameron
2026-08-13 13:57 ` [PATCH v3 08/14] iio: adc: ad7768: Add per-channel conversion delay Janani Sunil
2026-08-13 13:57 ` [PATCH v3 09/14] iio: adc: ad7768: Add VCM regulator support Janani Sunil
2026-08-16 19:46 ` Jonathan Cameron
2026-08-13 13:57 ` [PATCH v3 10/14] iio: adc: ad7768: Register GPIO auxiliary device Janani Sunil
2026-08-13 13:57 ` [PATCH v3 11/14] gpio: regmap: Use regmap_test_bits() for single bit reads Janani Sunil
2026-08-14 7:04 ` Linus Walleij
2026-08-14 7:28 ` Michael Walle
2026-08-14 8:28 ` Andy Shevchenko
2026-08-13 13:57 ` [PATCH v3 12/14] gpio: regmap: Add optional runtime PM support Janani Sunil
2026-08-14 7:07 ` Linus Walleij
2026-08-14 7:30 ` Michael Walle
2026-08-14 8:34 ` Andy Shevchenko
2026-08-16 17:59 ` Jonathan Cameron
2026-08-13 13:57 ` [PATCH v3 13/14] gpio: ad7768: Add AD7768 GPIO auxiliary driver Janani Sunil
2026-08-14 7:05 ` Linus Walleij
2026-08-14 8:43 ` Andy Shevchenko
2026-08-13 13:57 ` [PATCH v3 14/14] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-08-14 8:45 ` [PATCH v3 00/14] iio: adc: Add AD7768/AD7768-4 ADC driver support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoxeCDspYo_jaBhx@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=janani.sunil@analog.com \
--cc=jananisunil.dev@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=mwalle@kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox