Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps
@ 2026-08-10  5:13 Dipa Ramesh Mantre
  2026-08-18  9:19 ` Konrad Dybcio
  2026-08-31 16:20 ` Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: Dipa Ramesh Mantre @ 2026-08-10  5:13 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, gaurav.kohli,
	Dipa Ramesh Mantre

Add CPU mitigation cooling maps for pm8005 PMIC die temperature.
Throttle LITTLE (cpu0) and big (cpu3) clusters at 105°C and 125°C
trip points.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/pm8005.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8005.dtsi b/arch/arm64/boot/dts/qcom/pm8005.dtsi
index ce31a8545020..820d213b1cb2 100644
--- a/arch/arm64/boot/dts/qcom/pm8005.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8005.dtsi
@@ -3,10 +3,12 @@
 
 #include <dt-bindings/spmi/spmi.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	thermal-zones {
 		pm8005-thermal {
+			polling-delay-passive = <200>;
 			thermal-sensors = <&pm8005_tz>;
 
 			trips {
@@ -28,6 +30,20 @@ pm8005_trip2: trip2 {
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&pm8005_trip0>;
+					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+
+				map1 {
+					trip = <&pm8005_trip1>;
+					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
 		};
 	};
 };

---
base-commit: cc2b5f627e8ccbae1188ef2d8be3e451d7f933a5
change-id: 20260809-shikra-pmic-die-a6a43e17c1bc
prerequisite-message-id: <20260715-shikra_adc_support-v4-0-5e07b6d21429@oss.qualcomm.com>
prerequisite-patch-id: 7c371f4d9b9af04a9765b0b5b084c498e8979fb6
prerequisite-patch-id: dde0d9ae1d46c16407cfcfa818dd427904748af8
prerequisite-patch-id: aebf50762e984054665421a5a962e919947b16f7
prerequisite-patch-id: 6f74cc35e7368d525d7f7ebe6342f5d3c82f9d0f

Best regards,
-- 
Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps
  2026-08-10  5:13 [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps Dipa Ramesh Mantre
@ 2026-08-18  9:19 ` Konrad Dybcio
  2026-08-24  7:36   ` Dipa Ramesh Mantre (Temp)
  2026-08-31 16:20 ` Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2026-08-18  9:19 UTC (permalink / raw)
  To: Dipa Ramesh Mantre, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, gaurav.kohli

On 8/10/26 7:13 AM, Dipa Ramesh Mantre wrote:
> Add CPU mitigation cooling maps for pm8005 PMIC die temperature.
> Throttle LITTLE (cpu0) and big (cpu3) clusters at 105°C and 125°C
> trip points.
> 
> Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
> ---

You're making changes to a shared file with the intent of altering the
behavior of a specific platform. Furthermore, you don't explain how
the CPU frequency correlates to the temperature of the PMIC die, leaving
that to the imagination of the reader.


FYI:

$ rg pm8005.dtsi arch -l | sort
arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
arch/arm64/boot/dts/qcom/msm8998-mtp.dts
arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps
  2026-08-18  9:19 ` Konrad Dybcio
@ 2026-08-24  7:36   ` Dipa Ramesh Mantre (Temp)
  0 siblings, 0 replies; 4+ messages in thread
From: Dipa Ramesh Mantre (Temp) @ 2026-08-24  7:36 UTC (permalink / raw)
  To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, gaurav.kohli



On 8/18/2026 2:49 PM, Konrad Dybcio wrote:
> On 8/10/26 7:13 AM, Dipa Ramesh Mantre wrote:
>> Add CPU mitigation cooling maps for pm8005 PMIC die temperature.
>> Throttle LITTLE (cpu0) and big (cpu3) clusters at 105°C and 125°C
>> trip points.
>>
>> Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
>> ---
> 
> You're making changes to a shared file with the intent of altering the
> behavior of a specific platform. Furthermore, you don't explain how
> the CPU frequency correlates to the temperature of the PMIC die, leaving
> that to the imagination of the reader.

Thanks for the comment, will fix this and update the reasoning in the 
commit.

> 
> 
> FYI:
> 
> $ rg pm8005.dtsi arch -l | sort
> arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
> arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> arch/arm64/boot/dts/qcom/msm8998-mtp.dts
> arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
> arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
> arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> 
> Konrad

-- 
Thanks & Regards
Dipa Mantre


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps
  2026-08-10  5:13 [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps Dipa Ramesh Mantre
  2026-08-18  9:19 ` Konrad Dybcio
@ 2026-08-31 16:20 ` Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-08-31 16:20 UTC (permalink / raw)
  To: Dipa Ramesh Mantre
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, gaurav.kohli

On Mon, Aug 10, 2026 at 10:43:08AM +0530, Dipa Ramesh Mantre wrote:
> Add CPU mitigation cooling maps for pm8005 PMIC die temperature.
> Throttle LITTLE (cpu0) and big (cpu3) clusters at 105°C and 125°C
> trip points.
> 

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes:

Describe your problem. Whether your patch is a one-line bug fix or 5000
lines of a new feature, there must be an underlying problem that
motivated you to do this work. Convince the reviewer that there is a
problem worth fixing and that it makes sense for them to read past the
first paragraph.

> Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/pm8005.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8005.dtsi b/arch/arm64/boot/dts/qcom/pm8005.dtsi
> index ce31a8545020..820d213b1cb2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8005.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8005.dtsi
> @@ -3,10 +3,12 @@
>  
>  #include <dt-bindings/spmi/spmi.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/thermal/thermal.h>
>  
>  / {
>  	thermal-zones {
>  		pm8005-thermal {
> +			polling-delay-passive = <200>;
>  			thermal-sensors = <&pm8005_tz>;
>  
>  			trips {
> @@ -28,6 +30,20 @@ pm8005_trip2: trip2 {
>  					type = "critical";
>  				};
>  			};
> +
> +			cooling-maps {
> +				map0 {
> +					trip = <&pm8005_trip0>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +
> +				map1 {
> +					trip = <&pm8005_trip1>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
>  		};
>  	};
>  };
> 
> ---
> base-commit: cc2b5f627e8ccbae1188ef2d8be3e451d7f933a5
> change-id: 20260809-shikra-pmic-die-a6a43e17c1bc
> prerequisite-message-id: <20260715-shikra_adc_support-v4-0-5e07b6d21429@oss.qualcomm.com>
> prerequisite-patch-id: 7c371f4d9b9af04a9765b0b5b084c498e8979fb6
> prerequisite-patch-id: dde0d9ae1d46c16407cfcfa818dd427904748af8
> prerequisite-patch-id: aebf50762e984054665421a5a962e919947b16f7
> prerequisite-patch-id: 6f74cc35e7368d525d7f7ebe6342f5d3c82f9d0f

I'm guessing since you depend on some feature branch called "adc
support" this patch can't be applied. Work with your peers to land your
dependencies and then build and TEST on the clean upstream branch.

Thanks,
Bjorn

> 
> Best regards,
> -- 
> Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-31 16:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10  5:13 [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps Dipa Ramesh Mantre
2026-08-18  9:19 ` Konrad Dybcio
2026-08-24  7:36   ` Dipa Ramesh Mantre (Temp)
2026-08-31 16:20 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox