Re: [PATCH v5 1/5] dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller

[Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Missing Required Properties for new GPIO provider capabilities
> --
> 
> commit 384b355928f0212bcff0ab6c4447b15d28dc4109
> Author: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
> 
> dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
> 
> This commit documents the embedded GPIO controller within the TC9563 PCIe
> switch. It exposes the controller by adding the gpio-controller and
> #gpio-cells properties to the switch node, and updates the example to
> demonstrate downstream ports utilizing these lines.
> 
> > diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> > index f084830c6d0cb..c4ebb99f50c37 100644
> > --- a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> > +++ b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> > @@ -31,6 +31,11 @@ properties:
> >      description:
> >        GPIO controlling the RESX# pin.
> >  
> > +  gpio-controller: true
> > +
> > +  '#gpio-cells':
> > +    const: 2
> > +
> >    vdd18-supply: true
> >  
> >    vdd09-supply: true
> 
> [Severity: Medium]
> Does this binding need to include the newly added GPIO provider capabilities
> in the required properties list?

In order to introduce any ABI change, we decided to not define 'gpio-controller'
and '#gpio-cells' properties as required.

Regards,
Lorenzo

> 
> When hardware gains new provider capabilities, the subsystem guidelines
> stipulate that the corresponding standard properties (gpio-controller and
> #gpio-cells) must be added to the required properties list.
> 
> Looking at the required properties block further down in this file:
> 
> Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml:
> required:
>   - resx-gpios
>   - vdd18-supply
>   - vdd09-supply
>   - vddc-supply
>   - vddio1-supply
>   - vddio2-supply
>   - vddio18-supply
>   - i2c-parent
> 
> If gpio-controller and #gpio-cells are omitted from this list, device trees
> created with the pci1179,0623 compatible string but lacking these properties
> could silently pass dt_binding_check validation but fail at runtime when
> dependent subsystems attempt to use the GPIO functionality.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260909-pci-tc9563-aux-v5-0-c9b33f56c8d3@oss.qualcomm.com?part=1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]