Re: [PATCH v5 0/5] PCI/pwrctrl: tc9563: Introduce support for embedded GPIO controller

[Alex Elder <elder@riscstar.com>]

On 10/2/26 12:54 PM, Bjorn Helgaas wrote:
> [cc->to: Bjorn A for arm64 DTS, Linus, Bart for immutable branch question]
> 
> On Wed, Sep 23, 2026 at 03:43:50PM -0500, Bjorn Helgaas wrote:
>> On Wed, Sep 09, 2026 at 04:55:52PM +0200, Lorenzo Bianconi wrote:
>>> The TC9563 embeds a GPIO controller currently used for per-port reset
>>> signals.
>>> Add a driver for the GPIO controller embedded in the Toshiba TC9563 PCIe
>>> switch providing 37 GPIO lines. The controller is registered as an auxiliary
>>> device by the TC9563 power controller driver and accessed through the same
>>> i2c device.
>>> Please note this series is based on pwrctrl upstream branch.
>> ...
> 
>>> ---
>>> Alex Elder (1):
>>>        gpio: tc9563: Add support for the embedded GPIO controller
>>>
>>> Lorenzo Bianconi (4):
>>>        dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
>>>        PCI/pwrctrl: tc9563: Add GPIO auxiliary device support
>>>        PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API
>>>        arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller
>>>
>>>   .../devicetree/bindings/pci/toshiba,tc9563.yaml    |  14 +-
>>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |   7 +-
>>>   drivers/gpio/Kconfig                               |  11 ++
>>>   drivers/gpio/Makefile                              |   1 +
>>>   drivers/gpio/gpio-tc9563.c                         |  99 +++++++++++++
>>>   drivers/pci/pwrctrl/Kconfig                        |   1 +
>>>   drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c           | 165 +++++++++++++++++++--
>>>   include/linux/soc/qcom/tc9563.h                    |  19 +++
>>>   8 files changed, 300 insertions(+), 17 deletions(-)
>>> ---
>>> base-commit: 028f86457e822ab9de5b0d6d23efddc1b8b54ae1
>>> change-id: 20260731-pci-tc9563-aux-66a29d438f60
>>
>> Applied on pci/pwrctrl for v7.4, thank you!
> 
> I had applied the arch/arm64 DTS change:
> 
>    arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller
> 
> on pci/pwrctrl, but I think that was a mistake because that should be
> handled by Bjorn Andersson instead.

I'm only responding to this to provide slightly more explanation
about what you want to do.  Resetting pci/pwrctrl has no effect
on me.
> What I would *like* to do is rework the pci/pwrctrl branch to drop
> patch 5/5 (the arch/arm64 DTS change) and reorder the Alex's new gpio
> driver first so it's not in the middle of the tc9563 DT and driver
> updates:

Currently, the dt-bindings commit is before the gpio commit (and
followed by the two pwrctrl commits).  You want to reorder the
first two, as below.

					-Alex

>    gpio: tc9563: Add support for the embedded GPIO controller
>    dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
>    PCI/pwrctrl: tc9563: Add GPIO auxiliary device support
>    PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API
> 
> But I don't want to break anybody who assumed pci/pwrctrl was
> immutable and pulled it in already, e.g., to the GPIO tree.  Would
> this rework break anybody?