From: Chang Yu <marcus.yu.56@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Chang Yu" <marcus.yu.56@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: light: add AS7343 multi-spectral sensor driver
Date: Sun, 11 Oct 2026 11:12:27 +0800 [thread overview]
Message-ID: <asr-mzLLPXxGwV9F@zephyrus-g14.localdomain> (raw)
In-Reply-To: <arVqTWVw-eIZEcrR@ashevche-desk.local>
On Thu, Sep 24, 2026 at 09:22:05PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 19, 2026 at 04:51:45PM -0700, Chang Yu wrote:
> > +static int as7343_read_label(struct iio_dev *indio_dev,
> > + struct iio_chan_spec const *chan, char *label)
> > +{
> > + int channel = chan->channel;
>
> Why signed?
> Also split assignment, it will make code more maintainable.
>
I believe this was mentioned in a previous thread. Basically because
iio_chan_spec.channel is an int, so I had to make the local var
signed to keep it consistent. Why iio_chan_spec.channel is an int is
a mystery to me unfortunately.
next prev parent reply other threads:[~2026-10-11 3:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 23:51 [PATCH v5 0/2] Add support for AS7343 multi-spectral sensor Chang Yu
2026-09-19 23:51 ` [PATCH v5 1/2] dt-bindings: iio: light: add as7343 Chang Yu
2026-09-20 0:26 ` Jonathan Cameron
2026-09-19 23:51 ` [PATCH v5 2/2] iio: light: add AS7343 multi-spectral sensor driver Chang Yu
2026-09-20 0:04 ` sashiko-bot
2026-09-20 0:26 ` Jonathan Cameron
2026-09-21 4:21 ` Chang Yu
2026-09-24 18:22 ` Andy Shevchenko
2026-10-10 8:35 ` Chang Yu
2026-10-11 3:12 ` Chang Yu [this message]
2026-09-24 22:02 ` Jose A. Perez de Azpillaga
2026-09-25 0:52 ` Chang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asr-mzLLPXxGwV9F@zephyrus-g14.localdomain \
--to=marcus.yu.56@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox