From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: Document ASUS Transformer's Dock
Date: Wed, 18 Nov 2026 15:40:12 +0100 [thread overview]
Message-ID: <av24x_dcu2hggP5y@shikoro> (raw)
In-Reply-To: <20261118134555.195479-2-clamor95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
> .../bindings/i2c/asus,transformer-dock.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml b/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
> new file mode 100644
> index 0000000000000..5f4a40539c2b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
This is not an I2C controller, so "i2c" is not the proper directory, I'd
say. "connector" maybe? DT maintainers may have another suggestion.
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml
Hmm, this bindings only uses "i2c-parent" which is not even described in
the above file. Not your fault / problem, but we should describe it
somewhen somewhere central maybe? I guess the above $ref could be
dropped still.
No comments on the general approach, I'll leave this to DT and Asus
platform maintainers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-11-18 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:45 [PATCH v1 0/2] platform/asus: Add driver for ASUS Transformer's Dock Svyatoslav Ryhel
2026-11-18 13:45 ` [PATCH v1 1/2] dt-bindings: i2c: Document " Svyatoslav Ryhel
2026-11-18 14:40 ` Wolfram Sang [this message]
2026-11-18 13:45 ` [PATCH v1 2/2] platform/asus: Add driver for ASUS Transformer's Dock of Tegra based devices Svyatoslav Ryhel
2026-11-18 14:16 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av24x_dcu2hggP5y@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox