From: Chris Morgan <macroalpha82@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, heiko@sntech.de,
conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
sre@kernel.org, t.schramm@manjaro.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: power: cw2015: add cw2215, cw2217, and cw2218
Date: Thu, 19 Nov 2026 13:12:24 -0600 [thread overview]
Message-ID: <av9KGG70s_UAkKJO@neuromancer.localdomain> (raw)
In-Reply-To: <83695285-207e-4d0f-ada0-2273953e2eb9@kernel.org>
On Tue, Oct 27, 2026 at 04:57:12PM +0100, Krzysztof Kozlowski wrote:
> On 27/10/2026 14:17, Chris Morgan wrote:
> >
> > -allOf:
> > - - $ref: power-supply.yaml#
> > -
> > properties:
> > compatible:
> > - const: cellwise,cw2015
> > + enum:
> > + - cellwise,cw2015
> > + - cellwise,cw2215
> > + - cellwise,cw2217
> > + - cellwise,cw2218
> >
> > reg:
> > maxItems: 1
> > @@ -31,8 +32,6 @@ properties:
> > it is to mail two batteries to a test facility of CellWise and receive
> > back a test report with the binary blob.
> > $ref: /schemas/types.yaml#/definitions/uint8-array
> > - minItems: 64
> > - maxItems: 64
>
> This needs min/maxItems constraints.
I'm removing the constraints here and pushing it down below where there is
logic based on the compatible string. For the new cellwise,cw2217 the
constraint is 80, while the constraint remains 64 for other implementations.
>
> >
> > cellwise,monitor-interval-ms:
> > description:
> > @@ -41,7 +40,14 @@ properties:
> >
> > power-supplies:
> > minItems: 1
> > - maxItems: 8 # Should be enough
> > + maxItems: 8 # Should be enough
>
> Why changing? yamllint complained?
>
Yes, it did. Should I not fix it and ignore yamllint (since I'm not
actually modifying this line)?
> > +
> > + shunt-resistor-micro-ohms:
> > + description: |
>
> Do not need '|' unless you need to preserve formatting.
Understood, thank you.
>
> > + The value, in micro-ohms, of the shunt resistor used for sampling
> > + the battery current.
> > + minimum: 1000000
> > + maximum: 50000000
> >
> > monitored-battery: true
> >
> > @@ -49,6 +55,28 @@ required:
> > - compatible
> > - reg
> >
> > +allOf:
> > + - $ref: power-supply.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - cellwise,cw2015
> > + then:
> > + properties:
> > + shunt-resistor-micro-ohms: false
> > +
> > + cellwise,battery-profile:
> > + minItems: 64
> > + maxItems: 64
> > +
> > + else:
> > + properties:
> > + cellwise,battery-profile:
> > + minItems: 80
> > + maxItems: 80
>
> default for shunt-resistor-micro-ohms? or is it required for new devices?
I'll add a default, since there is a default value in the driver.
>
>
> Best regards,
> Krzysztof
>
Thank you,
Chris
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-19 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 13:17 [PATCH 0/3] Add Cellwise CW2217 Chris Morgan
2026-10-27 13:17 ` [PATCH 1/3] dt-bindings: power: cw2015: add cw2215, cw2217, and cw2218 Chris Morgan
2026-10-27 13:22 ` sashiko-bot
2026-10-27 15:57 ` Krzysztof Kozlowski
2026-11-19 19:12 ` Chris Morgan [this message]
2026-10-27 13:17 ` [PATCH 2/3] power: supply: cw2217: Add support for Cellwise cw2217 Chris Morgan
2026-10-27 13:31 ` sashiko-bot
2026-10-27 13:34 ` Shawn Lin
2026-10-27 15:46 ` Chris Morgan
2026-10-29 6:24 ` kernel test robot
2026-10-27 13:17 ` [PATCH 3/3] arm64: dts: rockchip: Add Battery Gauge to Anbernic Vita-Pro Chris Morgan
2026-10-27 13:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av9KGG70s_UAkKJO@neuromancer.localdomain \
--to=macroalpha82@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox