Devicetree
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Sheetal <sheetal@nvidia.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Frank Li <Frank.Li@kernel.org>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Thierry Reding <thierry.reding@kernel.org>,
	Mohan Kumar <mkumard@nvidia.com>,
	Sameer Pujar <spujar@nvidia.com>,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dmaengine: tegra210-adma: Make Tegra264 FIFO size explicit
Date: Thu, 12 Nov 2026 15:10:03 -0600	[thread overview]
Message-ID: <avYrK2KgrAVdOPtm@SMW015318> (raw)
In-Reply-To: <20261104110932.1097294-3-sheetal@nvidia.com>

On Wed, Nov 04, 2026 at 11:09:31AM +0000, Sheetal wrote:
>
> Tegra264 uses the same ADMA FIFO size for every ADMAIF request. The
> driver currently obtains this by setting sreq_index_offset to zero,
> which makes every valid request select a FIFO size of 2.
>
> Add a SoC data field for the uniform FIFO size and set it to 2 for
> Tegra264. Retain the request-index-based FIFO selection for earlier
> SoCs. This preserves existing FIFO programming and allows devices
> with a different uniform FIFO size to specify it in their SoC data.
>
> Signed-off-by: Sheetal <sheetal@nvidia.com>
> ---
...
>
>         ch_regs->tc = desc->period_len & ADMA_CH_TC_COUNT_MASK;
>
> @@ -1018,7 +1030,7 @@ static const struct tegra_adma_chip_data tegra264_chip_data = {
>         .ch_reg_size            = 0x100,
>         .nr_channels            = 64,
>         .ch_fifo_size_mask      = 0x7f,
> -       .sreq_index_offset      = 0,

Don't mix this change into this patch? if you want to remove reduntant
init 0, use seperate patch for it.

Frank

> +       .ch_fifo_size           = 2,
>         .max_page               = 10,
>         .set_global_pg_config   = tegra264_adma_global_page_config,
>  };
> --
> 2.43.0
>

  reply	other threads:[~2026-11-12 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 11:09 [PATCH 0/3] dmaengine: tegra210-adma: Add Tegra268 support Sheetal
2026-11-04 11:09 ` [PATCH 1/3] dt-bindings: dma: nvidia,tegra210-adma: " Sheetal
2026-11-12 21:05   ` Frank Li
2026-11-04 11:09 ` [PATCH 2/3] dmaengine: tegra210-adma: Make Tegra264 FIFO size explicit Sheetal
2026-11-12 21:10   ` Frank Li [this message]
2026-11-04 11:09 ` [PATCH 3/3] dmaengine: tegra210-adma: Add Tegra268 support Sheetal
2026-11-12 21:13   ` Frank Li
2026-11-11 14:12 ` [PATCH 0/3] " Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avYrK2KgrAVdOPtm@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sheetal@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox