Devicetree
 help / color / mirror / Atom feed
From: Mina Chou <minachou@andestech.com>
To: Conor Dooley <conor@kernel.org>
Cc: <pjw@kernel.org>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<alex@ghiti.fr>, <jic23@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<geert+renesas@glider.be>, <magnus.damm@gmail.com>,
	<prabhakar.mahadev-lad.rj@bp.renesas.com>,
	<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <randolph@andestech.com>,
	<cyyang772@andestech.com>, <tim609@andestech.com>,
	<az70021@gmail.com>
Subject: Re: [PATCH v2 16/19] riscv: errata: andes: allow ERRATA_ANDES_CMO on all Andes SoCs
Date: Tue, 17 Nov 2026 11:28:15 +0800	[thread overview]
Message-ID: <avvJz262LYxrlaXU@atcsi01.andestech.com> (raw)
In-Reply-To: <20261113-upon-unmarked-8f4a186bb656@spud>

On Fri, Nov 13, 2026 at 02:00:46PM +0000, Conor Dooley wrote:
> [EXTERNAL MAIL]

> Date: Fri, 13 Nov 2026 14:00:46 +0000
> From: Conor Dooley <conor@kernel.org>
> To: Mina Hui-Min Chou <minachou@andestech.com>
> Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
>  alex@ghiti.fr, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
>  conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com,
>  prabhakar.mahadev-lad.rj@bp.renesas.com, linux-riscv@lists.infradead.org,
>  devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
>  linux-kernel@vger.kernel.org, randolph@andestech.com,
>  cyyang772@andestech.com, tim609@andestech.com, az70021@gmail.com
> Subject: Re: [PATCH v2 16/19] riscv: errata: andes: allow ERRATA_ANDES_CMO
>  on all Andes SoCs
> 
> On Fri, Nov 13, 2026 at 03:11:40PM +0800, Mina Hui-Min Chou wrote:
> > ERRATA_ANDES_CMO depends on ARCH_R9A07G043, so it can only be enabled
> > for the Renesas RZ/Five, although other Andes SoCs such as those built
> > on the A27L2 need it too. Drop the dependency, and select
> > ANDES_LLCACHE and CACHEMAINT_FOR_DMA so that the errata always comes
> > with its cache driver, which ARCH_R9A07G043 used to guarantee.
> > 
> > As ERRATA_ANDES_CMO is default y, it is now also enabled in the generic
> > riscv defconfig. The errata only acts on Andes cores at boot, so other
> > platforms are not affected.
> > 
> > RZ/Five still gets uncached memory for coherent DMA allocations from the
> > DMA_GLOBAL_POOL that ARCH_R9A07G043 selects. This patch only covers
> > cache maintenance for streaming DMA; how other platforms provide uncached
> > memory stays platform specific.
> > 
> > Signed-off-by: Mina Hui-Min Chou <minachou@andestech.com>
> > ---
> >  arch/riscv/Kconfig.errata | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> > index 4f77b3c6d7fd..3c43e065aa01 100644
> > --- a/arch/riscv/Kconfig.errata
> > +++ b/arch/riscv/Kconfig.errata
> > @@ -12,7 +12,9 @@ config ERRATA_ANDES
> >  
> >  config ERRATA_ANDES_CMO
> >  	bool "Apply Andes cache management errata"
> > -	depends on ERRATA_ANDES && ARCH_R9A07G043
> > +	depends on ERRATA_ANDES
> > +	select ANDES_LLCACHE
> > +	select CACHEMAINT_FOR_DMA
> 
> If you're selecting it here, can you not drop it from the renesas soc
> Kconfig file?
> 

Thanks for catching that! ARCH_R9A07G043 selects ERRATA_ANDES_CMO,
so the selects there are redundant now. I will drop them in v3, something like:

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
@@ -465,8 +465,6 @@ config ARCH_R9A07G043
...
        select ARCH_RZG2L
-       select ANDES_LLCACHE
-       select CACHEMAINT_FOR_DMA

Thanks,
Mina

  reply	other threads:[~2026-11-17  3:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  7:11 [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 01/19] cache: ax45mp_cache: use __initconst for ax45mp_cmo_ops Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 02/19] cache: ax45mp_cache: rename AX45MP-specific identifiers to generic ANDES Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 03/19] cache: ax45mp_cache: rename L2 identifiers to LLC Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 04/19] cache: ax45mp_cache: add shared header for Andes CSRs Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 05/19] cache: ax45mp_cache: standardize macro naming for LLC and L1D registers Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 06/19] cache: ax45mp_cache: rename ax45mp_cache.c to andes_llcache.c Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 07/19] cache: andes_llcache: clean up cache inv/wback functions Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 08/19] cache: andes_llcache: use u32 and fix the cache-line-size error message Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 09/19] cache: andes_llcache: write the full physical address for CCTL Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 10/19] cache: andes_llcache: register cache ops only when the errata needs them Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 11/19] cache: andes_llcache: use the hart ID to index the CCTL registers Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 12/19] dt-bindings: cache: andestech: update schema for generic LLC support Mina Hui-Min Chou
2026-11-13 14:05   ` Conor Dooley
2026-11-16 12:05     ` Krzysztof Kozlowski
2026-11-16 18:00       ` Conor Dooley
2026-11-17  9:20         ` Mina Chou
2026-11-13  7:11 ` [PATCH v2 13/19] dt-bindings: cache: rename andestech,ax45mp-cache to andestech,llcache Mina Hui-Min Chou
2026-11-13 14:01   ` Conor Dooley
2026-11-16 12:01   ` Krzysztof Kozlowski
2026-11-13  7:11 ` [PATCH v2 14/19] cache: andes_llcache: add generic andestech,llcache compatible Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 15/19] MAINTAINERS: Add maintainer for Andes cache driver Mina Hui-Min Chou
2026-11-13  7:11 ` [PATCH v2 16/19] riscv: errata: andes: allow ERRATA_ANDES_CMO on all Andes SoCs Mina Hui-Min Chou
2026-11-13 14:00   ` Conor Dooley
2026-11-17  3:28     ` Mina Chou [this message]
2026-11-13  7:11 ` [PATCH v2 17/19] riscv: errata: andes: generalize cache errata for Andes cores Mina Hui-Min Chou
2026-11-13 13:59   ` Conor Dooley
2026-11-13  7:11 ` [PATCH v2 18/19] riscv: errata: andes: limit the IOCP workaround to RZ/Five Mina Hui-Min Chou
2026-11-13 13:53   ` Conor Dooley
2026-11-17  9:24     ` Mina Chou
2026-11-13 16:21 ` [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Conor Dooley
2026-11-16  1:22   ` Mina Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avvJz262LYxrlaXU@atcsi01.andestech.com \
    --to=minachou@andestech.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=az70021@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=cyyang772@andestech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=magnus.damm@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=randolph@andestech.com \
    --cc=robh@kernel.org \
    --cc=tim609@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox