From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Korsgaard <peter@korsgaard.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property
Date: Thu, 2 Jan 2025 19:22:57 +0100 [thread overview]
Message-ID: <b3b8aa28-24d3-4952-a8d3-7019ad4c63de@kernel.org> (raw)
In-Reply-To: <20250102175041.822977-1-peter@korsgaard.com>
On 02/01/2025 18:50, Peter Korsgaard wrote:
> The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
> always be desirable because of noise or power consumption peaks, so add an
> optional "default-pwm" property that can be used to specify a custom default
> PWM duty cycle.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
That's v3, not v1. Also mention here shortly how Rob's comment is addressed.
Please always handle reviewers' feedback, either by implementing it or
by responding or by extending commit msg. All this is missing in all
your versions you sent.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-02 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 17:50 [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Peter Korsgaard
2025-01-02 17:50 ` [PATCH 2/2] hwmon: (pwm-fan): Make default PWM duty cycle configurable Peter Korsgaard
2025-01-02 18:22 ` Krzysztof Kozlowski [this message]
2025-01-03 7:59 ` [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Peter Korsgaard
2025-01-03 8:10 ` Krzysztof Kozlowski
2025-01-03 9:01 ` Peter Korsgaard
2025-01-03 9:35 ` Krzysztof Kozlowski
2025-01-03 9:42 ` Peter Korsgaard
2025-01-02 19:24 ` Rob Herring (Arm)
2025-01-03 9:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b8aa28-24d3-4952-a8d3-7019ad4c63de@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter@korsgaard.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox