From: Peter Korsgaard <peter@korsgaard.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property
Date: Fri, 3 Jan 2025 10:16:23 +0100 [thread overview]
Message-ID: <c14e5b92-5952-4c7f-a64c-38e579278fa2@korsgaard.com> (raw)
In-Reply-To: <173584586623.427850.4042944653628496064.robh@kernel.org>
On 1/2/25 20:24, Rob Herring (Arm) wrote:
>
> On Thu, 02 Jan 2025 18:50:40 +0100, Peter Korsgaard wrote:
>> The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
>> always be desirable because of noise or power consumption peaks, so add an
>> optional "default-pwm" property that can be used to specify a custom default
>> PWM duty cycle.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml: default-pwm: missing type definition
> Error: Documentation/devicetree/bindings/hwmon/pwm-fan.example.dts:75.25-27 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/hwmon/pwm-fan.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
> make: *** [Makefile:251: __sub-make] Error 2
Ups, I added the entry to the example AFTER running make
dt_binding_check and missed the <>, will fix.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2025-01-03 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 17:50 [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Peter Korsgaard
2025-01-02 17:50 ` [PATCH 2/2] hwmon: (pwm-fan): Make default PWM duty cycle configurable Peter Korsgaard
2025-01-02 18:22 ` [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Krzysztof Kozlowski
2025-01-03 7:59 ` Peter Korsgaard
2025-01-03 8:10 ` Krzysztof Kozlowski
2025-01-03 9:01 ` Peter Korsgaard
2025-01-03 9:35 ` Krzysztof Kozlowski
2025-01-03 9:42 ` Peter Korsgaard
2025-01-02 19:24 ` Rob Herring (Arm)
2025-01-03 9:16 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14e5b92-5952-4c7f-a64c-38e579278fa2@korsgaard.com \
--to=peter@korsgaard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox