* [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys
@ 2026-08-24 13:45 Abel Vesa
2026-09-02 8:30 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2026-08-24 13:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
The Eliza CQS EVK has three tactile switches: SYS_ON, Volume Down,
and Volume Up.
Enable the existing PMK8550 PON power and resin keys for SYS_ON and
Volume Down. Describe Volume Up, which is connected to PM7550 GPIO6.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
index 5e4175291f05..2e7dd8dbaa22 100644
--- a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
@@ -14,6 +14,19 @@ / {
model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
compatible = "qcom,eliza-cqs-evk", "qcom,eliza-cqs-som", "qcom,eliza";
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ key-volume-up {
+ label = "Volume Up";
+ linux,code = <KEY_VOLUMEUP>;
+ gpios = <&pm7550_gpios 6 GPIO_ACTIVE_LOW>;
+ debounce-interval = <10>;
+ linux,can-disable;
+ wakeup-source;
+ };
+ };
+
sound {
compatible = "qcom,eliza-sndcard", "qcom,sm8450-sndcard";
model = "eliza-cqs-evk";
@@ -83,6 +96,15 @@ &lpass_vamacro {
qcom,dmic-sample-rate = <4800000>;
};
+&pon_pwrkey {
+ status = "okay";
+};
+
+&pon_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
&swr0 {
pinctrl-0 = <&wsa_swr_active>;
pinctrl-names = "default";
---
base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
change-id: 20260824-dts-qcom-eliza-evk-add-volume-up-a73c65710667
Best regards,
--
Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys
2026-08-24 13:45 [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys Abel Vesa
@ 2026-09-02 8:30 ` Konrad Dybcio
2026-09-02 8:52 ` Abel Vesa
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2026-09-02 8:30 UTC (permalink / raw)
To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 8/24/26 3:45 PM, Abel Vesa wrote:
> The Eliza CQS EVK has three tactile switches: SYS_ON, Volume Down,
> and Volume Up.
>
> Enable the existing PMK8550 PON power and resin keys for SYS_ON and
> Volume Down. Describe Volume Up, which is connected to PM7550 GPIO6.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Can this go to eliza-evk.dtsi instead?
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys
2026-09-02 8:30 ` Konrad Dybcio
@ 2026-09-02 8:52 ` Abel Vesa
2026-09-03 7:26 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2026-09-02 8:52 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 26-09-02 10:30:38, Konrad Dybcio wrote:
> On 8/24/26 3:45 PM, Abel Vesa wrote:
> > The Eliza CQS EVK has three tactile switches: SYS_ON, Volume Down,
> > and Volume Up.
> >
> > Enable the existing PMK8550 PON power and resin keys for SYS_ON and
> > Volume Down. Describe Volume Up, which is connected to PM7550 GPIO6.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > ---
>
> Can this go to eliza-evk.dtsi instead?
They can, but what happens if the CQM variant remaps them to some
different gpio? I don't know what CQM looks like. I guess we can hope
they do not change.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys
2026-09-02 8:52 ` Abel Vesa
@ 2026-09-03 7:26 ` Konrad Dybcio
2026-09-03 11:02 ` Abel Vesa
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2026-09-03 7:26 UTC (permalink / raw)
To: Abel Vesa
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 9/2/26 10:52 AM, Abel Vesa wrote:
> On 26-09-02 10:30:38, Konrad Dybcio wrote:
>> On 8/24/26 3:45 PM, Abel Vesa wrote:
>>> The Eliza CQS EVK has three tactile switches: SYS_ON, Volume Down,
>>> and Volume Up.
>>>
>>> Enable the existing PMK8550 PON power and resin keys for SYS_ON and
>>> Volume Down. Describe Volume Up, which is connected to PM7550 GPIO6.
>>>
>>> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
>>> ---
>>
>> Can this go to eliza-evk.dtsi instead?
>
> They can, but what happens if the CQM variant remaps them to some
> different gpio? I don't know what CQM looks like.
Can you find out?
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys
2026-09-03 7:26 ` Konrad Dybcio
@ 2026-09-03 11:02 ` Abel Vesa
0 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-09-03 11:02 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 26-09-03 09:26:29, Konrad Dybcio wrote:
> On 9/2/26 10:52 AM, Abel Vesa wrote:
> > On 26-09-02 10:30:38, Konrad Dybcio wrote:
> >> On 8/24/26 3:45 PM, Abel Vesa wrote:
> >>> The Eliza CQS EVK has three tactile switches: SYS_ON, Volume Down,
> >>> and Volume Up.
> >>>
> >>> Enable the existing PMK8550 PON power and resin keys for SYS_ON and
> >>> Volume Down. Describe Volume Up, which is connected to PM7550 GPIO6.
> >>>
> >>> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> >>> ---
> >>
> >> Can this go to eliza-evk.dtsi instead?
> >
> > They can, but what happens if the CQM variant remaps them to some
> > different gpio? I don't know what CQM looks like.
>
> Can you find out?
Just discussed it with the HW engineer. It is the same on CQM.
So I'll move it to eliza-evk.dtsi instead.
Thanks for reviewing.
Abel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-03 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 13:45 [PATCH] arm64: dts: qcom: eliza-cqs-evk: Add power and volume keys Abel Vesa
2026-09-02 8:30 ` Konrad Dybcio
2026-09-02 8:52 ` Abel Vesa
2026-09-03 7:26 ` Konrad Dybcio
2026-09-03 11:02 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox