* [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d
@ 2024-06-17 2:43 Jacobe Zang
2024-06-17 6:18 ` Krzysztof Kozlowski
2024-06-18 11:09 ` Arend Van Spriel
0 siblings, 2 replies; 5+ messages in thread
From: Jacobe Zang @ 2024-06-17 2:43 UTC (permalink / raw)
To: kvalo, davem, edumazet, kuba, pabeni, robh, krzk+dt, conor+dt
Cc: nick, arend, linux-wireless, netdev, devicetree, linux-kernel,
Jacobe Zang
It's a Broadcom Wi-Fi module connected via the PCIe interface and also
add prefix in vendor-prefix.yaml
Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u
Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
---
.../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index e564f20d8f415..0477566acd72a 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -53,6 +53,7 @@ properties:
- pci14e4,4488 # BCM4377
- pci14e4,4425 # BCM4378
- pci14e4,4433 # BCM4387
+ - pci14e4,449d # BCM4329
reg:
description: SDIO function number for the device (for most cases
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d
2024-06-17 2:43 [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d Jacobe Zang
@ 2024-06-17 6:18 ` Krzysztof Kozlowski
2024-06-17 6:30 ` Jacobe Zang
2024-06-18 11:09 ` Arend Van Spriel
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-17 6:18 UTC (permalink / raw)
To: Jacobe Zang, kvalo, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt
Cc: nick, arend, linux-wireless, netdev, devicetree, linux-kernel
On 17/06/2024 04:43, Jacobe Zang wrote:
> It's a Broadcom Wi-Fi module connected via the PCIe interface and also
> add prefix in vendor-prefix.yaml
You do not add prefix here. Drop unrelated parts of commit msg.
>
> Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u
Link also does not seem to be really relevant to the commit. No point to
keep it in the git log. You can always provide additional information in
the changelog section (---).
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d
2024-06-17 6:18 ` Krzysztof Kozlowski
@ 2024-06-17 6:30 ` Jacobe Zang
0 siblings, 0 replies; 5+ messages in thread
From: Jacobe Zang @ 2024-06-17 6:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, kvalo@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: Nick Xie, arend@broadcom.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> You do not add prefix here. Drop unrelated parts of commit msg.
OK, I will remove unrelated parts. The reason why I added it is that when I do ./script/checkpatch.pl the patch, it said the compatible is not document.
---
Best Regards
Jacobe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d
2024-06-17 2:43 [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d Jacobe Zang
2024-06-17 6:18 ` Krzysztof Kozlowski
@ 2024-06-18 11:09 ` Arend Van Spriel
2024-06-18 14:47 ` Sebastian Reichel
1 sibling, 1 reply; 5+ messages in thread
From: Arend Van Spriel @ 2024-06-18 11:09 UTC (permalink / raw)
To: Jacobe Zang, kvalo, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt
Cc: nick, arend, linux-wireless, netdev, devicetree, linux-kernel
On 6/17/2024 4:43 AM, Jacobe Zang wrote:
> It's a Broadcom Wi-Fi module connected via the PCIe interface and also
> add prefix in vendor-prefix.yaml
>
> Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index e564f20d8f415..0477566acd72a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -53,6 +53,7 @@ properties:
> - pci14e4,4488 # BCM4377
> - pci14e4,4425 # BCM4378
> - pci14e4,4433 # BCM4387
> + - pci14e4,449d # BCM4329
I can not find that device id. Can you provide more information where
you came across this device. The BCM4329 as I know it is an 802.11n
*SDIO* device. Not a PCI device.
Regards,
Arend
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d
2024-06-18 11:09 ` Arend Van Spriel
@ 2024-06-18 14:47 ` Sebastian Reichel
0 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2024-06-18 14:47 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Jacobe Zang, kvalo, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt, nick, arend, linux-wireless, netdev, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
Hi,
On Tue, Jun 18, 2024 at 01:09:07PM GMT, Arend Van Spriel wrote:
> On 6/17/2024 4:43 AM, Jacobe Zang wrote:
> > It's a Broadcom Wi-Fi module connected via the PCIe interface and also
> > add prefix in vendor-prefix.yaml
> >
> > Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u
> > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> > ---
> > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > index e564f20d8f415..0477566acd72a 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > @@ -53,6 +53,7 @@ properties:
> > - pci14e4,4488 # BCM4377
> > - pci14e4,4425 # BCM4378
> > - pci14e4,4433 # BCM4387
> > + - pci14e4,449d # BCM4329
>
> I can not find that device id. Can you provide more information where you
> came across this device. The BCM4329 as I know it is an 802.11n *SDIO*
> device. Not a PCI device.
It's the device id used by AP6275P, see this discussion from half a
year ago [0]. It is used by Rockchip's RK3588 evaluation board, which
apparently resulted in some RK3588 boards using the same chip.
[0] https://patchwork.kernel.org/project/linux-wireless/patch/c7b331edd65b66521a6605177d654e55051568a3.camel@toradex.com/
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-18 14:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-17 2:43 [PATCH v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d Jacobe Zang
2024-06-17 6:18 ` Krzysztof Kozlowski
2024-06-17 6:30 ` Jacobe Zang
2024-06-18 11:09 ` Arend Van Spriel
2024-06-18 14:47 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox